From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id C69CF3257 for ; Fri, 12 Jan 2018 03:01:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jan 2018 18:01:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,347,1511856000"; d="scan'208";a="194230450" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by fmsmga005.fm.intel.com with ESMTP; 11 Jan 2018 18:01:41 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.108]) by PGSMSX107.gar.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0319.002; Fri, 12 Jan 2018 10:01:39 +0800 From: "Zhao1, Wei" To: David C Harton , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH v3] net/i40e: fix VF reset stats crash Thread-Index: AQHTiu7TcWfFl+q3ek69bGplg5zFdaNve9LA Date: Fri, 12 Jan 2018 02:01:38 +0000 Message-ID: References: <20180111134814.1224-1-dharton@cisco.com> <20180111151358.20102-1-dharton@cisco.com> In-Reply-To: <20180111151358.20102-1-dharton@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix VF reset stats crash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 02:01:44 -0000 Hi, > -----Original Message----- > From: David C Harton [mailto:dharton@cisco.com] > Sent: Thursday, January 11, 2018 11:14 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; David C Harton ; Zhao1, Wei > > Subject: [PATCH v3] net/i40e: fix VF reset stats crash >=20 > Calling i40evf_dev_xstats_reset can sometimes crash. >=20 > Fixed issue by checking return code before using pstats. >=20 > Fixes: 8210e9e0d805e ("net/i40e: fix clear xstats bug in VF") > Cc: wei.zhao1@intel.com >=20 > Signed-off-by: David C Harton > --- >=20 > v2: > * Fixed fixes line in commit message. >=20 > v3: > * Modified conditional to check ret code instead of pointer. >=20 >=20 > drivers/net/i40e/i40e_ethdev_vf.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > b/drivers/net/i40e/i40e_ethdev_vf.c > index b96d77a..d5a9edb 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -916,14 +916,16 @@ i40evf_update_stats(struct i40e_vsi *vsi, static > void i40evf_dev_xstats_reset(struct rte_eth_dev *dev) { > + int ret; > struct i40e_vf *vf =3D I40EVF_DEV_PRIVATE_TO_VF(dev->data- > >dev_private); > struct i40e_eth_stats *pstats =3D NULL; >=20 > /* read stat values to clear hardware registers */ > - i40evf_query_stats(dev, &pstats); > + ret =3D i40evf_query_stats(dev, &pstats); >=20 > /* set stats offset base on current values */ > - vf->vsi.eth_stats_offset =3D *pstats; > + if (ret =3D=3D 0) > + vf->vsi.eth_stats_offset =3D *pstats; > } >=20 > static int i40evf_dev_xstats_get_names(__rte_unused struct rte_eth_dev > *dev, > -- > 2.10.3.dirty Acked-by: Wei Zhao