From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API
Date: Fri, 12 Jan 2018 05:50:18 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07C97CAE@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <c79ed7dc-0aa8-fff7-cbd5-31a946e75783@intel.com>
Hi, Ferruh
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, January 10, 2018 9:29 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API
>
> On 1/10/2018 2:10 AM, Wei Zhao wrote:
> > Rte_flow actually defined to include RSS, but till now, RSS is out of
> > rte_flow.
> > This patch is to move i40e existing RSS to rte_flow.
> > This patch also enable queue region configuration using flow API for
> > i40e.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>
> <...>
>
> > @@ -4269,6 +4597,9 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
> > ret = i40e_flow_add_del_fdir_filter(dev,
> > &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
> > break;
> > + case RTE_ETH_FILTER_HASH:
> > + ret = i40e_config_rss_filter_del(dev,
> > + (struct i40e_rte_flow_rss_conf *)flow->rule);
>
> This is causing build error [1], if the fallback is intentional compiler expects a
> /* Fallthrough */ comment.
>
> [1]
> .../drivers/net/i40e/i40e_flow.c:4601:7: error: this statement may fall
> through [-Werror=implicit-fallthrough=]
> ret = i40e_config_rss_filter_del(dev,
>
> ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> (struct i40e_rte_flow_rss_conf *)flow->rule);
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../drivers/net/i40e/i40e_flow.c:4603:2: note: here
>
> default:
> ^~~~~~~
It seems there miss a "break" after "case:" and before " default:",
I will commit a fix patch to dpdk-next-net-intel branch today.
next prev parent reply other threads:[~2018-01-12 5:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 8:43 [dpdk-dev] [PATCH] " Wei Zhao
2017-12-21 3:12 ` Zhang, Helin
2017-12-22 4:36 ` Zhang, Qi Z
2018-01-07 15:43 ` Zhang, Helin
2018-01-08 1:53 ` Zhao1, Wei
2018-01-08 8:30 ` Zhao1, Wei
2018-01-08 8:33 ` Zhao1, Wei
2018-01-08 8:35 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-01-09 2:33 ` Zhang, Qi Z
2018-01-10 1:53 ` Zhao1, Wei
2018-01-09 9:18 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-01-10 2:10 ` [dpdk-dev] [PATCH v4] " Wei Zhao
2018-01-10 2:58 ` Zhang, Qi Z
2018-01-10 3:36 ` Zhang, Helin
2018-01-10 13:28 ` Ferruh Yigit
2018-01-12 5:50 ` Zhao1, Wei [this message]
2018-01-12 6:23 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07C97CAE@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).