[dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 016a08c..4b59027 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -210,6 +210,23 @@ New Features
 
   Updated ixgbe ethernet PMD to support ``rte_security`` inline IPSec offload.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated to different queues in
+  different queue regions.
+
+* **Added the testpmd app to support queue region configuration with CLI.**
+
+  This patch add a API configuration of queue region in rss with command line.
+  It can parse the parameters of region index, queue number,
+  queue start index, user priority, traffic classes and so on.
+  According to commands from command line, it will call i40e
+  private API and start the process of set or flush queue region
+  configure. As this feature is specific for i40e, so private API
+  will be used. Aslo add a document for these new commands.
+
 * **Updated ipsec-secgw application to support rte_security.**
 
   Updated the ``ipsec-secgw`` sample application to support ``rte_security``
-- 
2.9.3

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Ferruh Yigit]

On 12/20/2017 7:52 PM, Wei Zhao wrote:
> This patch add inforation about i40e queue region
> realted to release notes, it has been missed before.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++

I think we shouldn't update release notes once it has been released.

Perhaps it can be an option to mention from this in latest release notes with a
note that says actual support added in v17.11?

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Zhao1, Wei]

Ok, this will be updating in release notes for v18.02, 
and have a mention that this feature has been implemented in v17.11?



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 22, 2017 2:10 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> release notes
> 
> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> 
> I think we shouldn't update release notes once it has been released.
> 
> Perhaps it can be an option to mention from this in latest release notes with
> a note that says actual support added in v17.11?

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Ferruh Yigit]

On 12/21/2017 5:36 PM, Zhao1, Wei wrote:
> Ok, this will be updating in release notes for v18.02, 
> and have a mention that this feature has been implemented in v17.11?

I think mentioning from first implemented release helps to reduce confusion, in
case users interested in implementation details etc... But no strong opinion.

> 
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Friday, December 22, 2017 2:10 AM
>> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
>> Cc: Mcnamara, John <john.mcnamara@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
>> release notes
>>
>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>> This patch add inforation about i40e queue region realted to release
>>> notes, it has been missed before.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> ---
>>>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>
>> I think we shouldn't update release notes once it has been released.
>>
>> Perhaps it can be an option to mention from this in latest release notes with
>> a note that says actual support added in v17.11?

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Zhao1, Wei]

Ok， I will commit a new patch as this way.


> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Friday, December 22, 2017 11:26 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> release notes
> 
> On 12/21/2017 5:36 PM, Zhao1, Wei wrote:
> > Ok, this will be updating in release notes for v18.02, and have a
> > mention that this feature has been implemented in v17.11?
> 
> I think mentioning from first implemented release helps to reduce confusion,
> in case users interested in implementation details etc... But no strong opinion.
> 
> >
> >
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Friday, December 22, 2017 2:10 AM
> >> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> >> Cc: Mcnamara, John <john.mcnamara@intel.com>
> >> Subject: Re: [dpdk-dev] [PATCH] doc: add queue region feature info to
> >> release notes
> >>
> >> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> >>> This patch add inforation about i40e queue region realted to release
> >>> notes, it has been missed before.
> >>>
> >>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >>> ---
> >>>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> >>
> >> I think we shouldn't update release notes once it has been released.
> >>
> >> Perhaps it can be an option to mention from this in latest release
> >> notes with a note that says actual support added in v17.11?

[dpdk-dev] [PATCH v2] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change this information to v18.02 release notes.
---
 doc/guides/rel_notes/release_18_02.rst | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 24b67bb..0e9f17b 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -41,6 +41,23 @@ New Features
      Also, make sure to start the actual text at the margin.
      =========================================================
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated to different queues in
+  different queue regions. This feature has been implemented in v17.11.
+
+* **Added the testpmd app to support queue region configuration with CLI.**
+
+  This patch add a API configuration of queue region in rss with command line.
+  It can parse the parameters of region index, queue number,
+  queue start index, user priority, traffic classes and so on.
+  According to commands from command line, it will call i40e
+  private API and start the process of set or flush queue region
+  configure. As this feature is specific for i40e, so private API
+  will be used. Aslo add a document for these new commands.
+  This feature has been implemented in v17.11.
 
 API Changes
 -----------
-- 
2.9.3

Re: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release notes

[Zhang, Helin]

Hi John

Could you help to review with ACK or comments? :)

Hi Wei

'Git am' failure is as below. Please fix it on dpdk-next-net-intel sub tree. Thanks!

Description: [dpdk-dev,v2] doc: add queue region feature info to release notes
Applying: doc: add queue region feature info to release notes
error: patch failed: doc/guides/rel_notes/release_18_02.rst:41
error: doc/guides/rel_notes/release_18_02.rst: patch does not apply
Patch failed at 0001 doc: add queue region feature info to release notes

Regards,
Helin

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> Sent: Wednesday, January 3, 2018 4:13 PM
> To: dev@dpdk.org
> Cc: Mcnamara, John; Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release
> notes
I'd suggest to use 'update release notes with queue region feature'
> 
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
This patch updates the releases notes with queue region feature which was
enabled in 17.11 in silence.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> 
> ---
> 
> v2:
> -change this information to v18.02 release notes.
> ---
>  doc/guides/rel_notes/release_18_02.rst | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 24b67bb..0e9f17b 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -41,6 +41,23 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =========================================================
> 
> +* **Added the i40e ethernet driver to support queue region feature.**
> +
> +  This feature enable queue regions configuration for RSS in PF,  so
> + that different traffic classes or different packet  classification
> + types can be separated to different queues in  different queue
> + regions. This feature has been implemented in v17.11.
> +
> +* **Added the testpmd app to support queue region configuration with
> +CLI.**
> +
> +  This patch add a API configuration of queue region in rss with command
> line.
> +  It can parse the parameters of region index, queue number,  queue
> + start index, user priority, traffic classes and so on.
> +  According to commands from command line, it will call i40e  private
> + API and start the process of set or flush queue region  configure. As
> + this feature is specific for i40e, so private API  will be used. Aslo
> + add a document for these new commands.
> +  This feature has been implemented in v17.11.
> 
>  API Changes
>  -----------
> --
> 2.9.3

Re: [dpdk-dev] [PATCH v2] doc: add queue region feature info to release notes

[Zhao1, Wei]

Hi, helin

> -----Original Message-----
> From: Zhang, Helin
> Sent: Sunday, January 7, 2018 11:52 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] doc: add queue region feature info to
> release notes
> 
> Hi John
> 
> Could you help to review with ACK or comments? :)
> 
> Hi Wei
> 
> 'Git am' failure is as below. Please fix it on dpdk-next-net-intel sub tree.
> Thanks!
> 

Ok, I will updated later.


> Description: [dpdk-dev,v2] doc: add queue region feature info to release
> notes
> Applying: doc: add queue region feature info to release notes
> error: patch failed: doc/guides/rel_notes/release_18_02.rst:41
> error: doc/guides/rel_notes/release_18_02.rst: patch does not apply Patch
> failed at 0001 doc: add queue region feature info to release notes
> 
> Regards,
> Helin
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Wednesday, January 3, 2018 4:13 PM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John; Zhao1, Wei
> > Subject: [dpdk-dev] [PATCH v2] doc: add queue region feature info to
> > release notes
> I'd suggest to use 'update release notes with queue region feature'
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> This patch updates the releases notes with queue region feature which was
> enabled in 17.11 in silence.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > -change this information to v18.02 release notes.
> > ---
> >  doc/guides/rel_notes/release_18_02.rst | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > b/doc/guides/rel_notes/release_18_02.rst
> > index 24b67bb..0e9f17b 100644
> > --- a/doc/guides/rel_notes/release_18_02.rst
> > +++ b/doc/guides/rel_notes/release_18_02.rst
> > @@ -41,6 +41,23 @@ New Features
> >       Also, make sure to start the actual text at the margin.
> >
> =========================================================
> >
> > +* **Added the i40e ethernet driver to support queue region feature.**
> > +
> > +  This feature enable queue regions configuration for RSS in PF,  so
> > + that different traffic classes or different packet  classification
> > + types can be separated to different queues in  different queue
> > + regions. This feature has been implemented in v17.11.
> > +
> > +* **Added the testpmd app to support queue region configuration with
> > +CLI.**
> > +
> > +  This patch add a API configuration of queue region in rss with
> > + command
> > line.
> > +  It can parse the parameters of region index, queue number,  queue
> > + start index, user priority, traffic classes and so on.
> > +  According to commands from command line, it will call i40e  private
> > + API and start the process of set or flush queue region  configure.
> > + As this feature is specific for i40e, so private API  will be used.
> > + Aslo add a document for these new commands.
> > +  This feature has been implemented in v17.11.
> >
> >  API Changes
> >  -----------
> > --
> > 2.9.3

[dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change this information to v18.02 release notes.

v3:
-rework it on dpdk-next-net-intel sub tree.
---
 doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/doc/guides/rel_notes/release_18_02.rst b/doc/guides/rel_notes/release_18_02.rst
index 621b8f5..d7c8b68 100644
--- a/doc/guides/rel_notes/release_18_02.rst
+++ b/doc/guides/rel_notes/release_18_02.rst
@@ -47,6 +47,24 @@ New Features
   users. According to the device configuration, it will setup TX->RX loopback
   link or not.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated to different queues in
+  different queue regions. This feature has been implemented in v17.11.
+
+* **Added the testpmd app to support queue region configuration with CLI.**
+
+  This patch add a API configuration of queue region in rss with command line.
+  It can parse the parameters of region index, queue number,
+  queue start index, user priority, traffic classes and so on.
+  According to commands from command line, it will call i40e
+  private API and start the process of set or flush queue region
+  configure. As this feature is specific for i40e, so private API
+  will be used. Aslo add a document for these new commands.
+  This feature has been implemented in v17.11.
+
 API Changes
 -----------
 
-- 
2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhang, Helin]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
> 
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> 
> ---
> 
> v2:
> -change this information to v18.02 release notes.
> 
> v3:
> -rework it on dpdk-next-net-intel sub tree.
> ---
>  doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_18_02.rst
> b/doc/guides/rel_notes/release_18_02.rst
> index 621b8f5..d7c8b68 100644
> --- a/doc/guides/rel_notes/release_18_02.rst
> +++ b/doc/guides/rel_notes/release_18_02.rst
> @@ -47,6 +47,24 @@ New Features
>    users. According to the device configuration, it will setup TX->RX loopback
>    link or not.
> 
> +* **Added the i40e ethernet driver to support queue region feature.**
Please follow others about the format. I guess blank space might be needed.
Thanks,
Helin

> +
> +  This feature enable queue regions configuration for RSS in PF,  so
> + that different traffic classes or different packet  classification
> + types can be separated to different queues in  different queue
> + regions. This feature has been implemented in v17.11.
> +
> +* **Added the testpmd app to support queue region configuration with
> +CLI.**
> +
> +  This patch add a API configuration of queue region in rss with command line.
> +  It can parse the parameters of region index, queue number,  queue
> + start index, user priority, traffic classes and so on.
> +  According to commands from command line, it will call i40e  private
> + API and start the process of set or flush queue region  configure. As
> + this feature is specific for i40e, so private API  will be used. Aslo
> + add a document for these new commands.
> +  This feature has been implemented in v17.11.
> +
>  API Changes
>  -----------
> 
> --
> 2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhang, Helin]

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:15 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:40 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > Subject: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > -change this information to v18.02 release notes.
> >
> > v3:
> > -rework it on dpdk-next-net-intel sub tree.
> > ---
> >  doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > b/doc/guides/rel_notes/release_18_02.rst
> > index 621b8f5..d7c8b68 100644
> > --- a/doc/guides/rel_notes/release_18_02.rst
> > +++ b/doc/guides/rel_notes/release_18_02.rst
> > @@ -47,6 +47,24 @@ New Features
> >    users. According to the device configuration, it will setup TX->RX loopback
> >    link or not.
> >
> > +* **Added the i40e ethernet driver to support queue region feature.**
> Please follow others about the format. I guess blank space might be needed.
> Thanks,
> Helin
Sorry, it seems that different formats are all there. Please just ignore my comments here. Thanks!

/Helin
> 
> > +
> > +  This feature enable queue regions configuration for RSS in PF,  so
> > + that different traffic classes or different packet  classification
> > + types can be separated to different queues in  different queue
> > + regions. This feature has been implemented in v17.11.
> > +
> > +* **Added the testpmd app to support queue region configuration with
> > +CLI.**
> > +
> > +  This patch add a API configuration of queue region in rss with command
> line.
> > +  It can parse the parameters of region index, queue number,  queue
> > + start index, user priority, traffic classes and so on.
> > +  According to commands from command line, it will call i40e  private
> > + API and start the process of set or flush queue region  configure.
> > + As this feature is specific for i40e, so private API  will be used.
> > + Aslo add a document for these new commands.
> > +  This feature has been implemented in v17.11.
> > +
> >  API Changes
> >  -----------
> >
> > --
> > 2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
> 
> 
> 
> > -----Original Message-----
> > From: Zhang, Helin
> > Sent: Tuesday, January 9, 2018 2:15 PM
> > To: Zhao1, Wei; dev@dpdk.org
> > Cc: Mcnamara, John
> > Subject: RE: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> >
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Monday, January 8, 2018 11:40 AM
> > > To: dev@dpdk.org
> > > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > > Subject: [PATCH v3] doc: add queue region feature info to release
> > > notes
> > >
> > > This patch add inforation about i40e queue region realted to release
> > > notes, it has been missed before in v17.11 release notes. This
> > > feature has been implemented in v17.11.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > >
> > > ---
> > >
> > > v2:
> > > -change this information to v18.02 release notes.
> > >
> > > v3:
> > > -rework it on dpdk-next-net-intel sub tree.
> > > ---
> > >  doc/guides/rel_notes/release_18_02.rst | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/release_18_02.rst
> > > b/doc/guides/rel_notes/release_18_02.rst
> > > index 621b8f5..d7c8b68 100644
> > > --- a/doc/guides/rel_notes/release_18_02.rst
> > > +++ b/doc/guides/rel_notes/release_18_02.rst
> > > @@ -47,6 +47,24 @@ New Features
> > >    users. According to the device configuration, it will setup TX->RX
> loopback
> > >    link or not.
> > >
> > > +* **Added the i40e ethernet driver to support queue region
> > > +feature.**
> > Please follow others about the format. I guess blank space might be
> needed.
> > Thanks,
> > Helin
> Sorry, it seems that different formats are all there. Please just ignore my
> comments here. Thanks!

Ok.

> 
> /Helin
> >
> > > +
> > > +  This feature enable queue regions configuration for RSS in PF,
> > > + so that different traffic classes or different packet
> > > + classification types can be separated to different queues in
> > > + different queue regions. This feature has been implemented in v17.11.
> > > +
> > > +* **Added the testpmd app to support queue region configuration
> > > +with
> > > +CLI.**
> > > +
> > > +  This patch add a API configuration of queue region in rss with
> > > + command
> > line.
> > > +  It can parse the parameters of region index, queue number,  queue
> > > + start index, user priority, traffic classes and so on.
> > > +  According to commands from command line, it will call i40e
> > > + private API and start the process of set or flush queue region  configure.
> > > + As this feature is specific for i40e, so private API  will be used.
> > > + Aslo add a document for these new commands.
> > > +  This feature has been implemented in v17.11.
> > > +
> > >  API Changes
> > >  -----------
> > >
> > > --
> > > 2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhang, Helin]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 8, 2018 11:40 AM
> To: dev@dpdk.org
> Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> Subject: [PATCH v3] doc: add queue region feature info to release notes
> 
> This patch add inforation about i40e queue region realted to release notes, it
> has been missed before in v17.11 release notes. This feature has been
> implemented in v17.11.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhang, Helin]

> -----Original Message-----
> From: Zhang, Helin
> Sent: Tuesday, January 9, 2018 2:26 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: Mcnamara, John
> Subject: RE: [PATCH v3] doc: add queue region feature info to release notes
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 8, 2018 11:40 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Helin; Mcnamara, John; Zhao1, Wei
> > Subject: [PATCH v3] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Applied to dpdk-next-net-intel, with minor changes. Thanks!

/Helin

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Thomas Monjalon]

21/12/2017 19:10, Ferruh Yigit:
> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> > This patch add inforation about i40e queue region
> > realted to release notes, it has been missed before.
> > 
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> 
> I think we shouldn't update release notes once it has been released.
> 
> Perhaps it can be an option to mention from this in latest release notes with a
> note that says actual support added in v17.11?

I disagree.
It is really confusing to add 17.11 feature in 18.02 release notes.
It is better to add it in 17.11 release notes and backport it.

Please Ferruh, could you remove the patch v2 updating release_18_02.rst
from next-net?

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Ferruh Yigit]

On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
> 21/12/2017 19:10, Ferruh Yigit:
>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>> This patch add inforation about i40e queue region
>>> realted to release notes, it has been missed before.
>>>
>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>> ---
>>>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>
>> I think we shouldn't update release notes once it has been released.
>>
>> Perhaps it can be an option to mention from this in latest release notes with a
>> note that says actual support added in v17.11?
> 
> I disagree.
> It is really confusing to add 17.11 feature in 18.02 release notes.
> It is better to add it in 17.11 release notes and backport it.
> 
> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
> from next-net?

Updating a release notes after release looks wrong to me. But I will update the
repo to move this into 17.11 release notes, no patch required.

And there is one more similar update, I guess that should be updated too, I will
check it as well.

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Ferruh Yigit]

On 1/16/2018 11:49 AM, Ferruh Yigit wrote:
> On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
>> 21/12/2017 19:10, Ferruh Yigit:
>>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
>>>> This patch add inforation about i40e queue region
>>>> realted to release notes, it has been missed before.
>>>>
>>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>>>> ---
>>>>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
>>>
>>> I think we shouldn't update release notes once it has been released.
>>>
>>> Perhaps it can be an option to mention from this in latest release notes with a
>>> note that says actual support added in v17.11?
>>
>> I disagree.
>> It is really confusing to add 17.11 feature in 18.02 release notes.
>> It is better to add it in 17.11 release notes and backport it.
>>
>> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
>> from next-net?
> 
> Updating a release notes after release looks wrong to me. But I will update the
> repo to move this into 17.11 release notes, no patch required.
> 
> And there is one more similar update, I guess that should be updated too, I will
> check it as well.

Other one is following:
https://dpdk.org/dev/patchwork/patch/33283/

Updated those two commits to edit v17.11 release notes instead of v18.02.

Re: [dpdk-dev] [PATCH] doc: add queue region feature info to release notes

[Thomas Monjalon]

16/01/2018 17:01, Ferruh Yigit:
> On 1/16/2018 11:49 AM, Ferruh Yigit wrote:
> > On 1/16/2018 11:27 AM, Thomas Monjalon wrote:
> >> 21/12/2017 19:10, Ferruh Yigit:
> >>> On 12/20/2017 7:52 PM, Wei Zhao wrote:
> >>>> This patch add inforation about i40e queue region
> >>>> realted to release notes, it has been missed before.
> >>>>
> >>>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >>>> ---
> >>>>  doc/guides/rel_notes/release_17_11.rst | 17 +++++++++++++++++
> >>>
> >>> I think we shouldn't update release notes once it has been released.
> >>>
> >>> Perhaps it can be an option to mention from this in latest release notes with a
> >>> note that says actual support added in v17.11?
> >>
> >> I disagree.
> >> It is really confusing to add 17.11 feature in 18.02 release notes.
> >> It is better to add it in 17.11 release notes and backport it.
> >>
> >> Please Ferruh, could you remove the patch v2 updating release_18_02.rst
> >> from next-net?
> > 
> > Updating a release notes after release looks wrong to me. But I will update the
> > repo to move this into 17.11 release notes, no patch required.
> > 
> > And there is one more similar update, I guess that should be updated too, I will
> > check it as well.
> 
> Other one is following:
> https://dpdk.org/dev/patchwork/patch/33283/
> 
> Updated those two commits to edit v17.11 release notes instead of v18.02.

Thanks

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Thomas Monjalon]

> > > This patch add inforation about i40e queue region realted to release
> > > notes, it has been missed before in v17.11 release notes. This feature
> > > has been implemented in v17.11.
> > >
> > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Acked-by: Helin Zhang <helin.zhang@intel.com>
> Applied to dpdk-next-net-intel, with minor changes. Thanks!

This patch has not been reviewed by John, doc maintainer.
There are some english errors.
It documents extensively a testpmd addition, which is usually not
documented in release notes.
And it is adding 17.11 features in 18.02 release notes.

It is too much, so it is just removed when pulling next-net.

If you want to explain what is possible with i40e, you should
document it in i40e.rst.
The release notes is just a short list of what is added.

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

Hi,  Thomas
   I will update it in 17.11 release nots later as your comment. 
And it has been CC to John,  but not get any feedback.

Thanks.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, January 17, 2018 5:53 AM
> To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> Ferruh <ferruh.yigit@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
> 
> > > > This patch add inforation about i40e queue region realted to
> > > > release notes, it has been missed before in v17.11 release notes.
> > > > This feature has been implemented in v17.11.
> > > >
> > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> 
> This patch has not been reviewed by John, doc maintainer.
> There are some english errors.
> It documents extensively a testpmd addition, which is usually not
> documented in release notes.
> And it is adding 17.11 features in 18.02 release notes.
> 
> It is too much, so it is just removed when pulling next-net.
> 
> If you want to explain what is possible with i40e, you should document it in
> i40e.rst.
> The release notes is just a short list of what is added.

[dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change this information to v18.02 release notes.

v3:
-rework it on dpdk-next-net-intel sub tree.

v4:
-rework it into 17.11 release notes and i40e.rst
---
 doc/guides/nics/i40e.rst               | 24 +++++++++++++++++++++++-
 doc/guides/rel_notes/release_17_11.rst |  6 ++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..345abf3 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
 - IEEE1588/802.1AS timestamping
 - VF Daemon (VFD) - EXPERIMENTAL
 - Dynamic Device Personalization (DDP)
-
+- Queue region configuration
 
 Prerequisites
 -------------
@@ -430,6 +430,28 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
    testpmd> port config 0 pctype 43 hash_inset set field 14
    testpmd> port config 0 pctype 43 hash_inset set field 15
 
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 support a feature of queue regions
+configuration for RSS in PF, so that different traffic classes or different
+packet classification types can be separated to different queues in different
+queue regions. There is an API for configuration of queue region in rss with
+command line. It can parse the parameters of region index, queue number, queue
+start index, user priority, traffic classes and so on. According to commands
+from command line, it will call i40e private API and start the process of set
+or flush queue region configuration. As this feature is specific for i40e, so
+private API is used. These new commands are as below, for details please reference to
+document testpmd_funcs.rst.
+
+.. code-block:: console
+
+   testpmd> set port (port_id) queue-region region_id (value) \
+		queue_start_index (value) queue_num (value)
+   testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+   testpmd> set port (port_id) queue-region UP (value) region_id (value)
+   testpmd> set port (port_id) queue-region flush (on|off)
+   testpmd> show port (port_id) queue-region
+
 Limitations or Known issues
 ---------------------------
 
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 016a08c..15321d6 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -273,6 +273,12 @@ New Features
   applications to classify an input packet by matching it against a set of
   flow rules. It uses the ``librte_table`` API to manage the flow rules.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated into different queues in
+  different queue regions.
 
 Resolved Issues
 ---------------
-- 
2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Thomas Monjalon]

You can probably work with Beilei who is trying to do the same thing
for other i40e features:
	https://dpdk.org/dev/patchwork/patch/33953/


18/01/2018 03:00, Zhao1, Wei:
> Hi,  Thomas
>    I will update it in 17.11 release nots later as your comment. 
> And it has been CC to John,  but not get any feedback.
> 
> Thanks.
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, January 17, 2018 5:53 AM
> > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > Ferruh <ferruh.yigit@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> > release notes
> > 
> > > > > This patch add inforation about i40e queue region realted to
> > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > This feature has been implemented in v17.11.
> > > > >
> > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> > 
> > This patch has not been reviewed by John, doc maintainer.
> > There are some english errors.
> > It documents extensively a testpmd addition, which is usually not
> > documented in release notes.
> > And it is adding 17.11 features in 18.02 release notes.
> > 
> > It is too much, so it is just removed when pulling next-net.
> > 
> > If you want to explain what is possible with i40e, you should document it in
> > i40e.rst.
> > The release notes is just a short list of what is added.

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

Hi,  Thomas
    Thank you! After discussion with Beilei, I have commit a new patch v4.
 https://dpdk.org/dev/patchwork/patch/33956/
Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
Do you think this is ok?


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, January 18, 2018 3:30 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
> 
> You can probably work with Beilei who is trying to do the same thing for
> other i40e features:
> 	https://dpdk.org/dev/patchwork/patch/33953/
> 
> 
> 18/01/2018 03:00, Zhao1, Wei:
> > Hi,  Thomas
> >    I will update it in 17.11 release nots later as your comment.
> > And it has been CC to John,  but not get any feedback.
> >
> > Thanks.
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > Sent: Wednesday, January 17, 2018 5:53 AM
> > > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > > <wei.zhao1@intel.com>
> > > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > > Ferruh <ferruh.yigit@intel.com>
> > > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature
> > > info to release notes
> > >
> > > > > > This patch add inforation about i40e queue region realted to
> > > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > > This feature has been implemented in v17.11.
> > > > > >
> > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> > >
> > > This patch has not been reviewed by John, doc maintainer.
> > > There are some english errors.
> > > It documents extensively a testpmd addition, which is usually not
> > > documented in release notes.
> > > And it is adding 17.11 features in 18.02 release notes.
> > >
> > > It is too much, so it is just removed when pulling next-net.
> > >
> > > If you want to explain what is possible with i40e, you should
> > > document it in i40e.rst.
> > > The release notes is just a short list of what is added.
> 
> 

[dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change this information to v18.02 release notes.

v3:
-rework it on dpdk-next-net-intel sub tree.

v4:
-rework it into 17.11 release notes and i40e.rst
---
 doc/guides/nics/i40e.rst               | 24 +++++++++++++++++++++++-
 doc/guides/rel_notes/release_17_11.rst |  6 ++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..345abf3 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
 - IEEE1588/802.1AS timestamping
 - VF Daemon (VFD) - EXPERIMENTAL
 - Dynamic Device Personalization (DDP)
-
+- Queue region configuration
 
 Prerequisites
 -------------
@@ -430,6 +430,28 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
    testpmd> port config 0 pctype 43 hash_inset set field 14
    testpmd> port config 0 pctype 43 hash_inset set field 15
 
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 support a feature of queue regions
+configuration for RSS in PF, so that different traffic classes or different
+packet classification types can be separated to different queues in different
+queue regions. There is an API for configuration of queue region in rss with
+command line. It can parse the parameters of region index, queue number, queue
+start index, user priority, traffic classes and so on. According to commands
+from command line, it will call i40e private API and start the process of set
+or flush queue region configuration. As this feature is specific for i40e, so
+private API is used. These new commands are as below, for details please reference to
+document testpmd_funcs.rst.
+
+.. code-block:: console
+
+   testpmd> set port (port_id) queue-region region_id (value) \
+		queue_start_index (value) queue_num (value)
+   testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+   testpmd> set port (port_id) queue-region UP (value) region_id (value)
+   testpmd> set port (port_id) queue-region flush (on|off)
+   testpmd> show port (port_id) queue-region
+
 Limitations or Known issues
 ---------------------------
 
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index 016a08c..15321d6 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -273,6 +273,12 @@ New Features
   applications to classify an input packet by matching it against a set of
   flow rules. It uses the ``librte_table`` API to manage the flow rules.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated into different queues in
+  different queue regions.
 
 Resolved Issues
 ---------------
-- 
2.9.3

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

Commit second time to cc  stable@dpdk.org
https://dpdk.org/dev/patchwork/patch/34065/

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, January 19, 2018 11:15 AM
> To: 'Thomas Monjalon' <thomas@monjalon.net>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
> 
> Hi,  Thomas
>     Thank you! After discussion with Beilei, I have commit a new patch v4.
>  https://dpdk.org/dev/patchwork/patch/33956/
> Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> Do you think this is ok?
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Thursday, January 18, 2018 3:30 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>
> > Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara,
> John
> > <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> > Xing, Beilei <beilei.xing@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info
> > to release notes
> >
> > You can probably work with Beilei who is trying to do the same thing
> > for other i40e features:
> > 	https://dpdk.org/dev/patchwork/patch/33953/
> >
> >
> > 18/01/2018 03:00, Zhao1, Wei:
> > > Hi,  Thomas
> > >    I will update it in 17.11 release nots later as your comment.
> > > And it has been CC to John,  but not get any feedback.
> > >
> > > Thanks.
> > >
> > > > -----Original Message-----
> > > > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > Sent: Wednesday, January 17, 2018 5:53 AM
> > > > To: Zhang, Helin <helin.zhang@intel.com>; Zhao1, Wei
> > > > <wei.zhao1@intel.com>
> > > > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Yigit,
> > > > Ferruh <ferruh.yigit@intel.com>
> > > > Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature
> > > > info to release notes
> > > >
> > > > > > > This patch add inforation about i40e queue region realted to
> > > > > > > release notes, it has been missed before in v17.11 release notes.
> > > > > > > This feature has been implemented in v17.11.
> > > > > > >
> > > > > > > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > > > > > Acked-by: Helin Zhang <helin.zhang@intel.com>
> > > > > Applied to dpdk-next-net-intel, with minor changes. Thanks!
> > > >
> > > > This patch has not been reviewed by John, doc maintainer.
> > > > There are some english errors.
> > > > It documents extensively a testpmd addition, which is usually not
> > > > documented in release notes.
> > > > And it is adding 17.11 features in 18.02 release notes.
> > > >
> > > > It is too much, so it is just removed when pulling next-net.
> > > >
> > > > If you want to explain what is possible with i40e, you should
> > > > document it in i40e.rst.
> > > > The release notes is just a short list of what is added.
> >
> >

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Thomas Monjalon]

19/01/2018 04:15, Zhao1, Wei:
> Hi,  Thomas
>     Thank you! After discussion with Beilei, I have commit a new patch v4.
>  https://dpdk.org/dev/patchwork/patch/33956/
> Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
> Do you think this is ok?

Yes it is fine to wait for John's approval.

Note: in release notes, you should group all i40e features in the same place.
In v4, you just added it at the end.
I think v5 is needed.

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Thomas Monjalon]

19/01/2018 10:13, Thomas Monjalon:
> 19/01/2018 04:15, Zhao1, Wei:
> > Hi,  Thomas
> >     Thank you! After discussion with Beilei, I have commit a new patch v4.
> >  https://dpdk.org/dev/patchwork/patch/33956/
> > Beilei also commit another new patch, we are waiting for review by Mcnamara, John.
> > Do you think this is ok?
> 
> Yes it is fine to wait for John's approval.
> 
> Note: in release notes, you should group all i40e features in the same place.
> In v4, you just added it at the end.
> I think v5 is needed.

More precisions:
There is no i40e block in 17.11 release notes.
So you should insert one close to other net devices,
for instance, after the bnxt one.

Re: [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes

[Mcnamara, John]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, January 19, 2018 3:28 AM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v4] doc: add queue region feature info to release notes
> 
> This patch add inforation about i40e queue region realted to release
> notes, it has been missed before in v17.11 release notes. This feature has
> been implemented in v17.11.
> 

Here is a suggested reworking with minor changes and a link to the testpmd docs:

Queue region configuration
~~~~~~~~~~~~~~~~~~~~~~~~~~

The Ethernet Controller X710/XL710 supports a feature of queue regions
configuration for RSS in the PF, so that different traffic classes or
different packet classification types can be separated to different queues in
different queue regions. There is an API for configuration of queue regions in
RSS with a command line. It can parse the parameters of the region index,
queue number, queue start index, user priority, traffic classes and so
on. Depending on commands from the command line, it will call i40e private
APIs and start the process of setting or flushing the queue region
configuration. As this feature is specific for i40e only private APIs are
used. These new ``test_pmd`` commands are as shown below. For details please
refer to :doc:`../testpmd_app_ug/index`.

.. code-block:: console

   testpmd> set port (port_id) queue-region region_id (value) \
		queue_start_index (value) queue_num (value)
   testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
   testpmd> set port (port_id) queue-region UP (value) region_id (value)
   testpmd> set port (port_id) queue-region flush (on|off)
   testpmd> show port (port_id) queue-region

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

Ok, good idea, v5 will come later.

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
> 
> 19/01/2018 10:13, Thomas Monjalon:
> > 19/01/2018 04:15, Zhao1, Wei:
> > > Hi,  Thomas
> > >     Thank you! After discussion with Beilei, I have commit a new patch v4.
> > >  https://dpdk.org/dev/patchwork/patch/33956/
> > > Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> > > Do you think this is ok?
> >
> > Yes it is fine to wait for John's approval.
> >
> > Note: in release notes, you should group all i40e features in the same place.
> > In v4, you just added it at the end.
> > I think v5 is needed.
> 
> More precisions:
> There is no i40e block in 17.11 release notes.
> So you should insert one close to other net devices, for instance, after the
> bnxt one.

[dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes

[Wei Zhao]

This patch add inforation about i40e queue region
realted to release notes, it has been missed before
in v17.11 release notes. This feature has been
implemented in v17.11.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

---

v2:
-change this information to v18.02 release notes.

v3:
-rework it on dpdk-next-net-intel sub tree.

v4:
-rework it into 17.11 release notes and i40e.rst.

v5:
-change some use of words and comment location in file.
---
 doc/guides/nics/i40e.rst               | 25 ++++++++++++++++++++++++-
 doc/guides/rel_notes/release_17_11.rst |  7 +++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 50d5e36..29601f1 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -66,7 +66,7 @@ Features of the I40E PMD are:
 - IEEE1588/802.1AS timestamping
 - VF Daemon (VFD) - EXPERIMENTAL
 - Dynamic Device Personalization (DDP)
-
+- Queue region configuration
 
 Prerequisites
 -------------
@@ -430,6 +430,29 @@ For example, to use only 48bit prefix for IPv6 src address for IPv6 TCP RSS:
    testpmd> port config 0 pctype 43 hash_inset set field 14
    testpmd> port config 0 pctype 43 hash_inset set field 15
 
+Queue region configuration
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The Ethernet Controller X710/XL710 supports a feature of queue regions
+configuration for RSS in the PF, so that different traffic classes or
+different packet classification types can be separated to different
+queues in different queue regions. There is an API for configuration
+of queue regions in RSS with a command line. It can parse the parameters
+of the region index, queue number, queue start index, user priority, traffic
+classes and so on. Depending on commands from the command line, it will call
+i40e private APIs and start the process of setting or flushing the queue
+region configuration. As this feature is specific for i40e only private
+APIs are used. These new ``test_pmd`` commands are as shown below. For
+details please refer to :doc:`../testpmd_app_ug/index`.
+
+.. code-block:: console
+
+   testpmd> set port (port_id) queue-region region_id (value) \
+		queue_start_index (value) queue_num (value)
+   testpmd> set port (port_id) queue-region region_id (value) flowtype (value)
+   testpmd> set port (port_id) queue-region UP (value) region_id (value)
+   testpmd> set port (port_id) queue-region flush (on|off)
+   testpmd> show port (port_id) queue-region
+
 Limitations or Known issues
 ---------------------------
 
diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst
index c37c71a..088778b 100644
--- a/doc/guides/rel_notes/release_17_11.rst
+++ b/doc/guides/rel_notes/release_17_11.rst
@@ -216,6 +216,13 @@ New Features
   profiles which can be programmed by dynamic device personalization (DDP)
   process.
 
+* **Added the i40e ethernet driver to support queue region feature.**
+
+  This feature enable queue regions configuration for RSS in PF,
+  so that different traffic classes or different packet
+  classification types can be separated into different queues in
+  different queue regions.
+
 * **Updated ipsec-secgw application to support rte_security.**
 
   Updated the ``ipsec-secgw`` sample application to support ``rte_security``
-- 
2.9.3

Re: [dpdk-dev] [PATCH v4] doc: add queue region feature info to release notes

[Zhao1, Wei]

Thank you for your help!
I have commit a v5 patch https://dpdk.org/dev/patchwork/patch/34211/


> -----Original Message-----
> From: Mcnamara, John
> Sent: Monday, January 22, 2018 5:22 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v4] doc: add queue region feature info to release notes
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, January 19, 2018 3:28 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; stable@dpdk.org;
> Zhao1,
> > Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v4] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> 
> Here is a suggested reworking with minor changes and a link to the testpmd
> docs:
> 
> Queue region configuration
> ~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The Ethernet Controller X710/XL710 supports a feature of queue regions
> configuration for RSS in the PF, so that different traffic classes or different
> packet classification types can be separated to different queues in different
> queue regions. There is an API for configuration of queue regions in RSS with
> a command line. It can parse the parameters of the region index, queue
> number, queue start index, user priority, traffic classes and so on. Depending
> on commands from the command line, it will call i40e private APIs and start
> the process of setting or flushing the queue region configuration. As this
> feature is specific for i40e only private APIs are used. These new ``test_pmd``
> commands are as shown below. For details please refer
> to :doc:`../testpmd_app_ug/index`.
> 
> .. code-block:: console
> 
>    testpmd> set port (port_id) queue-region region_id (value) \
> 		queue_start_index (value) queue_num (value)
>    testpmd> set port (port_id) queue-region region_id (value) flowtype
> (value)
>    testpmd> set port (port_id) queue-region UP (value) region_id (value)
>    testpmd> set port (port_id) queue-region flush (on|off)
>    testpmd> show port (port_id) queue-region
> 
> 
> 

Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to release notes

[Zhao1, Wei]

HI,  Thomas

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, January 19, 2018 5:17 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: Zhang, Helin <helin.zhang@intel.com>; dev@dpdk.org; Mcnamara, John
> <john.mcnamara@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add queue region feature info to
> release notes
> 
> 19/01/2018 10:13, Thomas Monjalon:
> > 19/01/2018 04:15, Zhao1, Wei:
> > > Hi,  Thomas
> > >     Thank you! After discussion with Beilei, I have commit a new patch v4.
> > >  https://dpdk.org/dev/patchwork/patch/33956/
> > > Beilei also commit another new patch, we are waiting for review by
> Mcnamara, John.
> > > Do you think this is ok?
> >
> > Yes it is fine to wait for John's approval.
> >
> > Note: in release notes, you should group all i40e features in the same place.
> > In v4, you just added it at the end.
> > I think v5 is needed.
> 
> More precisions:
> There is no i40e block in 17.11 release notes.
> So you should insert one close to other net devices, for instance, after the
> bnxt one.

Thank you for your help!
I have commit a v5 patch  https://dpdk.org/dev/patchwork/patch/34211/ 
It is based on beilei xing patch https://dpdk.org/dev/patchwork/patch/33953/
I have add i40e comment after hers.

Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes

[Mcnamara, John]

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 22, 2018 5:19 AM
> To: dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>; thomas@monjalon.net;
> stable@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v5] doc: add queue region feature info to release notes
> 
> This patch add inforation about i40e queue region realted to release
> notes, it has been missed before in v17.11 release notes. This feature has
> been implemented in v17.11.
> 
> ...
> +Queue region configuration
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~

The underline for a section header should match the length of the text
and should be followed by a blank line, line in my suggested changes.

See also: http://dpdk.org/doc/guides/contributing/documentation.html#section-headers

However, this isn't an error so:

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to release notes

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, January 23, 2018 6:22 PM
> To: Zhao1, Wei; dev@dpdk.org
> Cc: thomas@monjalon.net; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5] doc: add queue region feature info to
> release notes
> 
> 
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, January 22, 2018 5:19 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John <john.mcnamara@intel.com>; thomas@monjalon.net;
> > stable@dpdk.org; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [PATCH v5] doc: add queue region feature info to release
> > notes
> >
> > This patch add inforation about i40e queue region realted to release
> > notes, it has been missed before in v17.11 release notes. This feature
> > has been implemented in v17.11.
> >
> > ...
> > +Queue region configuration
> > +~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> The underline for a section header should match the length of the text and
> should be followed by a blank line, line in my suggested changes.
> 
> See also:
> http://dpdk.org/doc/guides/contributing/documentation.html#section-
> headers
> 
> However, this isn't an error so:
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied to dpdk-next-net-intel, with commit log changes. Thanks!

/Helin
> 
>