* [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check
@ 2018-04-04 3:18 Wei Zhao
2018-04-04 3:59 ` Zhang, Qi Z
2018-04-04 5:00 ` [dpdk-dev] [PATCH v2] " Wei Zhao
0 siblings, 2 replies; 9+ messages in thread
From: Wei Zhao @ 2018-04-04 3:18 UTC (permalink / raw)
To: dev, stable; +Cc: qi.z.zhang, Wei Zhao
There need a queue index check for RSS queue region
in order to aviod error from configuration.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index f3e8c5f..4e86ecb 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
return -rte_errno;
}
+ for (i = 0; i < rss->num; i++) {
+ for (j = 0; j < rss_info->num; j++) {
+ if (rss->queue[i] == rss_info->queue[j])
+ break;
+ }
+ if (j == rss_info->num) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "no valid queues");
+ return -rte_errno;
+ }
+ }
+
for (i = 0; i < info->queue_region_number; i++) {
if (info->region[i].queue_num == rss->num &&
info->region[i].queue_start_index ==
--
2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check
2018-04-04 3:18 [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check Wei Zhao
@ 2018-04-04 3:59 ` Zhang, Qi Z
2018-04-04 4:02 ` Zhao1, Wei
2018-04-04 5:12 ` Zhao1, Wei
2018-04-04 5:00 ` [dpdk-dev] [PATCH v2] " Wei Zhao
1 sibling, 2 replies; 9+ messages in thread
From: Zhang, Qi Z @ 2018-04-04 3:59 UTC (permalink / raw)
To: Zhao1, Wei, dev, stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, April 4, 2018 11:19 AM
> To: dev@dpdk.org; stable@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/i40e: add flow RSS queue index check
>
> There need a queue index check for RSS queue region in order to aviod error
> from configuration.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Please add Cc: stable@dpdk.org here.
> ---
> drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> f3e8c5f..4e86ecb 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> return -rte_errno;
> }
>
> + for (i = 0; i < rss->num; i++) {
> + for (j = 0; j < rss_info->num; j++) {
> + if (rss->queue[i] == rss_info->queue[j])
> + break;
> + }
> + if (j == rss_info->num) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> + }
Is it necessary to add this check inside the big loop ?
Btw, the function of i40e_flow_parse_rss_action looks too big and without enough comment
It's better to use sub-function or add some comment before each code block
to make it more readable.
Regards
Qi
> +
> for (i = 0; i < info->queue_region_number; i++) {
> if (info->region[i].queue_num == rss->num &&
> info->region[i].queue_start_index ==
> --
> 2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check
2018-04-04 3:59 ` Zhang, Qi Z
@ 2018-04-04 4:02 ` Zhao1, Wei
2018-04-04 5:12 ` Zhao1, Wei
1 sibling, 0 replies; 9+ messages in thread
From: Zhao1, Wei @ 2018-04-04 4:02 UTC (permalink / raw)
To: Zhang, Qi Z, dev, stable
Ok，I will add more comment in other independent patch
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, April 4, 2018 11:59 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/i40e: add flow RSS queue index check
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, April 4, 2018 11:19 AM
> > To: dev@dpdk.org; stable@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: add flow RSS queue index check
> >
> > There need a queue index check for RSS queue region in order to aviod
> > error from configuration.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Please add Cc: stable@dpdk.org here.
>
> > ---
> > drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index f3e8c5f..4e86ecb 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> > *dev,
> > return -rte_errno;
> > }
> >
> > + for (i = 0; i < rss->num; i++) {
> > + for (j = 0; j < rss_info->num; j++) {
> > + if (rss->queue[i] == rss_info-
> >queue[j])
> > + break;
> > + }
> > + if (j == rss_info->num) {
> > + rte_flow_error_set(error, EINVAL,
> > +
> RTE_FLOW_ERROR_TYPE_ACTION,
> > + act,
> > + "no valid queues");
> > + return -rte_errno;
> > + }
> > + }
>
> Is it necessary to add this check inside the big loop ?
>
> Btw, the function of i40e_flow_parse_rss_action looks too big and without
> enough comment
>
> It's better to use sub-function or add some comment before each code block
> to make it more readable.
>
> Regards
> Qi
>
>
> > +
> > for (i = 0; i < info->queue_region_number; i++) {
> > if (info->region[i].queue_num == rss->num
> &&
> > info->region[i].queue_start_index ==
> > --
> > 2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check
2018-04-04 3:59 ` Zhang, Qi Z
2018-04-04 4:02 ` Zhao1, Wei
@ 2018-04-04 5:12 ` Zhao1, Wei
1 sibling, 0 replies; 9+ messages in thread
From: Zhao1, Wei @ 2018-04-04 5:12 UTC (permalink / raw)
To: Zhang, Qi Z, dev, stable
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, April 4, 2018 11:59 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org; stable@dpdk.org
> Subject: RE: [PATCH] net/i40e: add flow RSS queue index check
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, April 4, 2018 11:19 AM
> > To: dev@dpdk.org; stable@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/i40e: add flow RSS queue index check
> >
> > There need a queue index check for RSS queue region in order to aviod
> > error from configuration.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Please add Cc: stable@dpdk.org here.
>
> > ---
> > drivers/net/i40e/i40e_flow.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index f3e8c5f..4e86ecb 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -4249,6 +4249,20 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> > *dev,
> > return -rte_errno;
> > }
> >
> > + for (i = 0; i < rss->num; i++) {
> > + for (j = 0; j < rss_info->num; j++) {
> > + if (rss->queue[i] == rss_info-
> >queue[j])
> > + break;
> > + }
> > + if (j == rss_info->num) {
> > + rte_flow_error_set(error, EINVAL,
> > +
> RTE_FLOW_ERROR_TYPE_ACTION,
> > + act,
> > + "no valid queues");
> > + return -rte_errno;
> > + }
> > + }
>
> Is it necessary to add this check inside the big loop ?
Ok, I will commit v2 later.
>
> Btw, the function of i40e_flow_parse_rss_action looks too big and without
> enough comment
>
> It's better to use sub-function or add some comment before each code block
> to make it more readable.
>
> Regards
> Qi
>
>
> > +
> > for (i = 0; i < info->queue_region_number; i++) {
> > if (info->region[i].queue_num == rss->num
> &&
> > info->region[i].queue_start_index ==
> > --
> > 2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread
* [dpdk-dev] [PATCH v2] net/i40e: add flow RSS queue index check
2018-04-04 3:18 [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check Wei Zhao
2018-04-04 3:59 ` Zhang, Qi Z
@ 2018-04-04 5:00 ` Wei Zhao
2018-04-04 5:06 ` [dpdk-dev] [PATCH v3] " Wei Zhao
1 sibling, 1 reply; 9+ messages in thread
From: Wei Zhao @ 2018-04-04 5:00 UTC (permalink / raw)
To: dev, stable; +Cc: qi.z.zhang, Wei Zhao
There need a queue index check for RSS queue region
in order to aviod error from configuration.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
Changes in v2:
move check code out from the big loop.
---
---
drivers/net/i40e/i40e_flow.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index f3e8c5f..3b54be0 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4216,6 +4216,22 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
}
}
+ if (conf_info->queue_region_number) {
+ for (i = 0; i < rss->num; i++) {
+ for (j = 0; j < rss_info->num; j++) {
+ if (rss->queue[i] == rss_info->queue[j])
+ break;
+ }
+ if (j == rss_info->num) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "no valid queues");
+ return -rte_errno;
+ }
+ }
+ }
+
for (n = 0; n < conf_info->queue_region_number; n++) {
if (conf_info->region[n].user_priority_num ||
conf_info->region[n].flowtype_num) {
--
2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v3] net/i40e: add flow RSS queue index check
2018-04-04 5:00 ` [dpdk-dev] [PATCH v2] " Wei Zhao
@ 2018-04-04 5:06 ` Wei Zhao
2018-04-04 8:06 ` [dpdk-dev] [PATCH v4] " Wei Zhao
0 siblings, 1 reply; 9+ messages in thread
From: Wei Zhao @ 2018-04-04 5:06 UTC (permalink / raw)
To: dev, stable; +Cc: qi.z.zhang, Wei Zhao
There need a queue index check for RSS queue region
in order to aviod error from configuration.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
Changes in v2:
move check code out from the big loop.
change in v3:
delete unnecessary dash in comment.
---
drivers/net/i40e/i40e_flow.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index f3e8c5f..3b54be0 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4216,6 +4216,22 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
}
}
+ if (conf_info->queue_region_number) {
+ for (i = 0; i < rss->num; i++) {
+ for (j = 0; j < rss_info->num; j++) {
+ if (rss->queue[i] == rss_info->queue[j])
+ break;
+ }
+ if (j == rss_info->num) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "no valid queues");
+ return -rte_errno;
+ }
+ }
+ }
+
for (n = 0; n < conf_info->queue_region_number; n++) {
if (conf_info->region[n].user_priority_num ||
conf_info->region[n].flowtype_num) {
--
2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* [dpdk-dev] [PATCH v4] net/i40e: add flow RSS queue index check
2018-04-04 5:06 ` [dpdk-dev] [PATCH v3] " Wei Zhao
@ 2018-04-04 8:06 ` Wei Zhao
2018-04-04 13:25 ` Zhang, Qi Z
0 siblings, 1 reply; 9+ messages in thread
From: Wei Zhao @ 2018-04-04 8:06 UTC (permalink / raw)
To: dev, stable; +Cc: qi.z.zhang, Wei Zhao
There need a queue index check for RSS queue region
in order to aviod error from configuration.
Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
Changes in v2:
move check code out from the big loop.
change in v3:
delete unnecessary dash in comment.
change in v4:
add more parameters check code.
---
drivers/net/i40e/i40e_flow.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
index f3e8c5f..f4d08bb 100644
--- a/drivers/net/i40e/i40e_flow.c
+++ b/drivers/net/i40e/i40e_flow.c
@@ -4216,6 +4216,32 @@ i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
}
}
+ if (conf_info->queue_region_number) {
+ for (i = 0; i < rss->num; i++) {
+ for (j = 0; j < rss_info->num; j++) {
+ if (rss->queue[i] == rss_info->queue[j])
+ break;
+ }
+ if (j == rss_info->num) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "no valid queues");
+ return -rte_errno;
+ }
+ }
+
+ for (i = 0; i < rss->num - 1; i++) {
+ if (rss->queue[i + 1] != rss->queue[i] + 1) {
+ rte_flow_error_set(error, EINVAL,
+ RTE_FLOW_ERROR_TYPE_ACTION,
+ act,
+ "no valid queues");
+ return -rte_errno;
+ }
+ }
+ }
+
for (n = 0; n < conf_info->queue_region_number; n++) {
if (conf_info->region[n].user_priority_num ||
conf_info->region[n].flowtype_num) {
--
2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v4] net/i40e: add flow RSS queue index check
2018-04-04 8:06 ` [dpdk-dev] [PATCH v4] " Wei Zhao
@ 2018-04-04 13:25 ` Zhang, Qi Z
2018-04-06 8:30 ` Zhang, Helin
0 siblings, 1 reply; 9+ messages in thread
From: Zhang, Qi Z @ 2018-04-04 13:25 UTC (permalink / raw)
To: Zhao1, Wei, dev, stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, April 4, 2018 4:06 PM
> To: dev@dpdk.org; stable@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v4] net/i40e: add flow RSS queue index check
tile start with fix.
>
> There need a queue index check for RSS queue region in order to aviod error
> from configuration.
>
> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Should be Tested-by: Yuan Peng <yuan.peng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> ---
>
> Changes in v2:
>
> move check code out from the big loop.
>
> change in v3:
>
> delete unnecessary dash in comment.
>
> change in v4:
>
> add more parameters check code.
> ---
> drivers/net/i40e/i40e_flow.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c index
> f3e8c5f..f4d08bb 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4216,6 +4216,32 @@ i40e_flow_parse_rss_action(struct rte_eth_dev
> *dev,
> }
> }
>
> + if (conf_info->queue_region_number) {
> + for (i = 0; i < rss->num; i++) {
> + for (j = 0; j < rss_info->num; j++) {
> + if (rss->queue[i] == rss_info->queue[j])
> + break;
> + }
> + if (j == rss_info->num) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> + }
> +
> + for (i = 0; i < rss->num - 1; i++) {
> + if (rss->queue[i + 1] != rss->queue[i] + 1) {
> + rte_flow_error_set(error, EINVAL,
> + RTE_FLOW_ERROR_TYPE_ACTION,
> + act,
> + "no valid queues");
> + return -rte_errno;
> + }
> + }
> + }
> +
> for (n = 0; n < conf_info->queue_region_number; n++) {
> if (conf_info->region[n].user_priority_num ||
> conf_info->region[n].flowtype_num) {
> --
> 2.7.5
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [dpdk-dev] [PATCH v4] net/i40e: add flow RSS queue index check
2018-04-04 13:25 ` Zhang, Qi Z
@ 2018-04-06 8:30 ` Zhang, Helin
0 siblings, 0 replies; 9+ messages in thread
From: Zhang, Helin @ 2018-04-06 8:30 UTC (permalink / raw)
To: Zhang, Qi Z, Zhao1, Wei, dev, stable
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhang, Qi Z
> Sent: Wednesday, April 4, 2018 9:26 PM
> To: Zhao1, Wei; dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: add flow RSS queue index check
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, April 4, 2018 4:06 PM
> > To: dev@dpdk.org; stable@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v4] net/i40e: add flow RSS queue index check
>
> tile start with fix.
>
> >
> > There need a queue index check for RSS queue region in order to aviod
> > error from configuration.
> >
> > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
>
> Should be Tested-by: Yuan Peng <yuan.peng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-04-06 9:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 3:18 [dpdk-dev] [PATCH] net/i40e: add flow RSS queue index check Wei Zhao
2018-04-04 3:59 ` Zhang, Qi Z
2018-04-04 4:02 ` Zhao1, Wei
2018-04-04 5:12 ` Zhao1, Wei
2018-04-04 5:00 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-04-04 5:06 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-04-04 8:06 ` [dpdk-dev] [PATCH v4] " Wei Zhao
2018-04-04 13:25 ` Zhang, Qi Z
2018-04-06 8:30 ` Zhang, Helin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).