From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR
Date: Thu, 14 Jun 2018 01:51:08 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07DFCFF8@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7E8F4D@shsmsx102.ccr.corp.intel.com>
Hi,
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Thursday, June 14, 2018 8:42 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR
>
> Hi Wei,
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, June 13, 2018 4:12 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; stable@dpdk.org; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v2] net/ixgbe: fix tunnel type set error for FDIR
> >
> > Tunnel type format should be translated to ixgbe required format
> > before register set in FDIR cloud mode, Ans also some register not
> > useful in cloud mode but only useful in IP mode should be set to zero as
> datasheet request.
> >
> > Fixes: 82fb702077f6 ("ixgbe: support new flow director modes for
> > X550")
> > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> >
> > v2:
> > -change register write function for FDIRIPSA and FDIRIPDA.
> >
> > ---
> > drivers/net/ixgbe/ixgbe_fdir.c | 17 +++++++++++++----
> > drivers/net/ixgbe/ixgbe_flow.c | 6 ++----
> > 2 files changed, 15 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c
> > b/drivers/net/ixgbe/ixgbe_fdir.c index 67ab627..3feb815 100644
> > --- a/drivers/net/ixgbe/ixgbe_fdir.c
> > +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> > @@ -771,8 +771,15 @@ ixgbe_fdir_filter_to_atr_input(const struct
> > rte_eth_fdir_filter *fdir_filter,
> > input->formatted.inner_mac,
> > fdir_filter-
> > >input.flow.tunnel_flow.mac_addr.addr_bytes,
> > sizeof(input->formatted.inner_mac));
> > - input->formatted.tunnel_type =
> > - fdir_filter->input.flow.tunnel_flow.tunnel_type;
> > + if (fdir_filter->input.flow.tunnel_flow.tunnel_type ==
> > + RTE_FDIR_TUNNEL_TYPE_VXLAN)
> > + input->formatted.tunnel_type = 0x8000;
> > + else if (fdir_filter->input.flow.tunnel_flow.tunnel_type ==
> > + RTE_FDIR_TUNNEL_TYPE_NVGRE)
> > + input->formatted.tunnel_type = 0;
> Better use macros for 0x8000 and 0. And add comments why these values
> are used.
Ok, I will add some comment.
next prev parent reply other threads:[~2018-06-14 1:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:12 [dpdk-dev] [PATCH] app/testpmd: fix VLAN tci mask " Wei Zhao
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: add query rule stats support " Wei Zhao
2018-06-13 8:07 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-13 8:08 ` Wei Zhao
2018-06-14 0:36 ` Lu, Wenzhuo
2018-06-21 14:08 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: add support for VLAN in IP mode FDIR Wei Zhao
2018-06-12 2:25 ` Lu, Wenzhuo
2018-06-12 2:30 ` Zhao1, Wei
2018-06-12 2:41 ` Lu, Wenzhuo
2018-06-12 2:49 ` Zhao1, Wei
2018-06-12 3:18 ` Zhao1, Wei
2018-06-13 8:09 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-14 0:37 ` Lu, Wenzhuo
2018-06-21 14:09 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: fix tunnel id format error for FDIR Wei Zhao
2018-06-12 5:10 ` Lu, Wenzhuo
2018-06-12 7:49 ` Zhao1, Wei
2018-06-12 8:39 ` Lu, Wenzhuo
2018-06-12 8:43 ` Zhao1, Wei
2018-06-13 8:11 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-14 0:38 ` Lu, Wenzhuo
2018-06-21 14:10 ` Zhang, Qi Z
2018-06-05 9:12 ` [dpdk-dev] [PATCH] net/ixgbe: fix tunnel type set " Wei Zhao
2018-06-13 8:11 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-06-14 0:41 ` Lu, Wenzhuo
2018-06-14 1:51 ` Zhao1, Wei [this message]
2018-06-14 8:17 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-06-15 0:50 ` Lu, Wenzhuo
2018-06-21 14:11 ` Zhang, Qi Z
2018-06-12 1:12 ` [dpdk-dev] [PATCH] app/testpmd: fix VLAN tci mask " Lu, Wenzhuo
2018-06-21 14:27 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07DFCFF8@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).