From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7D3F52BCE; Thu, 9 Aug 2018 03:51:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2018 18:51:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,213,1531810800"; d="scan'208";a="79759770" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga001.fm.intel.com with ESMTP; 08 Aug 2018 18:51:21 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.163]) by KMSMSX153.gar.corp.intel.com ([169.254.5.101]) with mapi id 14.03.0319.002; Thu, 9 Aug 2018 09:51:20 +0800 From: "Zhao1, Wei" To: "Yigit, Ferruh" CC: "stable@dpdk.org" , "Lu, Wenzhuo" , "Zhang, Qi Z" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe Thread-Index: AQHUKghheNnUPoKPUkGtOFjOfHwkcKS2scjg Date: Thu, 9 Aug 2018 01:51:19 +0000 Message-ID: References: <1532399811-52078-1-git-send-email-wei.zhao1@intel.com> <039ED4275CED7440929022BC67E7061153262AEF@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153262AEF@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 01:51:44 -0000 Hi, Ferruh What do you think of the patch implementation? > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, August 2, 2018 10:28 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Yigit, Ferruh ; stable@dpdk.org; Zhao1, Wei > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP > config from ixgbe >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > > Sent: Tuesday, July 24, 2018 10:37 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; stable@dpdk.org; Zhao1, > > Wei ; Lu, Wenzhuo > > Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP > > config from ixgbe > > > > There is CRC related ifdefs for ixgbe: > > CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=3Dn > > It is used in VF drivers ixgbevf_dev_configure() functions. > > VF cannot change the CRC strip behavior and based on what PF > > configured it needs to response proper to user > > ixgbevf_dev_configure() request. Right now what PF set is defined by > > above config options but this method is too static. > > > > Signed-off-by: Wei Zhao > > Signed-off-by: Wenzhuo Lu > > --- > > app/test-pmd/parameters.c | 6 ++++++ > > app/test-pmd/testpmd.c | 2 ++ > > app/test-pmd/testpmd.h | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++---------- > > lib/librte_ethdev/rte_ethdev.h | 1 + > > 5 files changed, 20 insertions(+), 10 deletions(-) >=20 > Its better separate the patch for ethdev, ixgbe, and testpmd. >=20