From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 9B6CF7D34; Wed, 17 Oct 2018 10:14:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Oct 2018 01:14:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,391,1534834800"; d="scan'208";a="88964460" Received: from pgsmsx102.gar.corp.intel.com ([10.221.44.80]) by FMSMGA003.fm.intel.com with ESMTP; 17 Oct 2018 01:14:07 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by PGSMSX102.gar.corp.intel.com (10.221.44.80) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 17 Oct 2018 16:09:18 +0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.13]) by PGSMSX109.gar.corp.intel.com ([169.254.14.29]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 16:09:18 +0800 From: "Zhao1, Wei" To: "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Yigit, Ferruh" Thread-Topic: [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port Thread-Index: AQHUZfA2EUWHe62vBUSHrZVeqcw2+qUjFJzw Date: Wed, 17 Oct 2018 08:09:17 +0000 Message-ID: References: <1539762086-15569-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1539762086-15569-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 08:14:10 -0000 By the way, I think the maintainer's opinion is important for this change, but there is no maintainer name for this example in file MAINTAINERS! > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, October 17, 2018 3:41 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Zhao1, Wei > Subject: [PATCH] examples/ipv4_multicast: enable multicast promiscuous fo= r > all port >=20 > This example has not been enable for receiving multicast packet, so it wi= ll > drop multicast packet. Users must send packet with ether MAC destination > address the same as pf port MAC address, in order to forward packet > successfully, but this is an example for forwarding ipv4 multicastpacket.= So > calling function > rte_eth_promiscuous_enable() or rte_eth_allmulticast_enable() can enable > promiscuous mode of all multicast packet. And aslo, DPDK has rte API > function of rte_eth_dev_set_mc_addr_list() for setting specific multicast > filter table for specific multicast IP address, but this example do not s= upport > this configuration, so it need to be enable multicast promiscuous mode > instead. >=20 > Signed-off-by: Wei Zhao > --- > examples/ipv4_multicast/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/ipv4_multicast/main.c > b/examples/ipv4_multicast/main.c index 6530d48..4073a49 100644 > --- a/examples/ipv4_multicast/main.c > +++ b/examples/ipv4_multicast/main.c > @@ -773,7 +773,7 @@ main(int argc, char **argv) > qconf->tx_queue_id[portid] =3D queueid; > queueid++; > } > - > + rte_eth_allmulticast_enable(portid); > /* Start device */ > ret =3D rte_eth_dev_start(portid); > if (ret < 0) > -- > 2.7.5