From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 211DA2BAE; Thu, 25 Oct 2018 04:09:34 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2018 19:09:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,422,1534834800"; d="scan'208";a="102266641" Received: from pgsmsx111.gar.corp.intel.com ([10.108.55.200]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2018 19:09:32 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.13]) by PGSMSX111.gar.corp.intel.com ([169.254.2.202]) with mapi id 14.03.0319.002; Thu, 25 Oct 2018 10:07:41 +0800 From: "Zhao1, Wei" To: "Wang, Dong1" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Yigit, Ferruh" , Thomas Monjalon Thread-Topic: [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port Thread-Index: AQHUZfA2EUWHe62vBUSHrZVeqcw2+qUjFJzwgAr+NtCAAAt4IIABJKvQ Date: Thu, 25 Oct 2018 02:07:40 +0000 Message-ID: References: <1539762086-15569-1-git-send-email-wei.zhao1@intel.com> <3E2E5017C928014B90FD7864A64F0B5514F64677@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F64677@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable multicast promiscuous for all port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 02:09:36 -0000 > -----Original Message----- > From: Wang, Dong1 > Sent: Wednesday, October 24, 2018 4:51 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Thomas Monjalon > Subject: RE: [PATCH] examples/ipv4_multicast: enable multicast promiscuou= s > for all port >=20 > Tested it with 82599 PF. >=20 > Acked-by: Wang Dong >=20 Thank you! > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, October 24, 2018 16:11 > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Wang, Dong1 ; Thomas > Monjalon > Subject: RE: [PATCH] examples/ipv4_multicast: enable multicast promiscuou= s > for all port >=20 > Add Wang Dong in the mailing list, he has test this patch. >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhao1, Wei > > Sent: Wednesday, October 17, 2018 4:09 PM > > To: dev@dpdk.org > > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > > > > Subject: Re: [dpdk-dev] [PATCH] examples/ipv4_multicast: enable > > multicast promiscuous for all port > > > > By the way, I think the maintainer's opinion is important for this > > change, but there is no maintainer name for this example in file > MAINTAINERS! > > > > > -----Original Message----- > > > From: Zhao1, Wei > > > Sent: Wednesday, October 17, 2018 3:41 PM > > > To: dev@dpdk.org > > > Cc: stable@dpdk.org; Zhang, Qi Z ; Yigit, > > > Ferruh ; Zhao1, Wei > > > Subject: [PATCH] examples/ipv4_multicast: enable multicast > > > promiscuous for all port > > > > > > This example has not been enable for receiving multicast packet, so > > > it will drop multicast packet. Users must send packet with ether MAC > > > destination address the same as pf port MAC address, in order to > > > forward packet successfully, but this is an example for forwarding > > > ipv4 multicastpacket. So calling function > > > rte_eth_promiscuous_enable() or rte_eth_allmulticast_enable() can > > > enable promiscuous mode of all multicast packet. And aslo, DPDK has > > > rte API function of rte_eth_dev_set_mc_addr_list() for setting > > > specific multicast filter table for specific multicast IP address, > > > but this example do not support this configuration, so it need to be > > > enable multicast promiscuous mode instead. > > > > > > Signed-off-by: Wei Zhao > > > --- > > > examples/ipv4_multicast/main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/examples/ipv4_multicast/main.c > > > b/examples/ipv4_multicast/main.c index 6530d48..4073a49 100644 > > > --- a/examples/ipv4_multicast/main.c > > > +++ b/examples/ipv4_multicast/main.c > > > @@ -773,7 +773,7 @@ main(int argc, char **argv) > > > qconf->tx_queue_id[portid] =3D queueid; > > > queueid++; > > > } > > > - > > > + rte_eth_allmulticast_enable(portid); > > > /* Start device */ > > > ret =3D rte_eth_dev_start(portid); > > > if (ret < 0) > > > -- > > > 2.7.5