From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D62374CAD; Thu, 1 Nov 2018 06:38:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2018 22:38:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,450,1534834800"; d="scan'208";a="92863252" Received: from kmsmsx155.gar.corp.intel.com ([172.21.73.106]) by FMSMGA003.fm.intel.com with ESMTP; 31 Oct 2018 22:37:59 -0700 Received: from pgsmsx109.gar.corp.intel.com (10.221.44.109) by KMSMSX155.gar.corp.intel.com (172.21.73.106) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 1 Nov 2018 13:37:43 +0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.114]) by PGSMSX109.gar.corp.intel.com ([169.254.14.66]) with mapi id 14.03.0415.000; Thu, 1 Nov 2018 13:35:29 +0800 From: "Zhao1, Wei" To: "Ye, Xiaolong" , "Zhang, Qi Z" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" , "Ye, Xiaolong" Thread-Topic: [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK Thread-Index: AQHUbeG7uE++1ifuZ0it1j5Mmqnd26U6bQCA Date: Thu, 1 Nov 2018 05:35:28 +0000 Message-ID: References: <20181027104032.10251-1-xiaolong.ye@intel.com> In-Reply-To: <20181027104032.10251-1-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 05:38:02 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaolong Ye > Sent: Saturday, October 27, 2018 6:40 PM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; stable@dpdk.org; Ye, Xiaolong > Subject: [dpdk-dev] [PATCH 0/8] Correct XXX_TX_OFFLOAD_NOTSUP_MASK >=20 > Hi, >=20 > This patch series is to correct the wrong setting of XXX_TX_OFFLOAD_MASK > in multiple PMDs. >=20 > Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be > the mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or > in XXX_TX_OFFLOAD_MASK), however, xor will not get desired result here, > assume bit 0 of PKT_TX_OFFLOAD_MASK and XXX_TX_OFFLOAD_MAKS are > 0 which means corresponding feature is not supported in both sides, then > we get value of bit 0 of XXX_TX_OFFLOAD_NOTSUP_MASK which is 0 via xor, > it implies that it is supported which doesn't meet our expectation. >=20 Yes, I agree with you. Reviewed-by: Wei Zhao > Correct it by a NOT-AND operation. >=20 > Xiaolong Ye (8): > net/ixgbe: correct offload not supported mask > net/avf: correct offload not supported mask > net/ena: correct offload not supported mask > net/atlantic: correct offload not supported mask > net/fm10k: correct offload not supported mask > net/qede: correct offload not supported mask > net/vmxnet3: correct offload not supported mask > net/e1000: correct offload not supported mask >=20 > drivers/net/atlantic/atl_rxtx.c | 2 +- > drivers/net/avf/avf_rxtx.h | 2 +- > drivers/net/e1000/em_rxtx.c | 2 +- > drivers/net/e1000/igb_rxtx.c | 2 +- > drivers/net/ena/ena_ethdev.c | 2 +- > drivers/net/fm10k/fm10k_rxtx.c | 2 +- > drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- > drivers/net/qede/qede_rxtx.h | 2 +- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +- > 9 files changed, 9 insertions(+), 9 deletions(-) >=20 > -- > 2.17.1