From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id BCC433237; Thu, 17 Jan 2019 10:31:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2019 01:31:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="267824109" Received: from kmsmsx157.gar.corp.intel.com ([172.21.138.134]) by orsmga004.jf.intel.com with ESMTP; 17 Jan 2019 01:31:53 -0800 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.6]) by kmsmsx157.gar.corp.intel.com ([169.254.5.220]) with mapi id 14.03.0415.000; Thu, 17 Jan 2019 17:27:22 +0800 From: "Zhao1, Wei" To: Stephen Hemminger CC: "dev@dpdk.org" , "stable@dpdk.org" , "Lu, Wenzhuo" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF Thread-Index: AQHUrVmabeGiNxfVyUqJCSQ1S2VWpqWxumYAgAF37FA= Date: Thu, 17 Jan 2019 09:27:20 +0000 Message-ID: References: <1547613775-58027-1-git-send-email-wei.zhao1@intel.com> <20190116105928.792b8ac8@shemminger-XPS-13-9360> In-Reply-To: <20190116105928.792b8ac8@shemminger-XPS-13-9360> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 09:31:56 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Thursday, January 17, 2019 2:59 AM > To: Zhao1, Wei > Cc: dev@dpdk.org; stable@dpdk.org; Lu, Wenzhuo > ; Zhang, Qi Z > Subject: Re: [dpdk-dev] [PATCH 0/3] promiscuous mode enable on VF >=20 > On Wed, 16 Jan 2019 12:42:52 +0800 > Wei Zhao wrote: >=20 > > There is need to enable promiscuous mode enable on VF, pf host should > > also enable to support that. > > > > Zhao Wei (3): > > net/ixgbe: promiscuous mode enable on VF > > net/ixgbe: enable promiscous mode on PF host > > net/ixgbe: update API version > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++ > > drivers/net/ixgbe/ixgbe_ethdev.h | 1 + > > drivers/net/ixgbe/ixgbe_pf.c | 79 > +++++++++++++++++++++++++++++----------- > > 3 files changed, 79 insertions(+), 22 deletions(-) > > >=20 > Is there someway to check if PF on host allows promiscious mode (and fail > the attempt to set it on VF if not allowed). Yes,=20 Pf host has check vfinfo[vf].api_version, that is key for that check. If fail, it will return -1. switch (vfinfo[vf].api_version) { case ixgbe_mbox_api_12: + /* promisc introduced in 1.3 version */ + if (xcast_mode =3D=3D IXGBEVF_XCAST_MODE_PROMISC) + return -EOPNOTSUPP; + break; + /* Fall threw */ + case ixgbe_mbox_api_13: break; default: return -1; }