From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3A2FD4C94; Wed, 20 Mar 2019 10:25:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 02:25:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="156623182" Received: from pgsmsx112-dag.png.intel.com (HELO PGSMSX112.gar.corp.intel.com) ([10.108.55.234]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2019 02:25:16 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by PGSMSX112.gar.corp.intel.com ([169.254.3.114]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:23:13 +0800 From: "Zhao1, Wei" To: "Peng, Yuan" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/i40e: add warning info when no perfect RSS key Thread-Index: AQHU3tFQE3bix/sDLEm009GDFp64D6YTuMeAgACGdsA= Date: Wed, 20 Mar 2019 09:23:11 +0000 Message-ID: References: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 09:25:19 -0000 Thank you! > -----Original Message----- > From: Peng, Yuan > Sent: Wednesday, March 20, 2019 5:21 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z > Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key >=20 > Tested-by: Peng Yuan >=20 > - Tested Branch: master > - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c > - OS: 4.13.9-300.fc27.x86_64 > - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) > - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz > - NIC: Intel Corporation Device Fortville [8086:1583] > - Default x86_64-native-linuxapp-gcc configuration > - Prerequisites: > - Total 1 case1, 1 passed, 0 failed >=20 > - Case steps: > 1. Bind the pf port to dpdk driver: > ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd: > ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=3D*:8 -c 1ffff -n 4 = - -i -- > nb-cores=3D8 --rxq=3D4 --txq=3D4 --port-topology=3Dchained >=20 > 3. set an invalid RSS-key > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp en= d > key 67108863 / end > i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured > i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, s= o use > default configuration >=20 > Flow rule #0 created > there is a device warning reported. >=20 >=20 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, March 20, 2019 11:31 AM > To: dev@dpdk.org > Cc: Peng, Yuan ; stable@dpdk.org; Zhang, Qi Z > ; Zhao1, Wei > Subject: [PATCH] net/i40e: add warning info when no perfect RSS key >=20 > There need a warning info when no perfect RSS key is config, so i40e will= use > default key. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index dca61f0..9235b08 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > rss_conf.rss_key =3D (uint8_t *)rss_key_default; > rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > sizeof(uint32_t); > + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config > for i40e, so > +use default configuration\n"); > } >=20 > i40e_hw_rss_hash_set(pf, &rss_conf); > -- > 2.7.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 487D9A00E6 for ; Wed, 20 Mar 2019 10:25:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 151D04C95; Wed, 20 Mar 2019 10:25:21 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3A2FD4C94; Wed, 20 Mar 2019 10:25:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 02:25:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,248,1549958400"; d="scan'208";a="156623182" Received: from pgsmsx112-dag.png.intel.com (HELO PGSMSX112.gar.corp.intel.com) ([10.108.55.234]) by fmsmga001.fm.intel.com with ESMTP; 20 Mar 2019 02:25:16 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.210]) by PGSMSX112.gar.corp.intel.com ([169.254.3.114]) with mapi id 14.03.0415.000; Wed, 20 Mar 2019 17:23:13 +0800 From: "Zhao1, Wei" To: "Peng, Yuan" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/i40e: add warning info when no perfect RSS key Thread-Index: AQHU3tFQE3bix/sDLEm009GDFp64D6YTuMeAgACGdsA= Date: Wed, 20 Mar 2019 09:23:11 +0000 Message-ID: References: <1553052676-7961-1-git-send-email-wei.zhao1@intel.com> <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <67D543A150B29E4CAAE53918F64EDAEA376A5E6E@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add warning info when no perfect RSS key X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320092311.fZYPi_g_hrvs9bD_YSbkBPRJx5vqjnMqY36NvhjiTTA@z> Thank you! > -----Original Message----- > From: Peng, Yuan > Sent: Wednesday, March 20, 2019 5:21 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z > Subject: RE: [PATCH] net/i40e: add warning info when no perfect RSS key >=20 > Tested-by: Peng Yuan >=20 > - Tested Branch: master > - Tested Commit: 239912fa798e6e671072ca7ff987afd74c1e506c > - OS: 4.13.9-300.fc27.x86_64 > - GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) > - CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz > - NIC: Intel Corporation Device Fortville [8086:1583] > - Default x86_64-native-linuxapp-gcc configuration > - Prerequisites: > - Total 1 case1, 1 passed, 0 failed >=20 > - Case steps: > 1. Bind the pf port to dpdk driver: > ./usertools/dpdk-devbind.py -b igb_uio 05:00.0 05:00.1 2. start testpmd: > ./x86_64-native-linuxapp-gcc/app/testpmd --log-level=3D*:8 -c 1ffff -n 4 = - -i -- > nb-cores=3D8 --rxq=3D4 --txq=3D4 --port-topology=3Dchained >=20 > 3. set an invalid RSS-key > testpmd> flow create 0 ingress pattern end actions rss types ipv4-udp en= d > key 67108863 / end > i40e_config_rss_filter(): Max of contiguous 4 PF queues are configured > i40e_config_rss_filter(): Warning! No perfect RSS key config for i40e, s= o use > default configuration >=20 > Flow rule #0 created > there is a device warning reported. >=20 >=20 > -----Original Message----- > From: Zhao1, Wei > Sent: Wednesday, March 20, 2019 11:31 AM > To: dev@dpdk.org > Cc: Peng, Yuan ; stable@dpdk.org; Zhang, Qi Z > ; Zhao1, Wei > Subject: [PATCH] net/i40e: add warning info when no perfect RSS key >=20 > There need a warning info when no perfect RSS key is config, so i40e will= use > default key. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Zhao > --- > drivers/net/i40e/i40e_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index dca61f0..9235b08 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -12744,6 +12744,7 @@ i40e_config_rss_filter(struct i40e_pf *pf, > rss_conf.rss_key =3D (uint8_t *)rss_key_default; > rss_conf.rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > sizeof(uint32_t); > + PMD_DRV_LOG(INFO, "Warning! No perfect RSS key config > for i40e, so > +use default configuration\n"); > } >=20 > i40e_hw_rss_hash_set(pf, &rss_conf); > -- > 2.7.5