From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EA22CA05DC for ; Mon, 10 Jun 2019 08:40:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 162B01BE59; Mon, 10 Jun 2019 08:40:35 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3F0DB1BE32; Mon, 10 Jun 2019 08:40:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 23:40:32 -0700 X-ExtLoop1: 1 Received: from pgsmsx114.gar.corp.intel.com ([10.108.55.203]) by fmsmga007.fm.intel.com with ESMTP; 09 Jun 2019 23:40:31 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.115]) by pgsmsx114.gar.corp.intel.com ([169.254.4.185]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 14:40:21 +0800 From: "Zhao1, Wei" To: "Iremonger, Bernard" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Peng, Yuan" , "Yigit, Ferruh" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec Thread-Index: AQHVHTk1hwmDkPiQdkiF4k7sJiGhw6aUdBGg Date: Mon, 10 Jun 2019 06:40:20 +0000 Message-ID: References: <1557386426-57149-1-git-send-email-wei.zhao1@intel.com> <1557477677-54876-1-git-send-email-wei.zhao1@intel.com> <8CEF83825BEC744B83065625E567D7C260DAD471@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260DAD471@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check for macsec X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thank you, update in v3. > -----Original Message----- > From: Iremonger, Bernard > Sent: Friday, June 7, 2019 9:59 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: stable@dpdk.org; Peng, Yuan ; Yigit, Ferruh > ; Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: remove port stop check fo= r > macsec >=20 > Hi Wei, >=20 > >=20 > > > Subject: [PATCH v2] app/testpmd: remove port stop check for macsec > > > > > > There is no need to do such a check when set macsec for ixgbe, > > > reconfig_device_queueand is also useless. If we do not delete this >=20 > Typo: space missing before "and" in previous line. >=20 > > > unnessary code, users have to sotp port before enable or disable >=20 > Typo: "sotp" should be "stop" >=20 > > > macsec, then restart this port after make configuration. All these >=20 > Typo: "these" should be "this" >=20 > > > process is useless. As this cmdline is a private API which is only > > > used by ixgbe > > NIC, so remove it. > > > > > > Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Wei Zhao >=20 > Otherwise > Acked-by: Bernard Iremonger