From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A1BAA046B for ; Tue, 23 Jul 2019 05:20:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C5FE1BED6; Tue, 23 Jul 2019 05:20:58 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3774F1BED4; Tue, 23 Jul 2019 05:20:57 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 20:20:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,297,1559545200"; d="scan'208";a="368234646" Received: from pgsmsx112.gar.corp.intel.com ([10.108.55.201]) by fmsmga005.fm.intel.com with ESMTP; 22 Jul 2019 20:20:55 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.4]) by PGSMSX112.gar.corp.intel.com ([169.254.3.46]) with mapi id 14.03.0439.000; Tue, 23 Jul 2019 11:20:54 +0800 From: "Zhao1, Wei" To: "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/ixgbe: fix x550 reta set fail error Thread-Index: AQHVQFfBU47C11eNEEiTA7aA6oap4qbXiiLg Date: Tue, 23 Jul 2019 03:20:54 +0000 Message-ID: References: <1563775495-13785-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1563775495-13785-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Zhao HaiyangX > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, July 22, 2019 2:05 PM > To: dev@dpdk.org > Cc: stable@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/ixgbe: fix x550 reta set fail error >=20 > There is a bug in function ixgbevf_dev_info_get(), it do not contain the = reta > table size get function for vf port, and this will cause error when updat= e reta > for x550 vf port. >=20 > Cc: stable@dpdk.org >=20 > Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info") > Signed-off-by: wei zhao > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 22c5b2c..773f667 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev, > dev_info->rx_queue_offload_capa); > dev_info->tx_queue_offload_capa =3D ixgbe_get_tx_queue_offloads(dev); > dev_info->tx_offload_capa =3D ixgbe_get_tx_port_offloads(dev); > + dev_info->hash_key_size =3D IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t); > + dev_info->reta_size =3D ixgbe_reta_size_get(hw->mac.type); >=20 > dev_info->default_rxconf =3D (struct rte_eth_rxconf) { > .rx_thresh =3D { > @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type > mac_type) { > case ixgbe_mac_X550EM_x_vf: > case ixgbe_mac_X550EM_a_vf: > return ETH_RSS_RETA_SIZE_64; > + case ixgbe_mac_X540_vf: > + case ixgbe_mac_82599_vf: > + return 0; > default: > return ETH_RSS_RETA_SIZE_128; > } > -- > 2.7.5