* Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error
2019-07-22 6:04 [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error Wei Zhao
@ 2019-07-23 3:20 ` Zhao1, Wei
2019-07-23 3:21 ` Zhao1, Wei
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Zhao1, Wei @ 2019-07-23 3:20 UTC (permalink / raw)
To: dev; +Cc: stable, Zhang, Qi Z
Tested-by: Zhao HaiyangX <haiyangx.zhao@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, July 22, 2019 2:05 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/ixgbe: fix x550 reta set fail error
>
> There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta
> table size get function for vf port, and this will cause error when update reta
> for x550 vf port.
>
> Cc: stable@dpdk.org
>
> Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
> Signed-off-by: wei zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 22c5b2c..773f667 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
> dev_info->rx_queue_offload_capa);
> dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
> dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
> + dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
> + dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
>
> dev_info->default_rxconf = (struct rte_eth_rxconf) {
> .rx_thresh = {
> @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type
> mac_type) {
> case ixgbe_mac_X550EM_x_vf:
> case ixgbe_mac_X550EM_a_vf:
> return ETH_RSS_RETA_SIZE_64;
> + case ixgbe_mac_X540_vf:
> + case ixgbe_mac_82599_vf:
> + return 0;
> default:
> return ETH_RSS_RETA_SIZE_128;
> }
> --
> 2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error
2019-07-22 6:04 [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error Wei Zhao
2019-07-23 3:20 ` Zhao1, Wei
@ 2019-07-23 3:21 ` Zhao1, Wei
2019-07-23 4:11 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta " Wei Zhao
2019-07-23 4:13 ` Wei Zhao
3 siblings, 0 replies; 10+ messages in thread
From: Zhao1, Wei @ 2019-07-23 3:21 UTC (permalink / raw)
To: dev; +Cc: stable, Zhang, Qi Z, Zhao, HaiyangX
Add cc HaiyangX
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, July 23, 2019 11:21 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/ixgbe: fix x550 reta set fail error
>
> Tested-by: Zhao HaiyangX <haiyangx.zhao@intel.com>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Monday, July 22, 2019 2:05 PM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/ixgbe: fix x550 reta set fail error
> >
> > There is a bug in function ixgbevf_dev_info_get(), it do not contain
> > the reta table size get function for vf port, and this will cause
> > error when update reta for x550 vf port.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: 2144f6630fca ("ixgbe: add redirection table size in device
> > info")
> > Signed-off-by: wei zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 22c5b2c..773f667 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> > @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
> > dev_info->rx_queue_offload_capa);
> > dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
> > dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
> > + dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
> > + dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
> >
> > dev_info->default_rxconf = (struct rte_eth_rxconf) {
> > .rx_thresh = {
> > @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type
> > mac_type) {
> > case ixgbe_mac_X550EM_x_vf:
> > case ixgbe_mac_X550EM_a_vf:
> > return ETH_RSS_RETA_SIZE_64;
> > + case ixgbe_mac_X540_vf:
> > + case ixgbe_mac_82599_vf:
> > + return 0;
> > default:
> > return ETH_RSS_RETA_SIZE_128;
> > }
> > --
> > 2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error
2019-07-22 6:04 [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error Wei Zhao
2019-07-23 3:20 ` Zhao1, Wei
2019-07-23 3:21 ` Zhao1, Wei
@ 2019-07-23 4:11 ` Wei Zhao
2019-07-23 4:13 ` Wei Zhao
3 siblings, 0 replies; 10+ messages in thread
From: Wei Zhao @ 2019-07-23 4:11 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, wei zhao
There is a bug in function ixgbevf_dev_info_get(), it do not
contain the reta table size get function for vf port, and this
will cause error when update reta for x550 vf port. And also
when function is ixgbe_reta_size_get() called, it should return
other ixgbe NIC vf reta support or not, not only x550.
Cc: stable@dpdk.org
Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
Signed-off-by: wei zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 22c5b2c..773f667 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
dev_info->rx_queue_offload_capa);
dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
+ dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
+ dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
@@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type mac_type) {
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
return ETH_RSS_RETA_SIZE_64;
+ case ixgbe_mac_X540_vf:
+ case ixgbe_mac_82599_vf:
+ return 0;
default:
return ETH_RSS_RETA_SIZE_128;
}
--
2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error
2019-07-22 6:04 [dpdk-dev] [PATCH] net/ixgbe: fix x550 reta set fail error Wei Zhao
` (2 preceding siblings ...)
2019-07-23 4:11 ` [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta " Wei Zhao
@ 2019-07-23 4:13 ` Wei Zhao
2019-07-23 7:30 ` Zhang, Qi Z
` (2 more replies)
3 siblings, 3 replies; 10+ messages in thread
From: Wei Zhao @ 2019-07-23 4:13 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, wei zhao
There is a bug in function ixgbevf_dev_info_get(), it do not
contain the reta table size get function for vf port, and this
will cause error when update reta for x550 vf port. And also
when function ixgbe_reta_size_get() is called, it should return
other ixgbe NIC vf reta support or not, not only x550.
Cc: stable@dpdk.org
Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
Signed-off-by: wei zhao <wei.zhao1@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 22c5b2c..773f667 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
dev_info->rx_queue_offload_capa);
dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
+ dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
+ dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
@@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type mac_type) {
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
return ETH_RSS_RETA_SIZE_64;
+ case ixgbe_mac_X540_vf:
+ case ixgbe_mac_82599_vf:
+ return 0;
default:
return ETH_RSS_RETA_SIZE_128;
}
--
2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error
2019-07-23 4:13 ` Wei Zhao
@ 2019-07-23 7:30 ` Zhang, Qi Z
2019-07-23 22:15 ` Ye Xiaolong
2019-07-26 1:38 ` [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF Wei Zhao
2 siblings, 0 replies; 10+ messages in thread
From: Zhang, Qi Z @ 2019-07-23 7:30 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, July 23, 2019 12:13 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v2] net/ixgbe: fix x550 Reta set fail error
>
> There is a bug in function ixgbevf_dev_info_get(), it do not contain the reta
> table size get function for vf port, and this will cause error when update reta
> for x550 vf port. And also when function ixgbe_reta_size_get() is called, it
> should return other ixgbe NIC vf reta support or not, not only x550.
This commit log is a little bit misleading
Does below description OK for you?
Title:
net/ixgbe: fix reta size for VF
Filling correct reta table size at ixgbevf_dev_info_get, so reta table update will be supported for VF port.
For X540_vf and 82599_vf, since they don't support reta table update, set reta size to 0.
>
> Cc: stable@dpdk.org
>
> Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
> Signed-off-by: wei zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 22c5b2c..773f667 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
> dev_info->rx_queue_offload_capa);
> dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
> dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
> + dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
> + dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
>
> dev_info->default_rxconf = (struct rte_eth_rxconf) {
> .rx_thresh = {
> @@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type
> mac_type) {
> case ixgbe_mac_X550EM_x_vf:
> case ixgbe_mac_X550EM_a_vf:
> return ETH_RSS_RETA_SIZE_64;
> + case ixgbe_mac_X540_vf:
> + case ixgbe_mac_82599_vf:
> + return 0;
> default:
> return ETH_RSS_RETA_SIZE_128;
> }
> --
> 2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix x550 Reta set fail error
2019-07-23 4:13 ` Wei Zhao
2019-07-23 7:30 ` Zhang, Qi Z
@ 2019-07-23 22:15 ` Ye Xiaolong
2019-07-26 1:38 ` [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF Wei Zhao
2 siblings, 0 replies; 10+ messages in thread
From: Ye Xiaolong @ 2019-07-23 22:15 UTC (permalink / raw)
To: Wei Zhao; +Cc: dev, stable, qi.z.zhang
On 07/23, Wei Zhao wrote:
>There is a bug in function ixgbevf_dev_info_get(), it do not
>contain the reta table size get function for vf port, and this
>will cause error when update reta for x550 vf port. And also
>when function ixgbe_reta_size_get() is called, it should return
>other ixgbe NIC vf reta support or not, not only x550.
>
>Cc: stable@dpdk.org
>
>Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
>Signed-off-by: wei zhao <wei.zhao1@intel.com>
Minor nit about your signoff, the first letter of your name should be captial.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
For the patch,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF
2019-07-23 4:13 ` Wei Zhao
2019-07-23 7:30 ` Zhang, Qi Z
2019-07-23 22:15 ` Ye Xiaolong
@ 2019-07-26 1:38 ` Wei Zhao
2019-07-26 4:54 ` Zhang, Qi Z
2 siblings, 1 reply; 10+ messages in thread
From: Wei Zhao @ 2019-07-26 1:38 UTC (permalink / raw)
To: dev; +Cc: stable, qi.z.zhang, wei zhao
Filling correct reta table size at ixgbevf_dev_info_get,
so reta table update will be supported for VF port.
For X540_vf and 82599_vf, since they don't support
reta table update, set reta size to 0.
Cc: stable@dpdk.org
Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
Signed-off-by: wei zhao <wei.zhao1@intel.com>
---
v2:
--add more git log
v3:
--change headline and update git log
---
drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 22c5b2c..773f667 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3927,6 +3927,8 @@ ixgbevf_dev_info_get(struct rte_eth_dev *dev,
dev_info->rx_queue_offload_capa);
dev_info->tx_queue_offload_capa = ixgbe_get_tx_queue_offloads(dev);
dev_info->tx_offload_capa = ixgbe_get_tx_port_offloads(dev);
+ dev_info->hash_key_size = IXGBE_HKEY_MAX_INDEX * sizeof(uint32_t);
+ dev_info->reta_size = ixgbe_reta_size_get(hw->mac.type);
dev_info->default_rxconf = (struct rte_eth_rxconf) {
.rx_thresh = {
@@ -7438,6 +7440,9 @@ ixgbe_reta_size_get(enum ixgbe_mac_type mac_type) {
case ixgbe_mac_X550EM_x_vf:
case ixgbe_mac_X550EM_a_vf:
return ETH_RSS_RETA_SIZE_64;
+ case ixgbe_mac_X540_vf:
+ case ixgbe_mac_82599_vf:
+ return 0;
default:
return ETH_RSS_RETA_SIZE_128;
}
--
2.7.5
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF
2019-07-26 1:38 ` [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF Wei Zhao
@ 2019-07-26 4:54 ` Zhang, Qi Z
2019-07-26 5:52 ` Zhao1, Wei
0 siblings, 1 reply; 10+ messages in thread
From: Zhang, Qi Z @ 2019-07-26 4:54 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Friday, July 26, 2019 9:38 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH v3] net/ixgbe: fix Reta size for VF
>
> Filling correct reta table size at ixgbevf_dev_info_get, so reta table update
> will be supported for VF port.
> For X540_vf and 82599_vf, since they don't support reta table update, set
> reta size to 0.
>
> Cc: stable@dpdk.org
>
> Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
> Signed-off-by: wei zhao <wei.zhao1@intel.com>
Please correct to "Wei Zhao" next time.
>
> ---
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF
2019-07-26 4:54 ` Zhang, Qi Z
@ 2019-07-26 5:52 ` Zhao1, Wei
0 siblings, 0 replies; 10+ messages in thread
From: Zhao1, Wei @ 2019-07-26 5:52 UTC (permalink / raw)
To: Zhang, Qi Z, dev; +Cc: stable
Ok.
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, July 26, 2019 12:55 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: RE: [PATCH v3] net/ixgbe: fix Reta size for VF
>
>
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Friday, July 26, 2019 9:38 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH v3] net/ixgbe: fix Reta size for VF
> >
> > Filling correct reta table size at ixgbevf_dev_info_get, so reta table
> > update will be supported for VF port.
> > For X540_vf and 82599_vf, since they don't support reta table update,
> > set reta size to 0.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: 2144f6630fca ("ixgbe: add redirection table size in device
> > info")
> > Signed-off-by: wei zhao <wei.zhao1@intel.com>
>
> Please correct to "Wei Zhao" next time.
> >
> > ---
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
> Thanks
> Qi
^ permalink raw reply [flat|nested] 10+ messages in thread