From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9561FA0613 for ; Fri, 27 Sep 2019 08:01:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 569912C0C; Fri, 27 Sep 2019 08:01:51 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A9CD52BE6 for ; Fri, 27 Sep 2019 08:01:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 23:01:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,554,1559545200"; d="scan'208";a="389861591" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by fmsmga005.fm.intel.com with ESMTP; 26 Sep 2019 23:01:48 -0700 Received: from pgsmsx103.gar.corp.intel.com ([169.254.2.183]) by PGSMSX101.gar.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0439.000; Fri, 27 Sep 2019 14:01:47 +0800 From: "Zhao1, Wei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Yang, Qiming" CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Zhang, Qi Z" , "Nowlin, Dan" , "Stillwell Jr, Paul M" Thread-Topic: [dpdk-dev] [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule Thread-Index: AQHVdOoWHuo/QdxlcUaKNylUljqddqc/CDog Date: Fri, 27 Sep 2019 06:01:46 +0000 Message-ID: References: <20190902035551.16852-1-qi.z.zhang@intel.com> <20190927041646.34712-1-qi.z.zhang@intel.com> <20190927041646.34712-2-qi.z.zhang@intel.com> In-Reply-To: <20190927041646.34712-2-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [172.30.20.205] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/8] net/ice/base: fix for adding PPPoE switch rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Wei Zhao > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Friday, September 27, 2019 12:17 PM > To: Lu, Wenzhuo ; Yang, Qiming > > Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > ; Nowlin, Dan ; Stillwell Jr, > Paul M > Subject: [dpdk-dev] [PATCH 1/8] net/ice/base: fix for adding PPPoE switch > rule >=20 > Update VLAN protocol ID to correct value for single VXLAN scenario. > Correct the PPPOE training packet. >=20 > Fixes: d341bdc30290 ("net/ice/base: add support for GTP and PPPoE > protocols") >=20 > Signed-off-by: Dan Nowlin > Signed-off-by: Paul M Stillwell Jr > Signed-off-by: Qi Zhang > --- > drivers/net/ice/base/ice_protocol_type.h | 2 +- > drivers/net/ice/base/ice_switch.c | 12 +++++++----- > 2 files changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/ice/base/ice_protocol_type.h > b/drivers/net/ice/base/ice_protocol_type.h > index f61345a7f..548c9730a 100644 > --- a/drivers/net/ice/base/ice_protocol_type.h > +++ b/drivers/net/ice/base/ice_protocol_type.h > @@ -118,7 +118,7 @@ enum ice_prot_id { > #define ICE_MAC_OFOS_HW 1 > #define ICE_MAC_IL_HW 4 > #define ICE_ETYPE_OL_HW 9 > -#define ICE_VLAN_OL_HW 16 > +#define ICE_VLAN_OL_HW 17 > #define ICE_IPV4_OFOS_HW 32 > #define ICE_IPV4_IL_HW 33 > #define ICE_IPV6_OFOS_HW 40 > diff --git a/drivers/net/ice/base/ice_switch.c > b/drivers/net/ice/base/ice_switch.c > index 80afa74cd..a72f4b430 100644 > --- a/drivers/net/ice/base/ice_switch.c > +++ b/drivers/net/ice/base/ice_switch.c > @@ -433,16 +433,18 @@ dummy_pppoe_packet[] =3D { >=20 > 0x00, 0x00, 0x88, 0x64, /* ICE_VLAN_OFOS 14 */ >=20 > - 0x11, 0x00, 0x00, 0x01, /* ICE_PPPOE 18 */ > - 0x00, 0x4e, 0x00, 0x21, > + 0x11, 0x00, 0x00, 0x00, /* ICE_PPPOE 18 */ > + 0x00, 0x16, >=20 > - 0x45, 0x00, 0x00, 0x30, /* PDU */ > + 0x00, 0x21, /* PPP Link Layer 24 */ > + > + 0x45, 0x00, 0x00, 0x14, /* ICE_IPV4_IL 26 */ > + 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, > - 0x00, 0x11, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, >=20 > - 0x00, 0x00, /* 2 bytes for 4 byte alignment */ > + 0x00, 0x00, /* 2 bytes for 4 bytes alignment */ > }; >=20 > /* this is a recipe to profile association bitmap */ > -- > 2.13.6