From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CA2421F002 for ; Wed, 13 Jun 2018 19:40:39 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2018 10:40:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,219,1526367600"; d="scan'208";a="236894882" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 13 Jun 2018 10:40:37 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 13 Jun 2018 10:40:36 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.220]) by fmsmsx156.amr.corp.intel.com ([169.254.13.171]) with mapi id 14.03.0319.002; Wed, 13 Jun 2018 10:40:36 -0700 From: "Wiles, Keith" To: Thomas Monjalon CC: "Yigit, Ferruh" , Rahul Lakkireddy , "dev@dpdk.org" , "shaguna@chelsio.com" , "kumaras@chelsio.com" , "indranil@chelsio.com" , "nirranjan@chelsio.com" , Hemant Agrawal Thread-Topic: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources Thread-Index: AQHUAzf0Bt40svPIA0ujkq0hH5axTaRe6iwA Date: Wed, 13 Jun 2018 17:40:36 +0000 Message-ID: References: <8334e31d-da73-0d55-ba1f-3b91102048e1@intel.com> <12849424.ZYKo8dt3dJ@xps> In-Reply-To: <12849424.ZYKo8dt3dJ@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.116.191] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/7] net/cxgbe: query firmware for filter resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 17:40:40 -0000 > On Jun 13, 2018, at 11:59 AM, Thomas Monjalon wrote= : >=20 > 13/06/2018 18:41, Ferruh Yigit: >> On 6/8/2018 6:58 PM, Rahul Lakkireddy wrote: >>> diff --git a/drivers/net/cxgbe/cxgbe_filter.h b/drivers/net/cxgbe/cxgbe= _filter.h >>> new file mode 100644 >>> index 000000000..d69c79e80 >>> --- /dev/null >>> +++ b/drivers/net/cxgbe/cxgbe_filter.h >>> @@ -0,0 +1,97 @@ >>> +/* SPDX-License-Identifier: BSD-3-Clause >>> + * Copyright(c) 2014-2018 Chelsio Communications. >>> + * All rights reserved. >>> + */ >>> + >>=20 >> Hi Rahul, >>=20 >> This is a new file and copyright starts from 2014, is this intentional? >>=20 >> And @Thomas, @Hemant, are we allowed to have copyright start date in the= past >> for new files? >=20 > I prefer having accurate copyright year because it is a quick hint about > how old the file is. > But I think there is no strong legal consequence. I would guess if you have the wrong year and that year was before/after it = was created then you will have a problem proving it was valid in a given ye= ar. Not having a real date can cause some problems if we ever have a confli= ct or law suit. We should always update the copyright when we modify a file= and the correct date when it is created. Regards, Keith