From: Fengchengwen <fengchengwen@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"humin (Q)" <humin29@huawei.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities
Date: Tue, 27 Apr 2021 14:26:28 +0000 [thread overview]
Message-ID: <A4EE077B-3D5C-4CAA-BB74-B96597ABC4E5> (raw)
In-Reply-To: <0d9171de-bfd3-6fa8-bbfc-f61344a3048a@intel.com>
From:Ferruh Yigit <ferruh.yigit@intel.com>
To:humin (Q) <humin29@huawei.com>;dev <dev@dpdk.org>
Date:2021-04-27 21:37:59
Subject:Re: [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities
On 4/26/2021 4:34 AM, Min Hu (Connor) wrote:
> From: Chengwen Feng < fengchengwen@huawei.com<mailto:fengchengwen@huawei.com>>
>
> This patch deletes some unused capabilities, include:
> 1. Delete some unused firmware capabilities definition.
> 2. Delete some unused driver capabilities definition.
>
> Signed-off-by: Chengwen Feng < fengchengwen@huawei.com<mailto:fengchengwen@huawei.com>>
> Signed-off-by: Min Hu (Connor) < humin29@huawei.com<mailto:humin29@huawei.com>>
<...>
> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
> index d27c725..de17878 100644
> --- a/drivers/net/hns3/hns3_ethdev.h
> +++ b/drivers/net/hns3/hns3_ethdev.h
> @@ -855,17 +855,20 @@ enum {
>
> #define HNS3_DEVARG_DEV_CAPS_MASK "dev_caps_mask"
>
> -#define HNS3_DEV_SUPPORT_DCB_B 0x0
> -#define HNS3_DEV_SUPPORT_COPPER_B 0x1
> -#define HNS3_DEV_SUPPORT_UDP_GSO_B 0x2
> -#define HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B 0x3
> -#define HNS3_DEV_SUPPORT_PTP_B 0x4
> -#define HNS3_DEV_SUPPORT_TX_PUSH_B 0x5
> -#define HNS3_DEV_SUPPORT_INDEP_TXRX_B 0x6
> -#define HNS3_DEV_SUPPORT_STASH_B 0x7
> -#define HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B 0x9
> -#define HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B 0xA
> -#define HNS3_DEV_SUPPORT_RAS_IMP_B 0xB
> +enum {
> + HNS3_DEV_SUPPORT_DCB_B,
> + HNS3_DEV_SUPPORT_COPPER_B,
> + HNS3_DEV_SUPPORT_FD_QUEUE_REGION_B,
> + HNS3_DEV_SUPPORT_PTP_B,
> + HNS3_DEV_SUPPORT_TX_PUSH_B,
> + HNS3_DEV_SUPPORT_INDEP_TXRX_B,
> + HNS3_DEV_SUPPORT_STASH_B,
> + HNS3_DEV_SUPPORT_SIMPLE_BD_B,
> + HNS3_DEV_SUPPORT_RXD_ADV_LAYOUT_B,
> + HNS3_DEV_SUPPORT_OUTER_UDP_CKSUM_B,
> + HNS3_DEV_SUPPORT_RAS_IMP_B,
> + HNS3_DEV_SUPPORT_TM_B,
> +};
This cause some values to be changed, because of added/removed items, is this
expected?
If so can you please mention from this value change in the commit log, to clarify.
these values are used only in driver, so the order could adjust.
the commit log memtion it brifely, which is:
2. Delete some unused driver capabilities definition
thanks
next prev parent reply other threads:[~2021-04-27 14:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 3:34 [dpdk-dev] [PATCH 0/6] optimization and bugfix for hns3 PMD Min Hu (Connor)
2021-04-26 3:34 ` [dpdk-dev] [PATCH 1/6] net/hns3: delete some unused capabilities Min Hu (Connor)
2021-04-27 13:37 ` Ferruh Yigit
2021-04-27 14:26 ` Fengchengwen [this message]
2021-04-27 14:30 ` Ferruh Yigit
2021-04-26 3:34 ` [dpdk-dev] [PATCH 2/6] net/hns3: modify write reg opt API impl Min Hu (Connor)
2021-04-26 3:34 ` [dpdk-dev] [PATCH 3/6] net/hns3: use RTE DIM instead of ARRAY SIZE Min Hu (Connor)
2021-04-26 3:34 ` [dpdk-dev] [PATCH 4/6] net/hns3: improve IO path data cache usage Min Hu (Connor)
2021-04-26 3:34 ` [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration Min Hu (Connor)
2021-04-27 13:39 ` Ferruh Yigit
2021-04-27 14:15 ` Fengchengwen
2021-04-27 14:25 ` Ferruh Yigit
2021-04-27 14:29 ` Fengchengwen
2021-04-26 3:34 ` [dpdk-dev] [PATCH 6/6] net/hns3: fix vector Rx burst default value Min Hu (Connor)
2021-04-27 13:46 ` Ferruh Yigit
2021-04-27 14:34 ` Fengchengwen
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 0/6] optimization and bugfix for hns3 PMD Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 1/6] net/hns3: delete some unused capabilities Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 2/6] net/hns3: modify write reg opt API impl Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 3/6] net/hns3: use RTE DIM instead of ARRAY SIZE Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 4/6] net/hns3: improve IO path data cache usage Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 5/6] net/hns3: log FDIR configuration Min Hu (Connor)
2021-04-28 9:53 ` [dpdk-dev] [PATCH v2 6/6] net/hns3: fix vector Rx burst can't exceed 32 Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 0/6] optimization and bugfix for hns3 PMD Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 1/6] net/hns3: delete some unused capabilities Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 2/6] net/hns3: modify write reg opt API impl Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 3/6] net/hns3: use RTE DIM instead of ARRAY SIZE Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 4/6] net/hns3: improve IO path data cache usage Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 5/6] net/hns3: log FDIR configuration Min Hu (Connor)
2021-04-30 6:28 ` [dpdk-dev] [PATCH v3 6/6] net/hns3: fix vector Rx burst can't exceed 32 Min Hu (Connor)
2021-05-04 16:03 ` [dpdk-dev] [PATCH v3 0/6] optimization and bugfix for hns3 PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A4EE077B-3D5C-4CAA-BB74-B96597ABC4E5 \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).