From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 727608E84 for ; Thu, 21 Jan 2016 21:06:13 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 21 Jan 2016 12:06:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,327,1449561600"; d="scan'208";a="731910490" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 21 Jan 2016 12:06:11 -0800 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.197]) by IRSMSX151.ger.corp.intel.com ([169.254.4.108]) with mapi id 14.03.0248.002; Thu, 21 Jan 2016 20:06:10 +0000 From: "Chilikin, Andrey" To: "Wu, Jingjing" , "dev@dpdk.org" Thread-Topic: [PATCH 2/4] i40e: split function for input set change of hash and fdir Thread-Index: AQHRPu6F/dFGp1Zbck+kJ2qjwi2lj58E+nPggABd5ICAATKQYA== Date: Thu, 21 Jan 2016 20:06:09 +0000 Message-ID: References: <1451032200-24973-1-git-send-email-jingjing.wu@intel.com> <1451032200-24973-3-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8D8AB7A@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F8D8AB7A@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 2/4] i40e: split function for input set change of hash and fdir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 20:06:14 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, January 21, 2016 1:29 AM > To: Chilikin, Andrey; dev@dpdk.org > Cc: Zhang, Helin; Pei, Yulong; Ananyev, Konstantin > Subject: RE: [PATCH 2/4] i40e: split function for input set change of has= h and > fdir >=20 > Hi, Andrey >=20 > Thanks for your comments. You are correct, I removed the > I40E_INSET_FLEX_PAYLOAD from valid fdir input set values, and this is one > reason why I splited function for input set change of hash and and it is = because > all flex payload configuration can be set in struct rte_fdir_conf during = device > configure phase. And it is a more flexible configuration including flexpa= yload's > selection, input set selection by word and mask setting in bits. Should it be then two patches? First patch to split fdir and hash input set= configuration and then second one to remove existing functionality? At the= moment it is not obvious that this patch not just splits fdir input set co= nfiguration but removes some features in a way that fdir it is not compatib= le with DPDK 2.2 anymore. >=20 > If I enable it in the input set change API, it will be duplicate. And the= input set > change on flexible payload only on word, just some ability compared with > rte_fdir_conf. > If flexible selection isn't done in struct rte_fdir_conf, the input set = selection in > input set change API doesn't make sense. If flexible selection is done in= struct > rte_fdir_conf, why not selection input set in struct rte_fdir_conf at the= same > time? I do not have a problem with selecting it at the same time - it always was = this way with the legacy systems. But now new NIC supports new way of confi= guring input set with flexible payload as a part of this input set. So why = not to have new way of configuration available as well and change input set= using one API call instead of splitting single configuration in to two par= ts? > And about you concern, "when application has to run on an old NIC and on = a > new one", The rte_fdir_conf is for each eth_dev, so it will be fine. >=20 > Thanks > Jingjing Regards, Andrey >=20 >=20 > > -----Original Message----- > > From: Chilikin, Andrey > > Sent: Thursday, January 21, 2016 4:05 AM > > To: Wu, Jingjing; dev@dpdk.org > > Cc: Zhang, Helin; Pei, Yulong; Ananyev, Konstantin > > Subject: RE: [PATCH 2/4] i40e: split function for input set change of > > hash and fdir > > > > Hi Jingjing, > > > > As I can see this patch not only splits fdir functionality from common > > fdir/hash code but also removes compatibility with DPDK 2.2 as it > > deletes I40E_INSET_FLEX_PAYLOAD from valid fdir input set values. Yes, > > flexible payload configuration can be set for fdir separately at the > > port initialization, but this is more legacy from the previous > > generations of NICs which did not support dynamic input set > > configuration. I believe it would better to have > > I40E_INSET_FLEX_PAYLOAD valid for fdir input set same as in DPDK 2.2. > > So in legacy mode, when application has to run on an old NIC and on a > > new one, only legacy configuration would be used, but for applications > targeting new HW single point of configuration would be used instead of m= ix of > two. > > > > Regards, > > Andrey > >