From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A3D4E2BE1 for ; Wed, 28 Jun 2017 09:40:25 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 28 Jun 2017 00:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,274,1496127600"; d="scan'208";a="279490375" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga004.fm.intel.com with ESMTP; 28 Jun 2017 00:40:20 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.236]) by IRSMSX104.ger.corp.intel.com ([169.254.5.26]) with mapi id 14.03.0319.002; Wed, 28 Jun 2017 08:40:19 +0100 From: "Chilikin, Andrey" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Wu, Jingjing" Thread-Topic: [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing Thread-Index: AQHS70o/muzMu+AoWUWWhsSr3gqWvaI5yFiAgAAaw/A= Date: Wed, 28 Jun 2017 07:40:18 +0000 Message-ID: References: <1495901077-11845-1-git-send-email-andrey.chilikin@intel.com> <1498570513-8592-2-git-send-email-andrey.chilikin@intel.com> <94479800C636CB44BD422CB454846E0131FD8F09@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E0131FD8F09@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBjMDQ0OWEtZmE2MC00MTJiLTgxZTMtOGE2YzY2NGM4NGZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRlaWt0QTVFZGw1Q3pYQ2pBUCtGYllRV0dWTnE2XC9YQ3JUZ2hLV2xrc1FJPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 07:40:26 -0000 Hi Beilei, > -----Original Message----- > From: Xing, Beilei > Sent: Wednesday, June 28, 2017 7:58 AM > To: Chilikin, Andrey ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for ddp > processing >=20 > Hi Andrey, >=20 > > + } > > + else { >=20 > Should be } else { here according to the coding style. Will fix in v4 > > --- a/drivers/net/i40e/rte_pmd_i40e.h > > +++ b/drivers/net/i40e/rte_pmd_i40e.h > > @@ -71,6 +71,8 @@ struct rte_pmd_i40e_mb_event_param { enum > > rte_pmd_i40e_package_op { > > RTE_PMD_I40E_PKG_OP_UNDEFINED =3D 0, > > RTE_PMD_I40E_PKG_OP_WR_ADD, /**< load package and add to > > info list */ > > + RTE_PMD_I40E_PKG_OP_WR_DEL, /**< load package and delete > > from info list */ > > + RTE_PMD_I40E_PKG_OP_WR_ONLY, /**< load package without > > modifying info > > +list */ >=20 > The only difference between RTE_PMD_I40E_PKG_OP_WR_ADD and > RTE_PMD_I40E_PKG_OP_WR_ONLY is if need to change info list, right? Is the= re > any difference between the profiles added? Do we need another CLI in test= pmd > to indicate how/when we need to use RTE_PMD_I40E_PKG_OP_WR_ONLY? >=20 I believe that existing testpmd CLI is enough for i40e as this 'if' stateme= nt if (track_id && (op !=3D RTE_PMD_I40E_PKG_OP_WR_ONLY)) { will not register profiles with track_id =3D=3D 0 > Beilei Regards, Andrey