From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF998A04B5; Mon, 2 Dec 2019 17:58:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB2B81BF78; Mon, 2 Dec 2019 17:58:05 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D4793235 for ; Mon, 2 Dec 2019 17:33:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 08:33:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204619593" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 02 Dec 2019 08:33:58 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Dec 2019 08:33:58 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.27]) by FMSMSX102.amr.corp.intel.com ([169.254.10.138]) with mapi id 14.03.0439.000; Mon, 2 Dec 2019 08:33:57 -0800 From: "Williams, Mitch A" To: "Ye, Xiaolong" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH 60/69] net/i40e/base: clarify requirements Thread-Index: AQHVqOZowEW3OBaqGUivRA7CvSL7UaenCqRA Date: Mon, 2 Dec 2019 16:33:56 +0000 Message-ID: References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20191202074935.97629-61-xiaolong.ye@intel.com> In-Reply-To: <20191202074935.97629-61-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2EyOTZiMzktOTIzMS00NzkwLWEzMGYtOGMxYTI4ZDU1N2YzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOGhIeEtHUTIzVzF0c01UQmc3b1RLRE9zVnBLcHpoc010UHY2ZGJ3U1ArOFZXZmR6M0VTcWhhYXdvZVhzRUwrbyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 02 Dec 2019 17:58:00 +0100 Subject: Re: [dpdk-dev] [PATCH 60/69] net/i40e/base: clarify requirements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" NAK Code wrapped in EXTERNAL_RELEASE must not be released publicly. > -----Original Message----- > From: Ye, Xiaolong > Sent: Sunday, December 01, 2019 11:49 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Williams, Mitch A > > Subject: [PATCH 60/69] net/i40e/base: clarify requirements >=20 > Add some comments to clarify driver requirements and expectations. No > code or struct changes. >=20 > Signed-off-by: Mitch Williams > Reviewed-by: Kirsher Jeffrey T > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/base/virtchnl.h | 20 ++++++++++++++++++-- > 1 file changed, 18 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/base/virtchnl.h > b/drivers/net/i40e/base/virtchnl.h > index 46fdca1aa..eb44134ca 100644 > --- a/drivers/net/i40e/base/virtchnl.h > +++ b/drivers/net/i40e/base/virtchnl.h > @@ -347,11 +347,14 @@ struct virtchnl_rxq_info { > VIRTCHNL_CHECK_STRUCT_LEN(40, virtchnl_rxq_info); >=20 > /* VIRTCHNL_OP_CONFIG_VSI_QUEUES > - * VF sends this message to set parameters for all active TX and RX queu= es > + * VF sends this message to set parameters for active TX and RX queues > * associated with the specified VSI. > * PF configures queues and returns status. > * If the number of queues specified is greater than the number of queue= s > * associated with the VSI, an error is returned and no queues are > configured. > + * NOTE: The VF is not required to configure all queues in a single requ= est. > + * It may send multiple messages. PF drivers must correctly handle all V= F > + * requests. > */ > struct virtchnl_queue_pair_info { > /* NOTE: vsi_id and queue_id should be identical for both queues. */ > @@ -389,9 +392,19 @@ struct virtchnl_vf_res_request { > * VF uses this message to map vectors to queues. > * The rxq_map and txq_map fields are bitmaps used to indicate which que= ues > * are to be associated with the specified vector. > - * The "other" causes are always mapped to vector 0. > + * The "other" causes are always mapped to vector 0. The VF may not requ= est > + * that vector 0 be used for traffic. > * PF configures interrupt mapping and returns status. > + * NOTE: due to hardware requirements, all active queues (both TX and RX= ) > + * should be mapped to interrupts, even if the driver intends to operate > + * only in polling mode. In this case the interrupt may be disabled, but > + * the ITR timer will still run to trigger writebacks. > */ > +#ifndef EXTERNAL_RELEASE > + /* See section 9.1.3.1.1 and table 9-4 in the CPK HAS for information > + * on TX queue to vector mapping. > + */ > +#endif > struct virtchnl_vector_map { > u16 vsi_id; > u16 vector_id; > @@ -417,6 +430,9 @@ VIRTCHNL_CHECK_STRUCT_LEN(14, virtchnl_irq_map_info); > * (Currently, we only support 16 queues per VF, but we make the field > * u32 to allow for expansion.) > * PF performs requested action and returns status. > + * NOTE: The VF is not required to enable/disable all queues in a single > + * request. It may send multiple messages. > + * PF drivers must correctly handle all VF requests. > */ > struct virtchnl_queue_select { > u16 vsi_id; > -- > 2.17.1