From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <keith.wiles@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 642DE5A6A
for <dev@dpdk.org>; Mon, 14 Jan 2019 16:07:33 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
14 Jan 2019 07:07:32 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,478,1539673200"; d="scan'208";a="114561950"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by fmsmga007.fm.intel.com with ESMTP; 14 Jan 2019 07:07:32 -0800
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.408.0; Mon, 14 Jan 2019 07:07:32 -0800
Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.160]) by
FMSMSX110.amr.corp.intel.com ([169.254.14.203]) with mapi id 14.03.0415.000;
Mon, 14 Jan 2019 07:07:31 -0800
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2 7/7] net/tap: don't print pointer in info message
Thread-Index: AQHUqe06rv76wY1nOUenLUR96YX1RaWvZ/+A
Date: Mon, 14 Jan 2019 15:07:31 +0000
Message-ID: <ACA859AE-B029-4477-9631-715F9423B4FA@intel.com>
References: <20190111180659.5972-1-stephen@networkplumber.org>
<20190111203520.19944-1-stephen@networkplumber.org>
<20190111203520.19944-8-stephen@networkplumber.org>
In-Reply-To: <20190111203520.19944-8-stephen@networkplumber.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.252.143.82]
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AF3F3B8AFBA16448806D02FB5D890413@intel.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2 7/7] net/tap: don't print pointer in info
message
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 15:07:34 -0000
> On Jan 11, 2019, at 2:35 PM, Stephen Hemminger <stephen@networkplumber.or=
g> wrote:
>=20
> Printing pointer in log is uninformative (unless in a debugger),
> instead print the assigned kernel device name which correlates
> well with what TAP is doing.
>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.=
c
> index 705c90dadee5..586c8a952df9 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -853,6 +853,8 @@ tap_dev_stop(struct rte_eth_dev *dev)
> static int
> tap_dev_configure(struct rte_eth_dev *dev)
> {
> + struct pmd_internals *pmd =3D dev->data->dev_private;
> +
> if (dev->data->nb_rx_queues > RTE_PMD_TAP_MAX_QUEUES) {
> TAP_LOG(ERR,
> "%s: number of rx queues %d exceeds max num of queues %d",
> @@ -870,11 +872,11 @@ tap_dev_configure(struct rte_eth_dev *dev)
> return -1;
> }
>=20
> - TAP_LOG(INFO, "%s: %p: TX configured queues number: %u",
> - dev->device->name, (void *)dev, dev->data->nb_tx_queues);
> + TAP_LOG(INFO, "%s: %s: TX configured queues number: %u",
> + dev->device->name, pmd->name, dev->data->nb_tx_queues);
>=20
> - TAP_LOG(INFO, "%s: %p: RX configured queues number: %u",
> - dev->device->name, (void *)dev, dev->data->nb_rx_queues);
> + TAP_LOG(INFO, "%s: %s: RX configured queues number: %u",
> + dev->device->name, pmd->name, dev->data->nb_rx_queues);
Acked-by: Keith Wiles <keith.wiles@intel.com>
>=20
> return 0;
> }
> --=20
> 2.20.1
>=20
Regards,
Keith