From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <keith.wiles@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 264A34CC7 for <dev@dpdk.org>; Wed, 21 Mar 2018 18:32:26 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2018 10:32:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,340,1517904000"; d="scan'208";a="25873494" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 21 Mar 2018 10:32:25 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.206]) by FMSMSX106.amr.corp.intel.com ([169.254.5.158]) with mapi id 14.03.0319.002; Wed, 21 Mar 2018 10:32:25 -0700 From: "Wiles, Keith" <keith.wiles@intel.com> To: Gaetan Rivet <gaetan.rivet@6wind.com> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility Thread-Index: AQHTwTiAqZcnlNtXwkOGENOUjoHrbqPbaA0A Date: Wed, 21 Mar 2018 17:32:24 +0000 Message-ID: <ADF9E411-F255-49DC-81AA-C292F4E9F92B@intel.com> References: <cover.1521652453.git.gaetan.rivet@6wind.com> <a2487b6a8d1ba3f062f50e1f00727006d96a8feb.1521652453.git.gaetan.rivet@6wind.com> In-Reply-To: <a2487b6a8d1ba3f062f50e1f00727006d96a8feb.1521652453.git.gaetan.rivet@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.201.178] Content-Type: text/plain; charset="us-ascii" Content-ID: <59BE2DBB0B3A1F4481F6B3BD16F123EE@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 04/18] eal: add lightweight kvarg parsing utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 21 Mar 2018 17:32:27 -0000 > On Mar 21, 2018, at 12:15 PM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote= : >=20 > This library offers a quick way to parse parameters passed with a > key=3Dvalue syntax. >=20 > A single function is needed and finds the relevant element within the > text. No dynamic allocation is performed. It is possible to chain the > parsing of each pairs for quickly scanning a list. >=20 > This utility is private to the EAL and should allow avoiding having to > move around the more complete librte_kvargs. What is the big advantage with this code and the librte_kvargs code. Is it = just no allocation, rte_kvargs needs to be build before parts of EAL or wha= t? My concern is we have now two flavors one in EAL and one in librte_kvargs, = would it not be more reasonable to improve rte_kvargs to remove your object= ions? I am all for fast, better, stronger code :-) >=20 > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> Regards, Keith