DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Xiao" <xiao.zhang@intel.com>
To: "Anand H. Krishnan" <anandhkrishnan@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Zhao1, Wei" <wei.zhao1@intel.com>
Subject: Re: [dpdk-dev] [DPDK] net/e1000: fix buffer overrun while i219 processing DMA transactions
Date: Sat, 20 Jul 2019 08:17:54 +0000	[thread overview]
Message-ID: <AF0377F445CB2540BB46FF359C1C1BBE01171E63@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <CACeb84vRzBT7YVO09SnY5Gbmu5r8dLoiu_q4m83L6Te-_pwvZQ@mail.gmail.com>



> -----Original Message-----
> From: Anand H. Krishnan [mailto:anandhkrishnan@gmail.com]
> Sent: Saturday, July 20, 2019 10:57 AM
> To: Zhang, Xiao <xiao.zhang@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: Re: [dpdk-dev] [DPDK] net/e1000: fix buffer overrun while i219
> processing DMA transactions
> 
> This seems to be changing the IGB driver. Shouldn't you be changing the em
> driver rather than the igb driver?

Yes, the fix changed to em driver in v2 patch. Thanks.

> Thanks,
> Anand
> 
> On Mon, Jul 8, 2019 at 10:10 AM Xiao Zhang <xiao.zhang@intel.com> wrote:
> >
> > Intel® 100/200 Series Chipset platforms reduced the round-trip latency
> > for the LAN Controller DMA accesses, causing in some high performance
> > cases a buffer overrun while the I219 LAN Connected Device is
> > processing the DMA transactions. I219LM and I219V devices can fall
> > into unrecovered Tx hang under very stressfully UDP traffic and
> > multiple reconnection of Ethernet cable. This Tx hang of the LAN
> > Controller is only recovered if the system is rebooted. Slightly slow
> > down DMA access by reducing the number of outstanding requests.
> > This workaround could have an impact on TCP traffic performance on the
> > platform. Disabling TSO eliminates performance loss for TCP traffic
> > without a noticeable impact on CPU performance.
> >
> > Please, refer to I218/I219 specification update:
> >
> https://www.intel.com/content/www/us/en/embedded/products/network
> ing/
> > ethernet-connection-i218-family-documentation.html
> >
> > Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
> > ---
> >  drivers/net/e1000/base/e1000_ich8lan.h |  1 +
> >  drivers/net/e1000/igb_rxtx.c           | 16 ++++++++++++++++
> >  2 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/net/e1000/base/e1000_ich8lan.h
> > b/drivers/net/e1000/base/e1000_ich8lan.h
> > index 1f2a3f8..084eb9c 100644
> > --- a/drivers/net/e1000/base/e1000_ich8lan.h
> > +++ b/drivers/net/e1000/base/e1000_ich8lan.h
> > @@ -134,6 +134,7 @@ POSSIBILITY OF SUCH DAMAGE.
> >  #define E1000_FLASH_BASE_ADDR 0xE000 /*offset of NVM access regs*/
> > #define E1000_CTRL_EXT_NVMVS 0x3 /*NVM valid sector */
> >  #define E1000_TARC0_CB_MULTIQ_3_REQ    (1 << 28 | 1 << 29)
> > +#define E1000_TARC0_CB_MULTIQ_2_REQ    (1 << 29)
> >  #define PCIE_ICH8_SNOOP_ALL    PCIE_NO_SNOOP_ALL
> >
> >  #define E1000_ICH_RAR_ENTRIES  7
> > diff --git a/drivers/net/e1000/igb_rxtx.c
> > b/drivers/net/e1000/igb_rxtx.c index 33eeb4e..5d45e62 100644
> > --- a/drivers/net/e1000/igb_rxtx.c
> > +++ b/drivers/net/e1000/igb_rxtx.c
> > @@ -2627,6 +2627,22 @@ eth_igb_tx_init(struct rte_eth_dev *dev)
> >
> >         e1000_config_collision_dist(hw);
> >
> > +       /* SPT and CNP Si errata workaround to avoid data corruption */
> > +       if (hw->mac.type == e1000_pch_spt) {
> > +               uint32_t reg_val;
> > +               reg_val = E1000_READ_REG(hw, E1000_IOSFPC);
> > +               reg_val |= E1000_RCTL_RDMTS_HEX;
> > +               E1000_WRITE_REG(hw, E1000_IOSFPC, reg_val);
> > +
> > +               /* Dropping the number of outstanding requests from
> > +                * 3 to 2 in order to avoid a buffer overrun.
> > +                */
> > +               reg_val = E1000_READ_REG(hw, E1000_TARC(0));
> > +               reg_val &= ~E1000_TARC0_CB_MULTIQ_3_REQ;
> > +               reg_val |= E1000_TARC0_CB_MULTIQ_2_REQ;
> > +               E1000_WRITE_REG(hw, E1000_TARC(0), reg_val);
> > +       }
> > +
> >         /* This write will effectively turn on the transmit unit. */
> >         E1000_WRITE_REG(hw, E1000_TCTL, tctl);  }
> > --
> > 2.7.4
> >

  reply	other threads:[~2019-07-20  8:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 13:36 Xiao Zhang
2019-07-19  5:44 ` Zhang, Qi Z
2019-07-20  2:56 ` Anand H. Krishnan
2019-07-20  8:17   ` Zhang, Xiao [this message]
2019-07-20 17:01 ` [dpdk-dev] [v2] " Xiao Zhang
2019-07-22  0:43   ` Zhang, Qi Z
2019-07-26  2:52 ` [dpdk-dev] [DPDK] " Zhao1, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AF0377F445CB2540BB46FF359C1C1BBE01171E63@SHSMSX105.ccr.corp.intel.com \
    --to=xiao.zhang@intel.com \
    --cc=anandhkrishnan@gmail.com \
    --cc=dev@dpdk.org \
    --cc=wei.zhao1@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).