From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <shahafs@mellanox.com>
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50])
 by dpdk.org (Postfix) with ESMTP id 18F8F4CA6
 for <dev@dpdk.org>; Thu,  4 Apr 2019 07:26:44 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=02muTiRHrvKLmiaoh9nq+Gox24R9LyfS0svtV7tu9Ik=;
 b=h0KtCUWWWtzsVSBA5wdqep2RjOswPdWnRhPkjxBJH1S35A0BmDMPRKVyx/kQQPEdpOOZwJdFxwdImdCmtNkcXdIt6HpocrKAXUuGIoz5rVm5jnKWJFZM5prcLbGsjCLDcEnWfgpAyIhYhCJlt8eA9c56JiDEa9et+B1rAbKe43Q=
Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by
 AM0PR0502MB4050.eurprd05.prod.outlook.com (52.133.37.26) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1750.20; Thu, 4 Apr 2019 05:26:41 +0000
Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com
 ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com
 ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Thu, 4 Apr 2019
 05:26:41 +0000
From: Shahaf Shuler <shahafs@mellanox.com>
To: Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>, Yongseok
 Koh <yskoh@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@mellanox.com>
Thread-Topic: [PATCH v3 3/3] net/mlx5: add jump action support for NIC
Thread-Index: AQHU6iA3HMhixV2YWUWECegydETsXaYreWWg
Date: Thu, 4 Apr 2019 05:26:41 +0000
Message-ID: <AM0PR0502MB37950997D793892151F356F3C3500@AM0PR0502MB3795.eurprd05.prod.outlook.com>
References: <1553790741-69362-1-git-send-email-orika@mellanox.com>
 <1554297697-13525-1-git-send-email-orika@mellanox.com>
 <1554297697-13525-4-git-send-email-orika@mellanox.com>
In-Reply-To: <1554297697-13525-4-git-send-email-orika@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=shahafs@mellanox.com; 
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4c3fb35d-5fb8-407e-674c-08d6b8be1e80
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);
 SRVR:AM0PR0502MB4050; 
x-ms-traffictypediagnostic: AM0PR0502MB4050:
x-microsoft-antispam-prvs: <AM0PR0502MB4050F90654ACA5D61B7893EBC3500@AM0PR0502MB4050.eurprd05.prod.outlook.com>
x-forefront-prvs: 0997523C40
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(136003)(396003)(376002)(39860400002)(346002)(366004)(199004)(189003)(66066001)(229853002)(7736002)(110136005)(74316002)(305945005)(86362001)(316002)(106356001)(486006)(33656002)(25786009)(8676002)(2906002)(81166006)(478600001)(256004)(81156014)(8936002)(5660300002)(105586002)(53936002)(4326008)(6506007)(6116002)(107886003)(6636002)(55016002)(97736004)(3846002)(14454004)(68736007)(71200400001)(6436002)(7696005)(102836004)(99286004)(52536014)(476003)(11346002)(26005)(186003)(446003)(71190400001)(54906003)(76176011)(9686003)(6246003);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4050;
 H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: bVqZMAFq9yF95BAUWJzDY4JY8od37DFS6ypkQSGvgX0Bat0vBh6GJJkvI4RUkRoJ77CCQ48htknZLA9JlOj4nYdVtBuqjLsstTSmKRVNDPgllTn1Jgk8wdVwONsdQxzhFMJfTHFysPcGWFOBFOPRHf1Cx3CZfkJIY9OWne8dRGcIIoRapnFK0OHv9SLtLu/PW4uKxhGjQWnP7YgkobKhgZtuh7+Tpk4ctNguOd1gvNlQoEhYfPtfklT2yPAKTMwtuOgii4iCc87Jp4+z2CyvjlMjHeB7CohJiTq+ofaA2kZtEmEhZRaIfzliN3VC3/E4GIPl6EaWGQFD7PNoejl2ZZxWU2/vLZZElzHY0NiMvuw5llzR4X2+KKQVf5jLrF5ikGKFNH57uGmaqYpuV/Elf/RHsBQJnwQN76tmChKgVQ8=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3fb35d-5fb8-407e-674c-08d6b8be1e80
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2019 05:26:41.3481 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4050
Subject: Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: add jump action support for
	NIC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Apr 2019 05:26:44 -0000

Hi Ori,

Wednesday, April 3, 2019 4:22 PM, Ori Kam:
> Subject: [PATCH v3 3/3] net/mlx5: add jump action support for NIC
>=20
> When using Direct Rules we can add actions to jump between tables.
> This is extra useful since rule insertion rate is much higher on other ta=
bles
> compared to table zero.
>=20
> if no group is selected the rule is added to group 0.
>=20
> Signed-off-by: Ori Kam <orika@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

[...]

>=20
> +
> +/**
> + * Get a flow table.
> + *
> + * @param dev[in, out]
> + *   Pointer to rte_eth_dev structure.
> + * @param[in] table_id
> + *   Table id to use.
> + * @param[in] egress
> + *   Direction of the table.
> + * @param[out] error
> + *   pointer to error structure.
> + *
> + * @return
> + *   Returns tables resource based on the index, NULL in case of failed.
> + */
> +static struct mlx5_flow_tbl_resource *
> +flow_dv_tbl_resource_get(struct rte_eth_dev *dev,
> +			 uint32_t table_id, uint8_t egress,
> +			 struct rte_flow_error *error)
> +{
> +	struct mlx5_priv *priv =3D dev->data->dev_private;
> +	struct mlx5_flow_tbl_resource *tbl;

Am getting compilation error here on latest rdma-core:
c: In function 'flow_dv_tbl_resource_get':
/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_flow_=
dv.c:2886:33: error: unused variable 'tbl'
 [-Werror=3Dunused-variable]
  struct mlx5_flow_tbl_resource *tbl;

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 33098A0679
	for <public@inbox.dpdk.org>; Thu,  4 Apr 2019 07:26:47 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A467D4CA7;
	Thu,  4 Apr 2019 07:26:45 +0200 (CEST)
Received: from EUR04-VI1-obe.outbound.protection.outlook.com
 (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50])
 by dpdk.org (Postfix) with ESMTP id 18F8F4CA6
 for <dev@dpdk.org>; Thu,  4 Apr 2019 07:26:44 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=02muTiRHrvKLmiaoh9nq+Gox24R9LyfS0svtV7tu9Ik=;
 b=h0KtCUWWWtzsVSBA5wdqep2RjOswPdWnRhPkjxBJH1S35A0BmDMPRKVyx/kQQPEdpOOZwJdFxwdImdCmtNkcXdIt6HpocrKAXUuGIoz5rVm5jnKWJFZM5prcLbGsjCLDcEnWfgpAyIhYhCJlt8eA9c56JiDEa9et+B1rAbKe43Q=
Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by
 AM0PR0502MB4050.eurprd05.prod.outlook.com (52.133.37.26) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1750.20; Thu, 4 Apr 2019 05:26:41 +0000
Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com
 ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com
 ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Thu, 4 Apr 2019
 05:26:41 +0000
From: Shahaf Shuler <shahafs@mellanox.com>
To: Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>, Yongseok
 Koh <yskoh@mellanox.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@mellanox.com>
Thread-Topic: [PATCH v3 3/3] net/mlx5: add jump action support for NIC
Thread-Index: AQHU6iA3HMhixV2YWUWECegydETsXaYreWWg
Date: Thu, 4 Apr 2019 05:26:41 +0000
Message-ID:
 <AM0PR0502MB37950997D793892151F356F3C3500@AM0PR0502MB3795.eurprd05.prod.outlook.com>
References: <1553790741-69362-1-git-send-email-orika@mellanox.com>
 <1554297697-13525-1-git-send-email-orika@mellanox.com>
 <1554297697-13525-4-git-send-email-orika@mellanox.com>
In-Reply-To: <1554297697-13525-4-git-send-email-orika@mellanox.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=shahafs@mellanox.com; 
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 4c3fb35d-5fb8-407e-674c-08d6b8be1e80
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);
 SRVR:AM0PR0502MB4050; 
x-ms-traffictypediagnostic: AM0PR0502MB4050:
x-microsoft-antispam-prvs: <AM0PR0502MB4050F90654ACA5D61B7893EBC3500@AM0PR0502MB4050.eurprd05.prod.outlook.com>
x-forefront-prvs: 0997523C40
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(136003)(396003)(376002)(39860400002)(346002)(366004)(199004)(189003)(66066001)(229853002)(7736002)(110136005)(74316002)(305945005)(86362001)(316002)(106356001)(486006)(33656002)(25786009)(8676002)(2906002)(81166006)(478600001)(256004)(81156014)(8936002)(5660300002)(105586002)(53936002)(4326008)(6506007)(6116002)(107886003)(6636002)(55016002)(97736004)(3846002)(14454004)(68736007)(71200400001)(6436002)(7696005)(102836004)(99286004)(52536014)(476003)(11346002)(26005)(186003)(446003)(71190400001)(54906003)(76176011)(9686003)(6246003);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4050;
 H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; A:1; MX:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: bVqZMAFq9yF95BAUWJzDY4JY8od37DFS6ypkQSGvgX0Bat0vBh6GJJkvI4RUkRoJ77CCQ48htknZLA9JlOj4nYdVtBuqjLsstTSmKRVNDPgllTn1Jgk8wdVwONsdQxzhFMJfTHFysPcGWFOBFOPRHf1Cx3CZfkJIY9OWne8dRGcIIoRapnFK0OHv9SLtLu/PW4uKxhGjQWnP7YgkobKhgZtuh7+Tpk4ctNguOd1gvNlQoEhYfPtfklT2yPAKTMwtuOgii4iCc87Jp4+z2CyvjlMjHeB7CohJiTq+ofaA2kZtEmEhZRaIfzliN3VC3/E4GIPl6EaWGQFD7PNoejl2ZZxWU2/vLZZElzHY0NiMvuw5llzR4X2+KKQVf5jLrF5ikGKFNH57uGmaqYpuV/Elf/RHsBQJnwQN76tmChKgVQ8=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3fb35d-5fb8-407e-674c-08d6b8be1e80
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2019 05:26:41.3481 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4050
Subject: Re: [dpdk-dev] [PATCH v3 3/3] net/mlx5: add jump action support for
	NIC
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190404052641.RKFKDQ4fKRQW4q6wN__A5X-UGaCYkOc1SJVIrTVsEfQ@z>

Hi Ori,

Wednesday, April 3, 2019 4:22 PM, Ori Kam:
> Subject: [PATCH v3 3/3] net/mlx5: add jump action support for NIC
>=20
> When using Direct Rules we can add actions to jump between tables.
> This is extra useful since rule insertion rate is much higher on other ta=
bles
> compared to table zero.
>=20
> if no group is selected the rule is added to group 0.
>=20
> Signed-off-by: Ori Kam <orika@mellanox.com>
> Acked-by: Shahaf Shuler <shahafs@mellanox.com>

[...]

>=20
> +
> +/**
> + * Get a flow table.
> + *
> + * @param dev[in, out]
> + *   Pointer to rte_eth_dev structure.
> + * @param[in] table_id
> + *   Table id to use.
> + * @param[in] egress
> + *   Direction of the table.
> + * @param[out] error
> + *   pointer to error structure.
> + *
> + * @return
> + *   Returns tables resource based on the index, NULL in case of failed.
> + */
> +static struct mlx5_flow_tbl_resource *
> +flow_dv_tbl_resource_get(struct rte_eth_dev *dev,
> +			 uint32_t table_id, uint8_t egress,
> +			 struct rte_flow_error *error)
> +{
> +	struct mlx5_priv *priv =3D dev->data->dev_private;
> +	struct mlx5_flow_tbl_resource *tbl;

Am getting compilation error here on latest rdma-core:
c: In function 'flow_dv_tbl_resource_get':
/.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_flow_=
dv.c:2886:33: error: unused variable 'tbl'
 [-Werror=3Dunused-variable]
  struct mlx5_flow_tbl_resource *tbl;