From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 78A45A0096 for ; Sun, 2 Jun 2019 09:54:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 338B04C9D; Sun, 2 Jun 2019 09:54:01 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60042.outbound.protection.outlook.com [40.107.6.42]) by dpdk.org (Postfix) with ESMTP id A56B62BE9; Sun, 2 Jun 2019 09:53:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=stsUosDyDtwPvWgaccjwDAkJ0oupNoeuJYze3ZxNXSc=; b=ULwho4b3M8+IKq89yg7hyvVUQ/WroBhnX2vKgCz35p7TBX1JyVyzJSp7bj73SGYQA4YtRjAxubWBnwoGiheQK0GQE4xy+Ajs5SHAuIHtXBT01u2abpSZWv3ydmk51YI3GjkSa7NmnUnNzG34D+2VhTBYFOCz1arV8cZ3OyEBif0= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3603.eurprd05.prod.outlook.com (52.133.49.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Sun, 2 Jun 2019 07:53:58 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::20f4:3214:12c9:100c]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::20f4:3214:12c9:100c%7]) with mapi id 15.20.1943.018; Sun, 2 Jun 2019 07:53:58 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func Thread-Index: AQHVCwZ9abU1yUlkgk++LKZp8zrIu6Z9zh/QgADMswCACX1aIA== Date: Sun, 2 Jun 2019 07:53:58 +0000 Message-ID: References: <1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 76f14d1d-5002-4b30-f7ef-08d6e72f7842 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3603; x-ms-traffictypediagnostic: AM0PR0502MB3603: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 005671E15D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(39860400002)(136003)(396003)(199004)(189003)(51914003)(13464003)(71200400001)(71190400001)(450100002)(229853002)(33656002)(186003)(6636002)(7736002)(4326008)(52536014)(2906002)(102836004)(476003)(86362001)(26005)(6116002)(478600001)(14444005)(74316002)(3846002)(76176011)(256004)(5660300002)(66066001)(66476007)(66556008)(64756008)(66446008)(99286004)(81156014)(53936002)(54906003)(55016002)(9686003)(486006)(81166006)(8676002)(316002)(6506007)(53546011)(66946007)(68736007)(446003)(6246003)(8936002)(11346002)(25786009)(305945005)(6436002)(110136005)(14454004)(76116006)(73956011)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3603; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: uxqhCVtVhBYDf+xA8oDXwl74RNiL7ASqgtUj/XH42kOR6ZGOrQFpwNSkhDP6NgnqlrRn7IMeXiosuohHYtqK+SIrFtpuKq3U4Zbr2rdGNsvwaGMt/dX34FcnW217fs1dwPN6T+KXS80YsCG7fUx5ZKj3MlCMZ/HAYz6ZOz8n5U6CI7kSCRBFWb2JIfANIu7PbtfvUofS0SDHZ1quy5QOzA5uTULxVfmkvm67REZ76i5RZoqbmaMhmaWRKkl73VN4EWU8TYwasHlSRp3EYsN61Aq+A+70WnALebkZrmFKPovqxw5C9GtC8FNeSuKApJhyUCbJHZs4u5KcbQxQH4bEmXW9g0vTzjYlknXZyIuNqOj+c7EeQmPJfH3Nrf/zNOutuzS1wKqdjtX+hZ/S+lgBQzbyjYgcgl31S7YIrAOcQJA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 76f14d1d-5002-4b30-f7ef-08d6e72f7842 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2019 07:53:58.5708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shahafs@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3603 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Monday, May 27, 2019 9:50 AM, Dekel Peled: > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scat= ter > func >=20 > PSB, thanks. >=20 > > -----Original Message----- > > From: Shahaf Shuler > > Sent: Sunday, May 26, 2019 9:49 PM > > To: Dekel Peled ; Yongseok Koh > > > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon > > scatter func > > > > Wednesday, May 15, 2019 1:08 PM, Dekel Peled: > > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon > > > scatter func > > > > > > Previous patch added handling of metadata for multi-segment packet. > > > Function txq_scatter_v in file mlx5_rxtx_vec_neon.h was updated > > > incorrectly, items were inserted into WQE in wrong order. > > > > > > This patch fixes the issue, inserting items into WQE correctly. > > > > > > Fixes: 7f4019d370f6 ("net/mlx5: fix Tx metadata for multi-segment > > > packet") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Dekel Peled > > > --- > > > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > > b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > > index 38e915c..b1e0e8f 100644 > > > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > > > @@ -171,7 +171,7 @@ > > > /* Fill ESEG in the header. */ > > > vst1q_u32((void *)(t_wqe + 1), > > > ((uint32x4_t){ 0, > > > - cs_flags << 16 | > > > rte_cpu_to_be_16(len), > > > + rte_cpu_to_be_16(len) << 16 | > > > cs_flags, > > > > It was probably not introduced by the previous patch, but since you > > touch this area: > > Why do you set the mss (len)? This function handles only non-TSO packet= s. >=20 > mss is set to 0 in txq_burst_v, which sends single segment packets. > This change is in txq_scatter_v which sends multi-segmented packets. Thanks for the clarification,=20 Applied to next-net-mlx, thanks.=20 >=20 > > > > > metadata, 0 })); > > > txq->wqe_ci =3D wqe_ci; > > > } > > > -- > > > 1.8.3.1