From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by dpdk.org (Postfix) with ESMTP id 8C1455F36 for ; Sun, 24 Mar 2019 10:13:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9ln16tbuagS2i1DQtmzHtSoxZF/kqR1mN1+VrnORwQ=; b=bB4ceh2fsFCmKM/tNhSVxCgo91DCMISMOr8kIGU9hWRUK/xTBhpr08KMT5kN2o+OEVMqNZP+XZwaCkk3NqFh3nzHYDPC4puR8QAfQgbjKJxP57gGMVPBbh9zFH3frQ2EOyErmyX8DlwgB6958vNySQF3+2FtGAxpB3ErZa/6CtM= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.19; Sun, 24 Mar 2019 09:13:57 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1730.019; Sun, 24 Mar 2019 09:13:57 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Thread-Index: AQHU373ahWqBWAolkE6SsDxba4lis6YV/mIwgAAiOQCABGKBwA== Date: Sun, 24 Mar 2019 09:13:57 +0000 Message-ID: References: <1551376985-11096-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-15-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6069ae5d-11f9-4869-5e61-08d6b0390b8e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-forefront-prvs: 09860C2161 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(316002)(26005)(2906002)(102836004)(5660300002)(52536014)(7736002)(186003)(446003)(256004)(33656002)(76176011)(105586002)(7696005)(6436002)(106356001)(66066001)(305945005)(81156014)(81166006)(486006)(97736004)(99286004)(8676002)(11346002)(74316002)(476003)(6506007)(229853002)(8936002)(110136005)(86362001)(14454004)(53936002)(3846002)(55016002)(478600001)(2501003)(6116002)(9686003)(6246003)(93886005)(25786009)(68736007)(71190400001)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GCQ5DLYR16BlWqoPVr9k5v094KI4kllwsqVhZAjYeCo6XrLnC5YY6fEgMp8I+8JJ+p8QcIv9zLET4LBF0nS5nHf8qYL1SxK9dmRkJlQEJltUnoXCJpVwOh1IbQkuGL5RSW1a1vR2QhDhHojc5feFlNhf9C1qPnFAL5dx+ayb9TAejq4Z2cLMch/e6vn3EpNpTo3xwerdUfTNUN+mQGcJltQ4Q0Bm4TvCsjJEZ9r69dXVqLmRpEyGypC1aHquq4PP10netgIeqUpboZMABwHk2JicKWyI+I0G/K65hjPCLeB0/6Dpdfgl6LMbcfc1tlOOJVOr3CxEivQhUQmqbcrrs8Jcq+FrJ9A5NWLuNO3JzRCguKgxgYtB88Hw2QW6KmC43m9y39OdB86bnBr54ml6EeFPmCjH0Rl7xxb6Ov9wHdY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6069ae5d-11f9-4869-5e61-08d6b0390b8e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2019 09:13:57.1546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 09:13:58 -0000 Thursday, March 21, 2019 4:12 PM, Slava Ovsiienko: > Subject: RE: [PATCH 14/14] net/mlx5: add source vport match to the ingres= s > rules > > > > > > Signed-off-by: Viacheslav Ovsiienko [...] > > > + flow_dv_translate_source_vport(matcher.mask.buf, > > > + dev_flow->dv.value.buf, > > > + priv->representor_id < 0 ? > > > + priv->representor_id : > > > + priv->representor_id + 1, > > > > The vport of representor_id 0 will be 1? > > Who owns vport 0? >=20 > PF. > There is the foillowing vport mapping (for single E-Switch per PF): >=20 > -1 - wire Wire, i.e. the uplink representor. indeed it's index is defined by PRM to -= 1. > 0 - PF (uplink + VF reps) I don't understand this part. When you have uplink representor you don't ha= ve PF. Moreover, I would expect the first representor created to have vport_num=3D= 0 (w/ name pf0vf0). Isn't it the case?=20 > 1 - VF0 > 2 - VF1 > ... > n+1 - VFn >=20 > This code is subject to change - (SF, multi E-Switch per function, etc), = this > patch currently supports single E-Switch per PF. >=20 > > > > > + 0xffff); > > > + } > > > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > > > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > > > void *match_mask =3D matcher.mask.buf; > > > -- > > > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B604CA05D3 for ; Sun, 24 Mar 2019 10:14:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6567F1B1F2; Sun, 24 Mar 2019 10:14:00 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by dpdk.org (Postfix) with ESMTP id 8C1455F36 for ; Sun, 24 Mar 2019 10:13:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z9ln16tbuagS2i1DQtmzHtSoxZF/kqR1mN1+VrnORwQ=; b=bB4ceh2fsFCmKM/tNhSVxCgo91DCMISMOr8kIGU9hWRUK/xTBhpr08KMT5kN2o+OEVMqNZP+XZwaCkk3NqFh3nzHYDPC4puR8QAfQgbjKJxP57gGMVPBbh9zFH3frQ2EOyErmyX8DlwgB6958vNySQF3+2FtGAxpB3ErZa/6CtM= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.19; Sun, 24 Mar 2019 09:13:57 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1730.019; Sun, 24 Mar 2019 09:13:57 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Thread-Index: AQHU373ahWqBWAolkE6SsDxba4lis6YV/mIwgAAiOQCABGKBwA== Date: Sun, 24 Mar 2019 09:13:57 +0000 Message-ID: References: <1551376985-11096-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-15-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6069ae5d-11f9-4869-5e61-08d6b0390b8e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-forefront-prvs: 09860C2161 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39850400004)(396003)(136003)(366004)(199004)(189003)(316002)(26005)(2906002)(102836004)(5660300002)(52536014)(7736002)(186003)(446003)(256004)(33656002)(76176011)(105586002)(7696005)(6436002)(106356001)(66066001)(305945005)(81156014)(81166006)(486006)(97736004)(99286004)(8676002)(11346002)(74316002)(476003)(6506007)(229853002)(8936002)(110136005)(86362001)(14454004)(53936002)(3846002)(55016002)(478600001)(2501003)(6116002)(9686003)(6246003)(93886005)(25786009)(68736007)(71190400001)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: GCQ5DLYR16BlWqoPVr9k5v094KI4kllwsqVhZAjYeCo6XrLnC5YY6fEgMp8I+8JJ+p8QcIv9zLET4LBF0nS5nHf8qYL1SxK9dmRkJlQEJltUnoXCJpVwOh1IbQkuGL5RSW1a1vR2QhDhHojc5feFlNhf9C1qPnFAL5dx+ayb9TAejq4Z2cLMch/e6vn3EpNpTo3xwerdUfTNUN+mQGcJltQ4Q0Bm4TvCsjJEZ9r69dXVqLmRpEyGypC1aHquq4PP10netgIeqUpboZMABwHk2JicKWyI+I0G/K65hjPCLeB0/6Dpdfgl6LMbcfc1tlOOJVOr3CxEivQhUQmqbcrrs8Jcq+FrJ9A5NWLuNO3JzRCguKgxgYtB88Hw2QW6KmC43m9y39OdB86bnBr54ml6EeFPmCjH0Rl7xxb6Ov9wHdY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6069ae5d-11f9-4869-5e61-08d6b0390b8e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2019 09:13:57.1546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190324091357.1s5qXs_cjQNJy5NR-ssBxek9_1gaU5s_6edjltWz3YE@z> Thursday, March 21, 2019 4:12 PM, Slava Ovsiienko: > Subject: RE: [PATCH 14/14] net/mlx5: add source vport match to the ingres= s > rules > > > > > > Signed-off-by: Viacheslav Ovsiienko [...] > > > + flow_dv_translate_source_vport(matcher.mask.buf, > > > + dev_flow->dv.value.buf, > > > + priv->representor_id < 0 ? > > > + priv->representor_id : > > > + priv->representor_id + 1, > > > > The vport of representor_id 0 will be 1? > > Who owns vport 0? >=20 > PF. > There is the foillowing vport mapping (for single E-Switch per PF): >=20 > -1 - wire Wire, i.e. the uplink representor. indeed it's index is defined by PRM to -= 1. > 0 - PF (uplink + VF reps) I don't understand this part. When you have uplink representor you don't ha= ve PF. Moreover, I would expect the first representor created to have vport_num=3D= 0 (w/ name pf0vf0). Isn't it the case?=20 > 1 - VF0 > 2 - VF1 > ... > n+1 - VFn >=20 > This code is subject to change - (SF, multi E-Switch per function, etc), = this > patch currently supports single E-Switch per PF. >=20 > > > > > + 0xffff); > > > + } > > > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > > > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > > > void *match_mask =3D matcher.mask.buf; > > > -- > > > 1.8.3.1