From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42]) by dpdk.org (Postfix) with ESMTP id E3C49293B for ; Wed, 8 May 2019 06:43:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6SGMvdwWxAwTpMvg1cxkbhRvuqejlgqTmjl38BJplIU=; b=Ld7s/wr6xhlBcyMSpW+AzxqDtHa/Zddu/jPx72/6I4KBRoyN/NoNR2t+8Nwgu+bHWzyjPnI4FvI+dYnHpu95iPBFcvJmffXnaaOZ4MhPlCIHKROOYRfaJHIIfVu0fG7AK5Cthx8Z6yf0WEsxYnFatz1QcplfJgbKDk8+TwaN2Bw= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:43:46 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:43:46 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Thread-Index: AQHVA0QsunEKrz7aX0yBoNAj04R5/qZgpRaw Date: Wed, 8 May 2019 04:43:45 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bff10650-0d4d-4873-19c1-08d6d36fc17a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KvMzpxFSGRd6ndPlHkbGakeH1IJA5tZinjv8ZR0nKlABFl42J1faZDHQyVA7IIzvBbd54jA+TaiYbsktMbZ535EZ1capmDt9BiG7iRGDW8eEKGQ9r+b23M7nJmMZqr5XlhavdYBVovKikewQhAvthubkdLec4CaAK3kozYyz+bwRqzNJddjibjwXCb+tXz8wVVO6NK8HxuOuLQWtkyeW7tqJ6sV3iXq6AMYWi6mt20DQJyaFd5GSalEdhbbcErwYa7zV5WDs+1s5gbhEDpP4ApKwOroSMyO6PC+/kdoJCepYLcM6Ykp5vsCUAWgoNDjxbKdO1GWM7rwflXBAN5RJrzlWQUO1RBaLYJ3Uh/3Za1otLF6Ib1rPmrZWeeacBd8gCKBz23g1HUUp8zMz7vjZbX/YrLMMZoqVSK202aowBf4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bff10650-0d4d-4873-19c1-08d6d36fc17a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:43:45.9279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 04:43:47 -0000 Dekel, Sunday, May 5, 2019 4:09 PM, Dekel Peled: > Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files >=20 > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. >=20 > --- > v2: Change 2nd patch type to "fix". > v3: Apply minor code-review comment on 2nd patch. > Add Acked-by in all patches. > --- I was trying to apply your patch but hit clang compilation issue, please ad= dress: error: static function 'mlx5_check_mprq_support' is used in an inline function with external= linkage [-Werror,-Wstatic-in-inline] if (mlx5_check_mprq_support(dev) < 0) ^ /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxtx.= h:248:1: note: use 'static' to give inline function 'mlx5_mprq_enabled' internal linkage int mlx5_mprq_enabled(struct rte_eth_dev *dev); ^ static=20 /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxq.c= :69:1: note: 'mlx5_check_mprq_support' declared here mlx5_check_mprq_support(struct rte_eth_dev *dev) >=20 > Dekel Peled (4): > net/mlx5: remove unused functions > net/mlx5: fix missing validation of null pointer > net/mlx5: fix description of function return value > net/mlx5: move locally used functions to static >=20 > drivers/net/mlx5/mlx5_rxq.c | 220 +++++++++++++++++++------------------= - > ----- > drivers/net/mlx5/mlx5_rxtx.h | 20 ---- drivers/net/mlx5/mlx5_txq.c | = 13 -- > - > 3 files changed, 95 insertions(+), 158 deletions(-) >=20 > -- > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1DDC6A0096 for ; Wed, 8 May 2019 06:43:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E44A52B87; Wed, 8 May 2019 06:43:47 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42]) by dpdk.org (Postfix) with ESMTP id E3C49293B for ; Wed, 8 May 2019 06:43:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6SGMvdwWxAwTpMvg1cxkbhRvuqejlgqTmjl38BJplIU=; b=Ld7s/wr6xhlBcyMSpW+AzxqDtHa/Zddu/jPx72/6I4KBRoyN/NoNR2t+8Nwgu+bHWzyjPnI4FvI+dYnHpu95iPBFcvJmffXnaaOZ4MhPlCIHKROOYRfaJHIIfVu0fG7AK5Cthx8Z6yf0WEsxYnFatz1QcplfJgbKDk8+TwaN2Bw= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:43:46 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:43:46 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files Thread-Index: AQHVA0QsunEKrz7aX0yBoNAj04R5/qZgpRaw Date: Wed, 8 May 2019 04:43:45 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bff10650-0d4d-4873-19c1-08d6d36fc17a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: KvMzpxFSGRd6ndPlHkbGakeH1IJA5tZinjv8ZR0nKlABFl42J1faZDHQyVA7IIzvBbd54jA+TaiYbsktMbZ535EZ1capmDt9BiG7iRGDW8eEKGQ9r+b23M7nJmMZqr5XlhavdYBVovKikewQhAvthubkdLec4CaAK3kozYyz+bwRqzNJddjibjwXCb+tXz8wVVO6NK8HxuOuLQWtkyeW7tqJ6sV3iXq6AMYWi6mt20DQJyaFd5GSalEdhbbcErwYa7zV5WDs+1s5gbhEDpP4ApKwOroSMyO6PC+/kdoJCepYLcM6Ykp5vsCUAWgoNDjxbKdO1GWM7rwflXBAN5RJrzlWQUO1RBaLYJ3Uh/3Za1otLF6Ib1rPmrZWeeacBd8gCKBz23g1HUUp8zMz7vjZbX/YrLMMZoqVSK202aowBf4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: bff10650-0d4d-4873-19c1-08d6d36fc17a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:43:45.9279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508044345.TQmnR-rnW3PomNcPTWGpFs5MHfXh_TCHVldrBTRpWK8@z> Dekel, Sunday, May 5, 2019 4:09 PM, Dekel Peled: > Subject: [PATCH v3 0/4] net/mlx5: code cleanup in rx and tx files >=20 > During work on Rx feature I did some cleanup actions. > This series includes those changes divided by their type. >=20 > --- > v2: Change 2nd patch type to "fix". > v3: Apply minor code-review comment on 2nd patch. > Add Acked-by in all patches. > --- I was trying to apply your patch but hit clang compilation issue, please ad= dress: error: static function 'mlx5_check_mprq_support' is used in an inline function with external= linkage [-Werror,-Wstatic-in-inline] if (mlx5_check_mprq_support(dev) < 0) ^ /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxtx.= h:248:1: note: use 'static' to give inline function 'mlx5_mprq_enabled' internal linkage int mlx5_mprq_enabled(struct rte_eth_dev *dev); ^ static=20 /.autodirect/swgwork/shahafs/workspace/dpdk.org/drivers/net/mlx5/mlx5_rxq.c= :69:1: note: 'mlx5_check_mprq_support' declared here mlx5_check_mprq_support(struct rte_eth_dev *dev) >=20 > Dekel Peled (4): > net/mlx5: remove unused functions > net/mlx5: fix missing validation of null pointer > net/mlx5: fix description of function return value > net/mlx5: move locally used functions to static >=20 > drivers/net/mlx5/mlx5_rxq.c | 220 +++++++++++++++++++------------------= - > ----- > drivers/net/mlx5/mlx5_rxtx.h | 20 ---- drivers/net/mlx5/mlx5_txq.c | = 13 -- > - > 3 files changed, 95 insertions(+), 158 deletions(-) >=20 > -- > 1.8.3.1