DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Ori Kam <orika@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>,
	Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules
Date: Wed, 8 May 2019 04:44:22 +0000	[thread overview]
Message-ID: <AM0PR0502MB3795A13199EE9BB23701B8AEC3320@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1557236494-4808-1-git-send-email-orika@mellanox.com>

Tuesday, May 7, 2019 4:42 PM, Ori Kam:
> Subject: [PATCH] net/mlx5: fix errno in case of unsupported Direct Rules
> 
> When Direct Rules API is not supported we don't set the errno.
> this results in failing the function but with errno equals to zero.
> The result of this is that a function that failed, is considered as a function that
> worked correctly.
> 
> This commit fixes this issue by setting the errno to ENOTSUP and returning
> this error when error value should be returned.
> 
> Since RDMA-CORE are returning positive errno we are also returning positive
> error values.
> 
> Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API")
> 
> Signed-off-by: Ori Kam <orika@mellanox.com>

Applied to next-net-mlx, thanks. 

  parent reply	other threads:[~2019-05-08  4:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:41 Ori Kam
2019-05-07 13:41 ` Ori Kam
2019-05-08  4:44 ` Shahaf Shuler [this message]
2019-05-08  4:44   ` Shahaf Shuler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR0502MB3795A13199EE9BB23701B8AEC3320@AM0PR0502MB3795.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).