From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) by dpdk.org (Postfix) with ESMTP id 204294CC0 for ; Mon, 8 Apr 2019 08:00:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XBuSBhIIaLaTWJ3T3RXz60PnpxeQvSysVdGxOLuYlgA=; b=Ml767EY/5VsOdbHpQPPH0se9SZ03YJPUofr7OyV2t0qQDO+TDqjrvPqxqZyFKdRIB/wLk1ELhTwDoGWqxECSFN02wtlslUfkxk6X2Rk1O26hDldwpeUs58UB+WcLlCWBt43ZK7Mic6dgr91lZAuglkVD8gJmdpr05effFNnHbok= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3745.eurprd05.prod.outlook.com (52.133.50.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Mon, 8 Apr 2019 06:00:15 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Mon, 8 Apr 2019 06:00:15 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy order Thread-Index: AQHU67OSo6uGPDjle0GMS88SXWlowKYxyNgg Date: Mon, 8 Apr 2019 06:00:15 +0000 Message-ID: References: <1554300897-24032-1-git-send-email-viacheslavo@mellanox.com> <1554470945-14357-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1554470945-14357-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da4e104f-f2eb-4897-2ca5-08d6bbe77872 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3745; x-ms-traffictypediagnostic: AM0PR0502MB3745: x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(86362001)(66066001)(229853002)(99286004)(305945005)(76176011)(97736004)(8936002)(25786009)(7696005)(6506007)(256004)(52536014)(26005)(478600001)(2906002)(14454004)(186003)(6436002)(33656002)(6246003)(5660300002)(106356001)(102836004)(105586002)(7736002)(110136005)(55016002)(486006)(53936002)(9686003)(316002)(74316002)(81166006)(2501003)(14444005)(71200400001)(71190400001)(11346002)(4744005)(476003)(3846002)(6116002)(446003)(81156014)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3745; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ER/+EwhpNlBQ2tKCrFp+Kc57aH4RrosHHxeJnJg/yBq6LDXmk0OM6pHlF82sPTOqlkAmzf80bf1bVebnQek0T3TOGzaLeyktVZxwI2bAIlgk2KpixNE6LrlA3e8RyxwUJD32pa8qfRCqYTJJQC1jjOaOVPE3nYnwWImDchRgIlnIVuVwrFRZOQyoB2I0VFuOvH4caDov/dCAWHX9GU/cTQsx4lZOYJB3nBk65t/reFROM70b5apYW5YjXv5DwGatSPvtDV69gyU11Dy1w9dPz5Kipg39/a8q6bTczf721sIBlC5fj3iFmQ3RBODM3mYmZgRUsuaqRJYpE8KtnDyxzEZEapeHVsI0OJrkb5A4trszxcQ4m+OcfMkD/1KkiH3e3NHOtb5RvDO5KZyx6f5rm33Uf4YlMxUfN6Od6Mw+sPk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: da4e104f-f2eb-4897-2ca5-08d6bbe77872 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 06:00:15.0410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 06:00:16 -0000 Friday, April 5, 2019 4:29 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy > order >=20 > At the mlx5 device closing the shared IB context was destroyed before > cleanup routines completion. As it was found on some setups (Netlink fail= s > with old kernel drivers and we have to use sysfs to retrieve interface in= dex, > this requires IB device name, which is stored in shared context) the > mlx5_nl_mac_addr_flush() requires IB device name, and if shared context i= s > removed it causes the segmentation fault. >=20 > Fixes: 17e19bc4dde7 ("net/mlx5: add IB shared context alloc/free function= s") >=20 > Signed-off-by: Viacheslav Ovsiienko Applied to next-net-mlx, thanks.=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0995AA0096 for ; Mon, 8 Apr 2019 08:00:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B3B164CC7; Mon, 8 Apr 2019 08:00:19 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30040.outbound.protection.outlook.com [40.107.3.40]) by dpdk.org (Postfix) with ESMTP id 204294CC0 for ; Mon, 8 Apr 2019 08:00:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XBuSBhIIaLaTWJ3T3RXz60PnpxeQvSysVdGxOLuYlgA=; b=Ml767EY/5VsOdbHpQPPH0se9SZ03YJPUofr7OyV2t0qQDO+TDqjrvPqxqZyFKdRIB/wLk1ELhTwDoGWqxECSFN02wtlslUfkxk6X2Rk1O26hDldwpeUs58UB+WcLlCWBt43ZK7Mic6dgr91lZAuglkVD8gJmdpr05effFNnHbok= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3745.eurprd05.prod.outlook.com (52.133.50.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.16; Mon, 8 Apr 2019 06:00:15 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::4192:b468:41e1:c323%4]) with mapi id 15.20.1771.011; Mon, 8 Apr 2019 06:00:15 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy order Thread-Index: AQHU67OSo6uGPDjle0GMS88SXWlowKYxyNgg Date: Mon, 8 Apr 2019 06:00:15 +0000 Message-ID: References: <1554300897-24032-1-git-send-email-viacheslavo@mellanox.com> <1554470945-14357-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1554470945-14357-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: da4e104f-f2eb-4897-2ca5-08d6bbe77872 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3745; x-ms-traffictypediagnostic: AM0PR0502MB3745: x-microsoft-antispam-prvs: x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(346002)(366004)(396003)(136003)(199004)(189003)(86362001)(66066001)(229853002)(99286004)(305945005)(76176011)(97736004)(8936002)(25786009)(7696005)(6506007)(256004)(52536014)(26005)(478600001)(2906002)(14454004)(186003)(6436002)(33656002)(6246003)(5660300002)(106356001)(102836004)(105586002)(7736002)(110136005)(55016002)(486006)(53936002)(9686003)(316002)(74316002)(81166006)(2501003)(14444005)(71200400001)(71190400001)(11346002)(4744005)(476003)(3846002)(6116002)(446003)(81156014)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3745; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ER/+EwhpNlBQ2tKCrFp+Kc57aH4RrosHHxeJnJg/yBq6LDXmk0OM6pHlF82sPTOqlkAmzf80bf1bVebnQek0T3TOGzaLeyktVZxwI2bAIlgk2KpixNE6LrlA3e8RyxwUJD32pa8qfRCqYTJJQC1jjOaOVPE3nYnwWImDchRgIlnIVuVwrFRZOQyoB2I0VFuOvH4caDov/dCAWHX9GU/cTQsx4lZOYJB3nBk65t/reFROM70b5apYW5YjXv5DwGatSPvtDV69gyU11Dy1w9dPz5Kipg39/a8q6bTczf721sIBlC5fj3iFmQ3RBODM3mYmZgRUsuaqRJYpE8KtnDyxzEZEapeHVsI0OJrkb5A4trszxcQ4m+OcfMkD/1KkiH3e3NHOtb5RvDO5KZyx6f5rm33Uf4YlMxUfN6Od6Mw+sPk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: da4e104f-f2eb-4897-2ca5-08d6bbe77872 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 06:00:15.0410 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: Re: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190408060015.51TNfLXCT_nO83I4MLRpSUSQmiKAtQZzShG3EjZ933o@z> Friday, April 5, 2019 4:29 PM, Viacheslav Ovsiienko: > Subject: [dpdk-dev] [PATCH v2 1/1] net/mlx5: fix sharing context destroy > order >=20 > At the mlx5 device closing the shared IB context was destroyed before > cleanup routines completion. As it was found on some setups (Netlink fail= s > with old kernel drivers and we have to use sysfs to retrieve interface in= dex, > this requires IB device name, which is stored in shared context) the > mlx5_nl_mac_addr_flush() requires IB device name, and if shared context i= s > removed it causes the segmentation fault. >=20 > Fixes: 17e19bc4dde7 ("net/mlx5: add IB shared context alloc/free function= s") >=20 > Signed-off-by: Viacheslav Ovsiienko Applied to next-net-mlx, thanks.=20