* Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error
[not found] <1559200565-15703-1-git-send-email-matan@mellanox.com>
@ 2019-06-11 18:29 ` Shahaf Shuler
0 siblings, 0 replies; 4+ messages in thread
From: Shahaf Shuler @ 2019-06-11 18:29 UTC (permalink / raw)
To: Matan Azrad, Yongseok Koh; +Cc: dev, Matan Azrad
Thursday, May 30, 2019 10:16 AM, Matan Azrad:
> Cc: dev@dpdk.org; Matan Azrad <matan@mellanox.com>
> Subject: [PATCH v1 0/9] mlx5: Handle data-path completions with error
>
> Add support for data-path Rx and Tx completions with error handling:
>
> 1. Detect the error.
> 2. Do not crash.
> 3. Report it in statistics counters.
> 4. Dump debug information to system log file.
> 5. Recover the error under the hood.
> 6. Add support for secondary process recovery.
>
> No performance impact was shown.
>
> Matan Azrad (9):
> net/mlx5: remove Rx queues indexes correlation
> net/mlx5: add log file procedure for debug data
> net/mlx5: fix device arguments error detection
> net/mlx5: mitigate Rx doorbell memory barrier
> net/mlx5: separate Rx queue initialization
> net/mlx5: extend Rx completion with error handling
> net/mlx5: handle Tx completion with error
> net/mlx5: recover secondary process Rx errors
> net/mlx5: recover secondary process Tx errors
>
> doc/guides/nics/mlx5.rst | 7 +
> drivers/net/mlx5/mlx5.c | 14 +-
> drivers/net/mlx5/mlx5.h | 12 +
> drivers/net/mlx5/mlx5_mp.c | 46 +++
> drivers/net/mlx5/mlx5_prm.h | 11 +
> drivers/net/mlx5/mlx5_rxq.c | 42 +--
> drivers/net/mlx5/mlx5_rxtx.c | 673
> ++++++++++++++++++++++++++++------
> drivers/net/mlx5/mlx5_rxtx.h | 193 +++++-----
> drivers/net/mlx5/mlx5_rxtx_vec.c | 5 +-
> drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +-
> drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 36 +-
> drivers/net/mlx5/mlx5_trigger.c | 1 +
> drivers/net/mlx5/mlx5_txq.c | 4 +-
> 13 files changed, 792 insertions(+), 288 deletions(-)
Applied to next-net-mlx, thanks.
>
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error
@ 2019-05-30 10:20 Matan Azrad
2019-09-12 12:14 ` Kevin Traynor
0 siblings, 1 reply; 4+ messages in thread
From: Matan Azrad @ 2019-05-30 10:20 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: dev
Add support for data-path Rx and Tx completions with error handling:
1. Detect the error.
2. Do not crash.
3. Report it in statistics counters.
4. Dump debug information to system log file.
5. Recover the error under the hood.
6. Add support for secondary process recovery.
No performance impact was shown.
Matan Azrad (9):
net/mlx5: remove Rx queues indexes correlation
net/mlx5: add log file procedure for debug data
net/mlx5: fix device arguments error detection
net/mlx5: mitigate Rx doorbell memory barrier
net/mlx5: separate Rx queue initialization
net/mlx5: extend Rx completion with error handling
net/mlx5: handle Tx completion with error
net/mlx5: recover secondary process Rx errors
net/mlx5: recover secondary process Tx errors
doc/guides/nics/mlx5.rst | 7 +
drivers/net/mlx5/mlx5.c | 14 +-
drivers/net/mlx5/mlx5.h | 12 +
drivers/net/mlx5/mlx5_mp.c | 46 +++
drivers/net/mlx5/mlx5_prm.h | 11 +
drivers/net/mlx5/mlx5_rxq.c | 42 +--
drivers/net/mlx5/mlx5_rxtx.c | 673 ++++++++++++++++++++++++++++------
drivers/net/mlx5/mlx5_rxtx.h | 193 +++++-----
drivers/net/mlx5/mlx5_rxtx_vec.c | 5 +-
drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +-
drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 36 +-
drivers/net/mlx5/mlx5_trigger.c | 1 +
drivers/net/mlx5/mlx5_txq.c | 4 +-
13 files changed, 792 insertions(+), 288 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error
2019-05-30 10:20 Matan Azrad
@ 2019-09-12 12:14 ` Kevin Traynor
2019-09-22 7:03 ` Matan Azrad
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Traynor @ 2019-09-12 12:14 UTC (permalink / raw)
To: Matan Azrad, Shahaf Shuler, Yongseok Koh; +Cc: dev
On 30/05/2019 11:20, Matan Azrad wrote:
> Add support for data-path Rx and Tx completions with error handling:
>
> 1. Detect the error.
> 2. Do not crash.
> 3. Report it in statistics counters.
> 4. Dump debug information to system log file.
> 5. Recover the error under the hood.
> 6. Add support for secondary process recovery.
>
> No performance impact was shown.
>
> Matan Azrad (9):
> net/mlx5: remove Rx queues indexes correlation
> net/mlx5: add log file procedure for debug data
> net/mlx5: fix device arguments error detection
> net/mlx5: mitigate Rx doorbell memory barrier
> net/mlx5: separate Rx queue initialization
> net/mlx5: extend Rx completion with error handling
> net/mlx5: handle Tx completion with error
> net/mlx5: recover secondary process Rx errors
> net/mlx5: recover secondary process Tx errors
>
> doc/guides/nics/mlx5.rst | 7 +
> drivers/net/mlx5/mlx5.c | 14 +-
> drivers/net/mlx5/mlx5.h | 12 +
> drivers/net/mlx5/mlx5_mp.c | 46 +++
> drivers/net/mlx5/mlx5_prm.h | 11 +
> drivers/net/mlx5/mlx5_rxq.c | 42 +--
> drivers/net/mlx5/mlx5_rxtx.c | 673 ++++++++++++++++++++++++++++------
> drivers/net/mlx5/mlx5_rxtx.h | 193 +++++-----
> drivers/net/mlx5/mlx5_rxtx_vec.c | 5 +-
> drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +-
> drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 36 +-
> drivers/net/mlx5/mlx5_trigger.c | 1 +
> drivers/net/mlx5/mlx5_txq.c | 4 +-
> 13 files changed, 792 insertions(+), 288 deletions(-)
>
Hi - these changes are very invasive ^^^. I'm not really comfortable to
take this for 18.11.3. See
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
I will take patch 3/9 as it is a fix with Fixes: tag.
thanks,
Kevin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error
2019-09-12 12:14 ` Kevin Traynor
@ 2019-09-22 7:03 ` Matan Azrad
0 siblings, 0 replies; 4+ messages in thread
From: Matan Azrad @ 2019-09-22 7:03 UTC (permalink / raw)
To: Kevin Traynor, Shahaf Shuler; +Cc: dev
From: Kevin Traynor
> On 30/05/2019 11:20, Matan Azrad wrote:
> > Add support for data-path Rx and Tx completions with error handling:
> >
> > 1. Detect the error.
> > 2. Do not crash.
> > 3. Report it in statistics counters.
> > 4. Dump debug information to system log file.
> > 5. Recover the error under the hood.
> > 6. Add support for secondary process recovery.
> >
> > No performance impact was shown.
> >
> > Matan Azrad (9):
> > net/mlx5: remove Rx queues indexes correlation
> > net/mlx5: add log file procedure for debug data
> > net/mlx5: fix device arguments error detection
> > net/mlx5: mitigate Rx doorbell memory barrier
> > net/mlx5: separate Rx queue initialization
> > net/mlx5: extend Rx completion with error handling
> > net/mlx5: handle Tx completion with error
> > net/mlx5: recover secondary process Rx errors
> > net/mlx5: recover secondary process Tx errors
> >
> > doc/guides/nics/mlx5.rst | 7 +
> > drivers/net/mlx5/mlx5.c | 14 +-
> > drivers/net/mlx5/mlx5.h | 12 +
> > drivers/net/mlx5/mlx5_mp.c | 46 +++
> > drivers/net/mlx5/mlx5_prm.h | 11 +
> > drivers/net/mlx5/mlx5_rxq.c | 42 +--
> > drivers/net/mlx5/mlx5_rxtx.c | 673
> ++++++++++++++++++++++++++++------
> > drivers/net/mlx5/mlx5_rxtx.h | 193 +++++-----
> > drivers/net/mlx5/mlx5_rxtx_vec.c | 5 +-
> > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 36 +-
> > drivers/net/mlx5/mlx5_rxtx_vec_sse.h | 36 +-
> > drivers/net/mlx5/mlx5_trigger.c | 1 +
> > drivers/net/mlx5/mlx5_txq.c | 4 +-
> > 13 files changed, 792 insertions(+), 288 deletions(-)
> >
>
>
> Hi - these changes are very invasive ^^^. I'm not really comfortable to take
> this for 18.11.3. See
> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdoc.d
> pdk.org%2Fguides%2Fcontributing%2Fstable.html%23what-changes-should-
> be-
> backported&data=02%7C01%7Cmatan%40mellanox.com%7Cf8c9305dc6
> 7b4e7b128008d7377ad4f9%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C
> 0%7C637038873031127944&sdata=HAm39aLCoHz59wauVmglWrq5fwnM
> 3ZtLV0%2FebrZHiLY%3D&reserved=0
>
> I will take patch 3/9 as it is a fix with Fixes: tag.
It's ok, the others are not must in this version.
>
> thanks,
> Kevin.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-22 7:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1559200565-15703-1-git-send-email-matan@mellanox.com>
2019-06-11 18:29 ` [dpdk-dev] [PATCH v1 0/9] mlx5: Handle data-path completions with error Shahaf Shuler
2019-05-30 10:20 Matan Azrad
2019-09-12 12:14 ` Kevin Traynor
2019-09-22 7:03 ` Matan Azrad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).