From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id 92F132C36 for ; Tue, 2 Apr 2019 07:32:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxali65c7jUyjGR+BRLjp03mSpoLNnm5pQW0ZB7FZFM=; b=R0tOuvQq1aNYHZ/WmdjysPu5ruDLjNeUnYQEljjKv1oICADDlXuoBgrbXh16ZF2XEHqZQRlbPLEkb9ZQIMexCj95go3F5NGWxsrWPDFDLkc/Kdp6gi0Txye0yhGJsVHRw5jxLX2CV1Q4V+Vi2Fd9Bp4/MKnCSDWNzilIgM6Q1qY= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4034.eurprd05.prod.outlook.com (52.133.41.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 05:32:55 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 05:32:55 +0000 From: Shahaf Shuler To: Ori Kam , Matan Azrad , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: update counter API for upstream Thread-Index: AQHU6J92Rwis6tZNpUik7rG7SD6M+qYoT2LQgAAHt0CAAAJzoA== Date: Tue, 2 Apr 2019 05:32:55 +0000 Message-ID: References: <1554132458-176151-1-git-send-email-orika@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b79aff0-ee0a-49cf-7c9b-08d6b72ca881 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB4034; x-ms-traffictypediagnostic: AM0PR0502MB4034: x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(396003)(366004)(346002)(199004)(189003)(13464003)(102836004)(5660300002)(6506007)(476003)(6116002)(3846002)(446003)(478600001)(8676002)(106356001)(11346002)(86362001)(256004)(14444005)(7696005)(26005)(99286004)(25786009)(52536014)(53546011)(186003)(71190400001)(71200400001)(316002)(4326008)(4744005)(486006)(110136005)(9686003)(6636002)(55016002)(66066001)(97736004)(74316002)(2906002)(68736007)(33656002)(6436002)(7736002)(81166006)(81156014)(8936002)(305945005)(14454004)(53936002)(229853002)(76176011)(105586002)(6246003)(15650500001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4034; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YcdQkA6pBb93uVDV60DIOEWDGdyfEW1tjoZmjPN+X5i91XVB59IOwnbt17neQAWxoolrhqIE+NfMz9Jwb+GPojdq4FkndUxXuW1TthgryV7HtUcfZjdEpwZzRVQLL4lQuyH7cw4UrtItmK1rwJ5AqQdKRUdYrTn2r6RM3df+eneAo3WpG2V80lYROxlWJiktxFAOwdVPKrn7/YiwqXzIKOLx2B5z2W5YsOym8Op71j9DRS3jSx3ouD9xNWorfPoNfit/0n6S/FLBrP8Filsdjq+gAxhM6rCmFtOTBqgsBcLC06L/TrUb+R4ogJ7Cbr/58XMGTAgnynQV5AZOeye6wxR9nRLx3UDiC/02w1HJ8XIJoriE2xz93vB2H992uiTlQTChUEEsFDrvIMROAlyl9bq99F4M213rTGgFou3Nqfg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b79aff0-ee0a-49cf-7c9b-08d6b72ca881 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 05:32:55.1735 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4034 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: update counter API for upstream X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 05:32:56 -0000 Tuesday, April 2, 2019 8:25 AM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: update counter API for upstream >=20 > Hi PSB >=20 > > -----Original Message----- > > From: Shahaf Shuler > > Sent: Tuesday, April 2, 2019 7:57 AM > > To: Ori Kam ; Matan Azrad > ; > > Yongseok Koh > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] net/mlx5: update counter API for upstream > > > > Hi Ori, > > > > Monday, April 1, 2019 6:28 PM, Ori Kam: > > > Subject: [PATCH] net/mlx5: update counter API for upstream > > > > This is not an update, this is a fix. >=20 > The reason that I don't think this is a fix since in the original commit = it was > stated that it is only for OFED 4.5 and in this case it is correct OFED c= hanged > the API. It is not an issue with the original commit. It is an issue w/ the previous commit, since it should not be accepted in f= irst place since it reference APIs which are not upstream.=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AF213A0679 for ; Tue, 2 Apr 2019 07:32:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC02A34F3; Tue, 2 Apr 2019 07:32:56 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id 92F132C36 for ; Tue, 2 Apr 2019 07:32:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxali65c7jUyjGR+BRLjp03mSpoLNnm5pQW0ZB7FZFM=; b=R0tOuvQq1aNYHZ/WmdjysPu5ruDLjNeUnYQEljjKv1oICADDlXuoBgrbXh16ZF2XEHqZQRlbPLEkb9ZQIMexCj95go3F5NGWxsrWPDFDLkc/Kdp6gi0Txye0yhGJsVHRw5jxLX2CV1Q4V+Vi2Fd9Bp4/MKnCSDWNzilIgM6Q1qY= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4034.eurprd05.prod.outlook.com (52.133.41.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.17; Tue, 2 Apr 2019 05:32:55 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::84f3:7e92:7a51:1003%2]) with mapi id 15.20.1750.014; Tue, 2 Apr 2019 05:32:55 +0000 From: Shahaf Shuler To: Ori Kam , Matan Azrad , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: update counter API for upstream Thread-Index: AQHU6J92Rwis6tZNpUik7rG7SD6M+qYoT2LQgAAHt0CAAAJzoA== Date: Tue, 2 Apr 2019 05:32:55 +0000 Message-ID: References: <1554132458-176151-1-git-send-email-orika@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b79aff0-ee0a-49cf-7c9b-08d6b72ca881 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR0502MB4034; x-ms-traffictypediagnostic: AM0PR0502MB4034: x-microsoft-antispam-prvs: x-forefront-prvs: 0995196AA2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(396003)(366004)(346002)(199004)(189003)(13464003)(102836004)(5660300002)(6506007)(476003)(6116002)(3846002)(446003)(478600001)(8676002)(106356001)(11346002)(86362001)(256004)(14444005)(7696005)(26005)(99286004)(25786009)(52536014)(53546011)(186003)(71190400001)(71200400001)(316002)(4326008)(4744005)(486006)(110136005)(9686003)(6636002)(55016002)(66066001)(97736004)(74316002)(2906002)(68736007)(33656002)(6436002)(7736002)(81166006)(81156014)(8936002)(305945005)(14454004)(53936002)(229853002)(76176011)(105586002)(6246003)(15650500001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4034; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: YcdQkA6pBb93uVDV60DIOEWDGdyfEW1tjoZmjPN+X5i91XVB59IOwnbt17neQAWxoolrhqIE+NfMz9Jwb+GPojdq4FkndUxXuW1TthgryV7HtUcfZjdEpwZzRVQLL4lQuyH7cw4UrtItmK1rwJ5AqQdKRUdYrTn2r6RM3df+eneAo3WpG2V80lYROxlWJiktxFAOwdVPKrn7/YiwqXzIKOLx2B5z2W5YsOym8Op71j9DRS3jSx3ouD9xNWorfPoNfit/0n6S/FLBrP8Filsdjq+gAxhM6rCmFtOTBqgsBcLC06L/TrUb+R4ogJ7Cbr/58XMGTAgnynQV5AZOeye6wxR9nRLx3UDiC/02w1HJ8XIJoriE2xz93vB2H992uiTlQTChUEEsFDrvIMROAlyl9bq99F4M213rTGgFou3Nqfg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b79aff0-ee0a-49cf-7c9b-08d6b72ca881 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2019 05:32:55.1735 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4034 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: update counter API for upstream X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402053255.EivnpGPp3fpkROEZxc6x9X5m6tZHVABmS5lR0OBhyBo@z> Tuesday, April 2, 2019 8:25 AM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: update counter API for upstream >=20 > Hi PSB >=20 > > -----Original Message----- > > From: Shahaf Shuler > > Sent: Tuesday, April 2, 2019 7:57 AM > > To: Ori Kam ; Matan Azrad > ; > > Yongseok Koh > > Cc: dev@dpdk.org > > Subject: RE: [PATCH] net/mlx5: update counter API for upstream > > > > Hi Ori, > > > > Monday, April 1, 2019 6:28 PM, Ori Kam: > > > Subject: [PATCH] net/mlx5: update counter API for upstream > > > > This is not an update, this is a fix. >=20 > The reason that I don't think this is a fix since in the original commit = it was > stated that it is only for OFED 4.5 and in this case it is correct OFED c= hanged > the API. It is not an issue with the original commit. It is an issue w/ the previous commit, since it should not be accepted in f= irst place since it reference APIs which are not upstream.=20