From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 07ED4A00E6 for ; Tue, 11 Jun 2019 20:29:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8FC671D051; Tue, 11 Jun 2019 20:29:12 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by dpdk.org (Postfix) with ESMTP id 3028D1D04F for ; Tue, 11 Jun 2019 20:29:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=whLG+sMwYxXVICg59dqOnxOlfnZTtES8j1Sko+jTupA=; b=Mb4S0pjn2KD4LXJPX9svOKBoYGcikZaqjxvm2ujIm7kXX0ZteVwk4XF7IeKzw9zrx7GZhiiqwnDTzGLGmPd2dNcJK3/R1VZwcbHcAC6ifyRKA7tkdgqMCiQWldxwlPCS3dAOQONWdj9p4cZdYTt9grVVuKE55Mwlfgp8YkhiXxM= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3602.eurprd05.prod.outlook.com (52.133.43.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.14; Tue, 11 Jun 2019 18:29:09 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::20f4:3214:12c9:100c]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::20f4:3214:12c9:100c%7]) with mapi id 15.20.1987.010; Tue, 11 Jun 2019 18:29:09 +0000 From: Shahaf Shuler To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix master device Netlink socket sharing Thread-Index: AQHVHGKbUmAFMgylDke8ukXSINUiF6aWYj/g Date: Tue, 11 Jun 2019 18:29:09 +0000 Message-ID: References: <1559823781-28220-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1559823781-28220-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9809727d-b754-4d7c-4335-08d6ee9ab1aa x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3602; x-ms-traffictypediagnostic: AM0PR0502MB3602: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 006546F32A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(396003)(376002)(346002)(189003)(199004)(8676002)(3846002)(81166006)(81156014)(26005)(478600001)(8936002)(68736007)(71200400001)(7736002)(6116002)(71190400001)(305945005)(99286004)(6506007)(229853002)(52536014)(5660300002)(256004)(6306002)(4744005)(9686003)(6436002)(6246003)(55016002)(25786009)(33656002)(14454004)(53936002)(110136005)(11346002)(476003)(966005)(76176011)(446003)(74316002)(186003)(316002)(73956011)(66946007)(7696005)(86362001)(76116006)(486006)(66476007)(66556008)(102836004)(66446008)(2501003)(2906002)(66066001)(64756008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3602; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: /FItQAp3TAqljtlviFCVqhOoV6QcMvlH8EAaO7Mtoog/CLf4wKQ+1IQtV6hOv84luscKXwrh+AJJfcuLkKxmUm3KsCEbEbrCeK+wf3AIF6aUh6TInQUjGH1u6SVMwqaZV7+aHnPojHirMHjZBI34wcpzU35ZXppWHgI+CuhfBJN3goD8mz5OColeGflHxh6XUoeZV82derLimdcnwFQ+54rJ5KAkEOVsZRAB2i/4OI3S/DrYR3dJWJo/EpMBpz3QIq82n5gE0jM8AYFd6Y1hQxQas3PzM2OQlrXxJmHp9GVMOCRl2twthF1Fqn+q8eVDrPfPtvYZNIGPMDq1VRPfbMgStfWhygWYHL4OTOmeKGTNssPErVfoCLm3fRBDrt6P5pafQRm026Jfoo6yVP9fBK/wVxq/zvmLVgK5lcjE9IM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9809727d-b754-4d7c-4335-08d6ee9ab1aa X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2019 18:29:09.1634 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shahafs@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3602 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix master device Netlink socket sharing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thursday, June 6, 2019 3:23 PM, Viacheslav Ovsiienko: > Subject: [PATCH] net/mlx5: fix master device Netlink socket sharing >=20 > There is the patch [1] that uses master device Netlink socket to retrieve > master device link settings. This is not thread safe because this resourc= e may > be in use by other call to the master device itself. Using the same Netli= nk > socket concurrently from the multiple threads causes Netlink requests > malfunction and must be eliminated. The patch replaces master Netlink > socket with the socket from representor device. >=20 > [1] http://patches.dpdk.org/patch/53120/ >=20 > Fixes: 0333b2f584d9 ("net/mlx5: inherit master link settings for > representors") > Signed-off-by: Viacheslav Ovsiienko Applied to next-net-mlx, thanks.=20