From: Shahaf Shuler <shahafs@mellanox.com>
To: "Damjan Marion (damarion)" <damarion@cisco.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, dev <dev@dpdk.org>,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping functions
Date: Sun, 27 Oct 2019 07:00:08 +0000 [thread overview]
Message-ID: <AM0PR0502MB3795EC4A369BDEDACB594CDDC3670@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <5980E9BB-2D78-43C5-890A-05B6BAC30071@cisco.com>
> -----Original Message-----
> From: Damjan Marion (damarion) <damarion@cisco.com>
> Sent: Friday, October 25, 2019 2:14 PM
> To: Thomas Monjalon <thomas@monjalon.net>
> Cc: David Marchand <david.marchand@redhat.com>; Anatoly Burakov
> <anatoly.burakov@intel.com>; Shahaf Shuler <shahafs@mellanox.com>; Ray
> Kinsella <mdr@ashroe.eu>; dev <dev@dpdk.org>; Neil Horman
> <nhorman@tuxdriver.com>; John McNamara <john.mcnamara@intel.com>;
> Marko Kovacevic <marko.kovacevic@intel.com>; Bruce Richardson
> <bruce.richardson@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] vfio: remove deprecated DMA mapping
> functions
>
>
>
> > On 25 Oct 2019, at 00:32, Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 24/10/2019 21:09, David Marchand:
> >> On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov
> >> <anatoly.burakov@intel.com> wrote:
> >>>
> >>> The rte_vfio_dma_map/unmap API's have been marked as deprecated
> in
> >>> release 19.05. Remove them.
> >>>
> >>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >>> ---
> >>>
> >>> Notes:
> >>> Although `rte_vfio_dma_map` et al. was marked as deprecated in our
> documentation,
> >>> it wasn't marked as __rte_deprecated in code. Should we still remove
> it?
> >>
> >> I can see that vpp is still using this api.
> >> I would prefer we get some ack from their side.
> >>
> >> Shahaf?
> >> Ray?
> >>
> >> Do you guys have contact with VPP devs?
> >
> > +Cc Damjan
>
> Thanks for looping me in. If I remember correctly that was used only to get
> mlx PMDs working.
> We can remove that calls but then mlx PMDs will stop working unless there is
> alternative solution.
>
> From my perspective it is not big issue as we already have native rdma based
> mlx support, but i would expect that other people will complain.
>
> Is there alternative way to tell DPDK about DMA mapping?
Damjan I don't follow.
Why would using the rte_dev_dma_map would break Mellanox PMDs?
>
> Thanks,
>
> —
> Damjan
next prev parent reply other threads:[~2019-10-27 7:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 12:18 Anatoly Burakov
2019-10-24 19:09 ` David Marchand
2019-10-24 20:27 ` Stephen Hemminger
2019-10-24 22:32 ` Thomas Monjalon
2019-10-25 11:13 ` Damjan Marion (damarion)
2019-10-25 12:23 ` Burakov, Anatoly
2019-10-25 13:02 ` Damjan Marion (damarion)
2019-11-04 13:57 ` Damjan Marion (damarion)
2019-11-04 17:27 ` Burakov, Anatoly
2019-11-04 17:34 ` Damjan Marion (damarion)
2019-11-04 17:42 ` Burakov, Anatoly
2019-11-04 17:44 ` Damjan Marion (damarion)
2019-11-06 13:48 ` David Marchand
2019-11-06 13:50 ` Thomas Monjalon
2019-11-06 13:54 ` Burakov, Anatoly
2019-10-27 7:00 ` Shahaf Shuler [this message]
2019-11-04 13:58 ` Damjan Marion (damarion)
2019-11-06 21:11 ` David Marchand
2019-11-07 15:34 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB3795EC4A369BDEDACB594CDDC3670@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=damarion@cisco.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).