From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 15201A0AC5 for ; Sun, 26 May 2019 20:49:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFFF22B8E; Sun, 26 May 2019 20:49:03 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150048.outbound.protection.outlook.com [40.107.15.48]) by dpdk.org (Postfix) with ESMTP id C450FA49; Sun, 26 May 2019 20:49:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKei1SHQ6uz9l3wEIi7L82Mq94YIjQJ9Rp6gHAWAxwo=; b=KEZ3eD5UjAPCCwFL08oOKHpDmtmPGq66+iBuZuf8FzxMQDPBZ6VhkLMOUh7BqfMLR9VxrJF73oMMBKC3kJZzxNe/Xrm1ujlwUmbfIFhiIp63TC3Vz4znHyLyPPrspiU0lAwCVn4ZaRVAjS8h2ArStciyxVLxoM/J/Qgq2pX9bS8= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB3745.eurprd05.prod.outlook.com (52.133.50.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1922.20; Sun, 26 May 2019 18:49:01 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1922.021; Sun, 26 May 2019 18:49:01 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func Thread-Index: AQHVCwZ9abU1yUlkgk++LKZp8zrIu6Z9zh/Q Date: Sun, 26 May 2019 18:49:01 +0000 Message-ID: References: <1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com> In-Reply-To: <1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ca1e151-693b-40a2-02da-08d6e20ad1d9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3745; x-ms-traffictypediagnostic: AM0PR0502MB3745: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0049B3F387 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(376002)(366004)(396003)(136003)(346002)(39860400002)(189003)(199004)(4326008)(450100002)(6506007)(53936002)(26005)(102836004)(9686003)(316002)(186003)(74316002)(446003)(6436002)(25786009)(86362001)(6636002)(66066001)(99286004)(55016002)(54906003)(110136005)(256004)(3846002)(6246003)(6116002)(478600001)(11346002)(476003)(7696005)(229853002)(305945005)(7736002)(486006)(66946007)(8676002)(66556008)(66476007)(52536014)(81156014)(81166006)(73956011)(68736007)(64756008)(66446008)(76116006)(8936002)(33656002)(14454004)(71190400001)(71200400001)(2906002)(5660300002)(76176011)(14444005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3745; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: NQaVm1+HnFN/UX557c9qgYRmS4QJzsA3o5VySIdE/GaVro9J1dzYLURT9MFeozjhL72L7E7EcEXxe2iVmhf8TWSjNrXI0qYL5VBC0CSIMym5FtbirORuU56XFfr0yKHECUiefMXSLMSf0Rbl09Og0ipBhURQBLZf+J16N0Pm557d9xFadyLA7TIP9MpGXg0qZdBkakTeMEvuJOcb5gBGWDzOGpgt5sVChWOVNnbQ2YibvNYKYJ/JVHvigBgzxaQ0vTrYQWz7XvQiNSMS7XLMAnojtT2lSN23EKU7dAEsZfzSZavFLHWX0DA6OHrpehzOnflSxrzV4yeabQK5Qsv5DszdE6dKCgZUKBmJbIM5XG5QFxzFpC+FLzFmqg2Kat/sxNNN9WjpBdRaFPTvFfdKyEOBhE/ghkK2Jxi3bD3tr+A= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ca1e151-693b-40a2-02da-08d6e20ad1d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2019 18:49:01.6515 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: shahafs@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3745 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Wednesday, May 15, 2019 1:08 PM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter > func >=20 > Previous patch added handling of metadata for multi-segment packet. > Function txq_scatter_v in file mlx5_rxtx_vec_neon.h was updated > incorrectly, items were inserted into WQE in wrong order. >=20 > This patch fixes the issue, inserting items into WQE correctly. >=20 > Fixes: 7f4019d370f6 ("net/mlx5: fix Tx metadata for multi-segment packet"= ) > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > index 38e915c..b1e0e8f 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h > @@ -171,7 +171,7 @@ > /* Fill ESEG in the header. */ > vst1q_u32((void *)(t_wqe + 1), > ((uint32x4_t){ 0, > - cs_flags << 16 | > rte_cpu_to_be_16(len), > + rte_cpu_to_be_16(len) << 16 | > cs_flags, It was probably not introduced by the previous patch, but since you touch t= his area: Why do you set the mss (len)? This function handles only non-TSO packets.=20 > metadata, 0 })); > txq->wqe_ci =3D wqe_ci; > } > -- > 1.8.3.1