From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by dpdk.org (Postfix) with ESMTP id 542D54C8F; Wed, 8 May 2019 06:44:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wReZFS8bS2yQRT5G2LxAM3oJHOqqAZwwBn+tfu5Aio=; b=tCtFeGtlTCYFpXREq1RQ23UMJ5iIogRzWFj1Cb7lNgZ8zV/OBpDQbQCAdnRKkb88oCVGbWQEtLRD83SdN7LkJV+OVyJmTCCMaOxNBIqQ2GEPwQ32XfhR/5E9IHTmvmV5cg1JaWhLcSfE3BYirgPEt8GGqomUUbpJCwctsKLxKJc= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:44:18 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:44:18 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object Thread-Index: AQHVBKaIzovih+hKa06RfMAJGpPpZ6ZgotgQ Date: Wed, 8 May 2019 04:44:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38408634-fa58-4da9-5f0d-08d6d36fd4bd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:446; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(54906003)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(450100002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(4744005)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wUtfUtHW0w3qJGGdukVs3UFF+iSnQWfdYCcO2zCDnqVm5upEBs34djCvm0x6S+udhT3reqLVzj0gSLpKAX1Wq3CnmUBan80/XRHxlI1+K3vWzhv2/4QzDneo87TEyVJ8KbsFhlkaeYtd32Ol5Kw7iRhfrOGmrXWfhlB8jzXRGzbcpdMWalg5b0kEcTmsGj1mwnykTyxOEie3BESCExSj6j2XSydp3+QtMryxKLyzOBMWAcCk/uzhR7Cm9nm8egBDrL7D0ipWsJnQ3FxLRGi8QGtvEeU6BA7dfrK6xMxQvZ/GNSyLZZqthT2MoktJyubzdtUvzQkZW0oxnEtZNQq0SVS/QjE/IBlHcc4aAh7lV19z8gFLiYVi3BO2CQxBHeSgfuJSg2PYYo98SSUmzKVluS2M2qNQv9O7uNKd2Nvs4VY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38408634-fa58-4da9-5f0d-08d6d36fd4bd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:44:18.2795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 04:44:19 -0000 Tuesday, May 7, 2019 10:26 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue > object >=20 > Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs som= e > actions on the returned rxq_ibv. > It doens't release the rxq_ibv when all is completed with success. >=20 > This patch adds call to mlx5_rxq_ibv_release() where it's missing. >=20 > Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue > objects") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled Applied to next-net-mlx, thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8EFFA0096 for ; Wed, 8 May 2019 06:44:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8DB1B4D3A; Wed, 8 May 2019 06:44:20 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by dpdk.org (Postfix) with ESMTP id 542D54C8F; Wed, 8 May 2019 06:44:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2wReZFS8bS2yQRT5G2LxAM3oJHOqqAZwwBn+tfu5Aio=; b=tCtFeGtlTCYFpXREq1RQ23UMJ5iIogRzWFj1Cb7lNgZ8zV/OBpDQbQCAdnRKkb88oCVGbWQEtLRD83SdN7LkJV+OVyJmTCCMaOxNBIqQ2GEPwQ32XfhR/5E9IHTmvmV5cg1JaWhLcSfE3BYirgPEt8GGqomUUbpJCwctsKLxKJc= Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com (52.133.45.150) by AM0PR0502MB4001.eurprd05.prod.outlook.com (52.133.36.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1856.12; Wed, 8 May 2019 04:44:18 +0000 Received: from AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d]) by AM0PR0502MB3795.eurprd05.prod.outlook.com ([fe80::8c0:a6ef:6abc:334d%7]) with mapi id 15.20.1856.012; Wed, 8 May 2019 04:44:18 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object Thread-Index: AQHVBKaIzovih+hKa06RfMAJGpPpZ6ZgotgQ Date: Wed, 8 May 2019 04:44:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38408634-fa58-4da9-5f0d-08d6d36fd4bd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB4001; x-ms-traffictypediagnostic: AM0PR0502MB4001: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:446; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(305945005)(26005)(55016002)(66946007)(2906002)(73956011)(76116006)(25786009)(110136005)(7736002)(316002)(54906003)(33656002)(7696005)(4326008)(64756008)(66556008)(6116002)(186003)(9686003)(68736007)(256004)(99286004)(3846002)(450100002)(6436002)(66446008)(5660300002)(66066001)(81166006)(81156014)(8936002)(6246003)(66476007)(14454004)(446003)(8676002)(52536014)(6636002)(74316002)(4744005)(11346002)(53936002)(486006)(76176011)(71200400001)(71190400001)(86362001)(102836004)(476003)(478600001)(229853002)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4001; H:AM0PR0502MB3795.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wUtfUtHW0w3qJGGdukVs3UFF+iSnQWfdYCcO2zCDnqVm5upEBs34djCvm0x6S+udhT3reqLVzj0gSLpKAX1Wq3CnmUBan80/XRHxlI1+K3vWzhv2/4QzDneo87TEyVJ8KbsFhlkaeYtd32Ol5Kw7iRhfrOGmrXWfhlB8jzXRGzbcpdMWalg5b0kEcTmsGj1mwnykTyxOEie3BESCExSj6j2XSydp3+QtMryxKLyzOBMWAcCk/uzhR7Cm9nm8egBDrL7D0ipWsJnQ3FxLRGi8QGtvEeU6BA7dfrK6xMxQvZ/GNSyLZZqthT2MoktJyubzdtUvzQkZW0oxnEtZNQq0SVS/QjE/IBlHcc4aAh7lV19z8gFLiYVi3BO2CQxBHeSgfuJSg2PYYo98SSUmzKVluS2M2qNQv9O7uNKd2Nvs4VY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38408634-fa58-4da9-5f0d-08d6d36fd4bd X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2019 04:44:18.2795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4001 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue object X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508044418.BEUQQB2DkVcCouCX7_Djn2GmajWEKvDlmiCy2qdJ3BU@z> Tuesday, May 7, 2019 10:26 AM, Dekel Peled: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix missing release of Rx queue > object >=20 > Function mlx5_rx_intr_disable() calls mlx5_rxq_ibv_get() and performs som= e > actions on the returned rxq_ibv. > It doens't release the rxq_ibv when all is completed with success. >=20 > This patch adds call to mlx5_rxq_ibv_release() where it's missing. >=20 > Fixes: 09cb5b581762 ("net/mlx5: separate DPDK from verbs Rx queue > objects") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled Applied to next-net-mlx, thanks.