From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0042.outbound.protection.outlook.com [104.47.2.42]) by dpdk.org (Postfix) with ESMTP id 49A81326C; Wed, 14 Feb 2018 12:23:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IxQCz+bToY+zO+tuf1Z/n93ZNpLvmKUORk6UNldKQ0A=; b=coLlEeh0RLhcp0qFoN5XApPdJmMiOTMwbzDll/CTaXwrHeU2aQM6YKCIndiVpImgW8HlZacyrHFBARaafL30NXoKzr1IQLqIoANftYKqcvoyg9l4rnB+FG4WoHpWrQEXJgDaVjao15SR2iCJCXIpNToJMN1ttLguwtGfK5aPgu0= Received: from AM0PR0502MB3875.eurprd05.prod.outlook.com (52.133.48.17) by AM0PR0502MB4084.eurprd05.prod.outlook.com (52.133.41.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.485.10; Wed, 14 Feb 2018 11:23:54 +0000 Received: from AM0PR0502MB3875.eurprd05.prod.outlook.com ([fe80::c146:f27f:8151:5631]) by AM0PR0502MB3875.eurprd05.prod.outlook.com ([fe80::c146:f27f:8151:5631%13]) with mapi id 15.20.0506.016; Wed, 14 Feb 2018 11:23:55 +0000 From: Ophir Munk To: Pascal Mazon , "dev@dpdk.org" CC: Thomas Monjalon , Olga Shern , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/tap: fix promiscuous rules double insersions Thread-Index: AQHTpPl9Bnx4SLqoOk+qCyRSmZoNrqOjl88AgAAeB8A= Date: Wed, 14 Feb 2018 11:23:54 +0000 Message-ID: References: <1518542172-9334-1-git-send-email-ophirmu@mellanox.com> <1518546947-20932-1-git-send-email-ophirmu@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0502MB4084; 6:6otcrQG0YUX9zb0FUhWrkcI2WugvVFiLY4tVbJ9gFCYiw11UoOi34D1AGa/OdcBlGMU3aIASijp60bC00gWyhigVoo07xHUx9/zuiibYgAhMwjvwrB4f1RvPcI82SK3Ab3puHAFEbwZeZGq/wy/dnvhesfNf5y0Fczh1rGzdahGIj4fmolaU2oQP1IkfmXoEpahGsPArGtUaUxTqDoieoRcGxvftIyUkpVWQtpeGB3hD2IdkMkfvKehqPFj34u4cBxFK7klbxbDgBvsfV69TMD86vfBPdot6ckL+290U3vaGxDSwqG+ulk6WddwdJDKdpbxxbtTndGG6q6s/oRL9qLkwZWdSr+dxPlHpKsfG54hGXxNCZquOinEuHkOXDySO; 5:kBr35vkzud52WaPSvAb46/dciGKQT1qDz2lf1DQagJp406myFRzaiZ1UJmmclrwW/R9jf9eps3DAut9aVbJ1wBOMZfCEw3WR1+65UP6lvs5BI4zpDGok/6gMB5d7J/S2S73C6M9MUHtNLM0Zjxe9Xx2sG16kBu9zBiBwo7WwyYM=; 24:WU+vzP89kFXP7dk2CpEwv+Kc1Z8wmbedOA0ad9FHBp/8jDTgv0j9TIKOBSGK8Hy0EaOKz55XJq/LxYevbeEQzvGcPrX7pX8mq470/a8Pc9A=; 7:MmH7qU9jXspPnFCN+e9/FVznxu8J5SYJSlvKNRjYx5KU96ngXgIzLctZuAh9KkylOkeLMFvKUaNHy/tgaj/hD+tAgD0b7VR9pxVyS29XU+nMHSEtdtIEZKFXvbhz9nz97TwypcGsOa0bJyzBqK/q0JbqCH6fICUBU80a3mSO5iWdGTsUn6eBxS3N4OZHoFlj6Lfit0VJ3X2LI13iloosvsVXMKgZI2sgNNAhZOS3Vql466mogrsjUPfJmY/MQe/f x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: d381dc34-c913-449a-1a92-08d5739d6eea x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM0PR0502MB4084; x-ms-traffictypediagnostic: AM0PR0502MB4084: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231101)(944501161)(6055026)(6041288)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM0PR0502MB4084; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB4084; x-forefront-prvs: 0583A86C08 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39380400002)(376002)(366004)(39860400002)(346002)(396003)(189003)(13464003)(199004)(99286004)(59450400001)(4326008)(8936002)(55016002)(6116002)(3846002)(6436002)(2950100002)(2501003)(81166006)(81156014)(7696005)(25786009)(229853002)(8676002)(3660700001)(66066001)(14454004)(68736007)(110136005)(86362001)(5250100002)(76176011)(186003)(9686003)(316002)(53936002)(102836004)(5660300001)(7736002)(74316002)(2900100001)(105586002)(106356001)(3280700002)(478600001)(54906003)(2906002)(305945005)(53546011)(6246003)(97736004)(6506007)(26005)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4084; H:AM0PR0502MB3875.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: vg5YLm2kyZIxuME2zOzVQglOZAZKhYBrOM2E+YuuT0TIFwNheAJ5OENyeOZIzQTszcHG+ia+t5kVDFolrzTJxQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d381dc34-c913-449a-1a92-08d5739d6eea X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2018 11:23:54.9751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4084 Subject: Re: [dpdk-dev] [PATCH v2] net/tap: fix promiscuous rules double insersions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Feb 2018 11:23:56 -0000 UGxlYXNlIHNlZSBpbmxpbmUuDQpJIHdpbGwgc2VuZCB1cGRhdGVkIHYzDQoNCj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUGFzY2FsIE1hem9uIFttYWlsdG86cGFzY2FsLm1h em9uQDZ3aW5kLmNvbV0NCj4gU2VudDogV2VkbmVzZGF5LCBGZWJydWFyeSAxNCwgMjAxOCAxMDo1 MSBBTQ0KPiBUbzogT3BoaXIgTXVuayA8b3BoaXJtdUBtZWxsYW5veC5jb20+OyBkZXZAZHBkay5v cmcNCj4gQ2M6IFRob21hcyBNb25qYWxvbiA8dGhvbWFzQG1vbmphbG9uLm5ldD47IE9sZ2EgU2hl cm4NCj4gPG9sZ2FzQG1lbGxhbm94LmNvbT47IHN0YWJsZUBkcGRrLm9yZw0KPiBTdWJqZWN0OiBS ZTogW1BBVENIIHYyXSBuZXQvdGFwOiBmaXggcHJvbWlzY3VvdXMgcnVsZXMgZG91YmxlIGluc2Vy c2lvbnMNCj4gDQo+IEhpIE9waGlyLA0KPiANCj4gVHlwbyBpbiB0aXRsZTogcy9pbnNlcnNpb25z L2luc2VydGlvbnMvDQo+IA0KDQpGaXhlZCBpbiB2Mw0KDQo+IEknbSBvayBvbiBwcmluY2lwbGUs IEkgaGF2ZSBqdXN0IGEgZmV3IGNvbW1lbnRzIGlubGluZS4NCj4gDQo+IFJlZ2FyZHMsDQo+IFBh c2NhbA0KPiANCj4gT24gMTMvMDIvMjAxOCAxOTozNSwgT3BoaXIgTXVuayB3cm90ZToNCj4gPiBS dW5uaW5nIHRlc3RwbWQgY29tbWFuZCAicG9ydCBzdG9wIGFsbCIgZm9sbG93ZWQgYnkgY29tbWFu ZCAicG9ydA0KPiA+IHN0YXJ0IGFsbCIgbWF5IHJlc3VsdCBpbiBhIFRBUCBlcnJvcjoNCj4gPiBQ TUQ6IEtlcm5lbCByZWZ1c2VkIFRDIGZpbHRlciBydWxlIGNyZWF0aW9uICgxNyk6IEZpbGUgZXhp c3RzDQo+ID4NCj4gPiBSb290IGNhdXNlIGFuYWx5c2lzOiBkdXJpbmcgdGhlIGV4ZWN1dGlvbiBv ZiAicG9ydCBzdGFydCBhbGwiIGNvbW1hbmQNCj4gPiB0ZXN0cG1kIGNhbGxzIHJ0ZV9ldGhfcHJv bWlzY3VvdXNfZW5hYmxlKCkgd2hpbGUgZHVyaW5nIHRoZSBleGVjdXRpb24NCj4gPiBvZiAicG9y dCBzdG9wIGFsbCIgY29tbWFuZCB0ZXN0cG1kIGRvZXMgbm90IGNhbGwNCj4gPiBydGVfZXRoX3By b21pc2N1b3VzX2VuYWJsZSgpLg0KPiBTaG91bGRuJ3QgaXQgYmUgcnRlX2V0aF9wcm9taXNjdW91 c19kaXNhYmxlKCk/DQoNClllcyBpdCBzaG91bGQuIEZpeGVkIGluIHYzDQoNCj4gPiBBcyBhIHJl c3VsdCB0aGUgVEFQIFBNRCBpcyB0cnlpbmcgdG8gYWRkIHRjICh0cmFmZmljIGNvbnRyb2wgY29t bWFuZCkNCj4gPiBwcm9taXNjdW91cyBydWxlcyB0byB0aGUgcmVtb3RlIG5ldHZzYyBkZXZpY2Ug Y29uc2VjdXRpdmVseS4gRnJvbSB0aGUNCj4gPiBrZXJuZWwgcG9pbnQgb2YgdmlldyBpdCBpcyBz ZWVuIGFzIGFuIGF0dGVtcHQgdG8gYWRkIHRoZSBzYW1lIHJ1bGUNCj4gPiBtb3JlIHRoYW4gb25j ZS4gSW4gcmVjZW50IGtlcm5lbHMgKGUuZy4gdmVyc2lvbiA0LjEzKSB0aGlzIGF0dGVtcHQgaXMN Cj4gPiByZWplY3RlZCB3aXRoIGEgIkZpbGUgZXhpc3RzIiBlcnJvci4gSW4gbGVzcyByZWNlbnQg a2VybmVscyAoZS5nLg0KPiA+IHZlcnNpb24gNC40KSB0aGUgc2FtZSBydWxlIG1heSBoYXZlIGJl ZW4gYWNjZXB0ZWQgdHdpY2Ugc3VjY2Vzc2Z1bGx5LA0KPiB3aGljaCBpcyB1bmRlc2lyYWJsZS4N Cj4gPg0KPiA+IEluIHRoZSBjb3JydXB0ZWQgY29kZSBldmVyeSB0YyBwcm9taXNjdW91cyBydWxl IGluY2x1ZGVkIGEgZGlmZmVyZW50DQo+ID4gaGFuZGxlIG51bWJlciBwYXJhbWV0ZXIuIElmIGlu c3RlYWQgYW4gaWRlbnRpY2FsIGhhbmRsZSBudW1iZXINCj4gPiBwYXJhbWV0ZXIgaXMgdXNlZCBm b3IgYWxsIHRjIHByb21pc2N1b3VzIHJ1bGVzIC0gYWxsIGtlcm5lbHMgd2lsbA0KPiA+IHJlamVj dCB0aGUgc2Vjb25kIHJ1bGUgd2l0aCBhICJGaWxlIGV4aXN0cyIgZXJyb3IsIHdoaWNoIGlzIGVh c3kgdG8NCj4gPiBpZGVudGlmeSBhbmQgdG8gc2lsZW50bHkgaWdub3JlLg0KPiA+DQo+ID4gRml4 ZXM6IDJiYzA2ODY5Y2Q5NCAoIm5ldC90YXA6IGFkZCByZW1vdGUgbmV0ZGV2aWNlIHRyYWZmaWMg Y2FwdHVyZSIpDQo+ID4gQ2M6IHN0YWJsZUBkcGRrLm9yZw0KPiA+DQo+ID4gU2lnbmVkLW9mZi1i eTogT3BoaXIgTXVuayA8b3BoaXJtdUBtZWxsYW5veC5jb20+DQo+ID4gLS0tDQo+ID4gdjI6IGFk ZCBkZXRhaWxlZCBjb21taXQgbWVzc2FnZQ0KPiA+DQo+ID4gIGRyaXZlcnMvbmV0L3RhcC90YXBf Zmxvdy5jIHwgMTEgKysrKysrKysrKysNCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlv bnMoKykNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC90YXAvdGFwX2Zsb3cuYyBi L2RyaXZlcnMvbmV0L3RhcC90YXBfZmxvdy5jDQo+ID4gaW5kZXggNjU2NTdmMC4uZDFmNGE1MiAx MDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL25ldC90YXAvdGFwX2Zsb3cuYw0KPiA+ICsrKyBiL2Ry aXZlcnMvbmV0L3RhcC90YXBfZmxvdy5jDQo+ID4gQEAgLTEyMyw2ICsxMjMsNyBAQCBlbnVtIGtl eV9zdGF0dXNfZSB7ICB9Ow0KPiA+DQo+ID4gICNkZWZpbmUgSVNPTEFURV9IQU5ETEUgMQ0KPiA+ ICsjZGVmaW5lIFJFTU9URV9QUk9NSVNDVU9VU19IQU5ETEUgMg0KPiA+DQo+ID4gIHN0cnVjdCBy dGVfZmxvdyB7DQo+ID4gIAlMSVNUX0VOVFJZKHJ0ZV9mbG93KSBuZXh0OyAvKiBQb2ludGVyIHRv IHRoZSBuZXh0IHJ0ZV9mbG93IHN0cnVjdHVyZQ0KPiA+ICovIEBAIC0xNjkyLDkgKzE2OTMsMTUg QEAgaW50IHRhcF9mbG93X2ltcGxpY2l0X2NyZWF0ZShzdHJ1Y3QNCj4gcG1kX2ludGVybmFscyAq cG1kLA0KPiA+ICAJICogVGhlIElTT0xBVEUgcnVsZSBpcyBhbHdheXMgcHJlc2VudCBhbmQgbXVz dCBoYXZlIGEgc3RhdGljIGhhbmRsZSwNCj4gYXMNCj4gPiAgCSAqIHRoZSBhY3Rpb24gaXMgY2hh bmdlZCB3aGV0aGVyIHRoZSBmZWF0dXJlIGlzIGVuYWJsZWQgKERST1ApIG9yDQo+ID4gIAkgKiBk aXNhYmxlZCAoUEFTU1RIUlUpLg0KPiA+ICsJICogVGhlcmUgaXMganVzdCBvbmUgUkVNT1RFX1BS T01JU0NVT1VTIHJ1bGUgaW4gYWxsIGNhc2VzLiBJdA0KPiBzaG91bGQNCj4gPiArCSAqIGhhdmUg YSBzdGF0aWMgaGFuZGxlIHN1Y2ggdGhhdCBhZGRpbmcgaXQgdHdpY2Ugd2lsbCBmYWlsIHdpdGgg RUVYSVNUDQo+ID4gKwkgKiB3aXRoIGFueSBrZXJuZWwgdmVyc2lvbi4gUmVtYXJrOiBvbGQga2Vy bmVscyBtYXkgZmFsc2VseSBhY2NlcHQgdGhlDQo+ID4gKwkgKiBzYW1lIFJFTU9URV9QUkVNSVND VU9VUyBydWxlcyBpZiB0aGV5IGhhZCBkaWZmZXJlbnQgaGFuZGxlcy4NCj4gcy9QUkVNSVNDVU9V Uy9QUk9NSVNDVU9VUy8NCj4gPiAgCSAqLw0KPiA+ICAJaWYgKGlkeCA9PSBUQVBfSVNPTEFURSkN Cj4gPiAgCQlyZW1vdGVfZmxvdy0+bXNnLnQudGNtX2hhbmRsZSA9IElTT0xBVEVfSEFORExFOw0K PiA+ICsJZWxzZSBpZiAoaWR4ID09IFRBUF9SRU1PVEVfUFJPTUlTQykNCj4gPiArCQlyZW1vdGVf Zmxvdy0+bXNnLnQudGNtX2hhbmRsZSA9DQo+IFJFTU9URV9QUk9NSVNDVU9VU19IQU5ETEU7DQo+ ID4gIAllbHNlDQo+ID4gIAkJdGFwX2Zsb3dfc2V0X2hhbmRsZShyZW1vdGVfZmxvdyk7DQo+ID4g IAlpZiAocHJpdl9mbG93X3Byb2Nlc3MocG1kLCBhdHRyLCBpdGVtcywgYWN0aW9ucywgTlVMTCwg QEAgLTE3MDksMTINCj4gPiArMTcxNiwxNiBAQCBpbnQgdGFwX2Zsb3dfaW1wbGljaXRfY3JlYXRl KHN0cnVjdCBwbWRfaW50ZXJuYWxzICpwbWQsDQo+ID4gIAl9DQo+ID4gIAllcnIgPSB0YXBfbmxf cmVjdl9hY2socG1kLT5ubHNrX2ZkKTsNCj4gPiAgCWlmIChlcnIgPCAwKSB7DQo+ID4gKwkJLyog U2lsZW50bHkgaWdub3JlIHJlLWVudGVyaW5nIHJlbW90ZSBwcm9taXNjdW91cyBydWxlICovDQo+ ID4gKwkJaWYgKGVycm5vID09IEVFWElTVCAmJiBpZHggPT0gVEFQX1JFTU9URV9QUk9NSVNDKQ0K PiA+ICsJCQlnb3RvIHN1Y2Nlc3M7DQo+ID4gIAkJUlRFX0xPRyhFUlIsIFBNRCwNCj4gPiAgCQkJ Iktlcm5lbCByZWZ1c2VkIFRDIGZpbHRlciBydWxlIGNyZWF0aW9uICglZCk6ICVzXG4iLA0KPiA+ ICAJCQllcnJubywgc3RyZXJyb3IoZXJybm8pKTsNCj4gPiAgCQlnb3RvIGZhaWw7DQo+ID4gIAl9 DQo+ID4gIAlMSVNUX0lOU0VSVF9IRUFEKCZwbWQtPmltcGxpY2l0X2Zsb3dzLCByZW1vdGVfZmxv dywgbmV4dCk7DQo+IEFyZSB3ZSBzdXJlIHRoZSBwcmV2aW91cyBydWxlIGlzIHN0aWxsIGluIHRo ZSByZWdpc3RlcmVkIGltcGxpY2l0IGZsb3dzPw0KDQpJIHdpbGwgcnVuIHRlc3RzIHRvIHZlcmlm eSB0aGF0Lg0KDQo+ID4gK3N1Y2Nlc3M6DQo+ID4gIAlyZXR1cm4gMDsNCj4gPiAgZmFpbDoNCj4g PiAgCWlmIChyZW1vdGVfZmxvdykNCg0K