From: Matan Azrad <matan@mellanox.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop
Date: Fri, 10 Apr 2020 13:59:37 +0000 [thread overview]
Message-ID: <AM0PR0502MB401902CE3BF09ACE2BC690CED2DE0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <f0baaa38-c9e2-11b0-d5b8-6e48158f3bc9@redhat.com>
Hi Maxime
From: Maxime Coquelin
> On 3/31/20 1:12 PM, Matan Azrad wrote:
> > In live migration, before loging the virtq, the driver queries the
> > virtq
> s/loging/logging/
Ok, can this small change be done in integration?
> > indexes after moving it to suspend mode.
> >
> > Separate this method to new function mlx5_vdpa_virtq_stop as a
> > preparation for reusing.
> >
> > Signed-off-by: Matan Azrad <matan@mellanox.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
> > drivers/vdpa/mlx5/mlx5_vdpa.h | 13 +++++++++++++
> > drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 17 ++---------------
> > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 26
> ++++++++++++++++++++++++++
> > 3 files changed, 41 insertions(+), 15 deletions(-)
> >
>
> Other than that:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> Thanks,
> Maxime
next prev parent reply other threads:[~2020-04-10 13:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 11:12 [dpdk-dev] [PATCH 0/3] vdpa/mlx5: recteate a virtq becoming enabled Matan Azrad
2020-03-31 11:12 ` [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array Matan Azrad
2020-04-09 15:18 ` Maxime Coquelin
2020-04-10 13:58 ` Matan Azrad
2020-04-10 13:59 ` Maxime Coquelin
2020-04-15 14:06 ` Maxime Coquelin
2020-03-31 11:12 ` [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop Matan Azrad
2020-04-09 15:28 ` Maxime Coquelin
2020-04-10 13:59 ` Matan Azrad [this message]
2020-04-10 14:04 ` Maxime Coquelin
2020-03-31 11:12 ` [dpdk-dev] [PATCH 3/3] vdpa/mlx5: recteate a virtq becoming enabled Matan Azrad
2020-04-15 14:06 ` Maxime Coquelin
2020-04-17 14:58 ` [dpdk-dev] [PATCH 0/3] " Maxime Coquelin
2020-04-26 12:07 ` [dpdk-dev] [PATCH 0/3] vdpa/mlx5: recreate " Matan Azrad
2020-04-26 12:07 ` [dpdk-dev] [PATCH 1/3] vdpa/mlx5: manage virtqs by array Matan Azrad
2020-04-27 7:45 ` Maxime Coquelin
2020-04-26 12:07 ` [dpdk-dev] [PATCH 2/3] vdpa/mlx5: separate virtq stop Matan Azrad
2020-04-26 12:07 ` [dpdk-dev] [PATCH 3/3] vdpa/mlx5: recreate a virtq becoming enabled Matan Azrad
2020-04-28 16:07 ` [dpdk-dev] [PATCH 0/3] " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB401902CE3BF09ACE2BC690CED2DE0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).