From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA227A00E6 for ; Wed, 7 Aug 2019 09:02:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AF44D37A8; Wed, 7 Aug 2019 09:02:04 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130041.outbound.protection.outlook.com [40.107.13.41]) by dpdk.org (Postfix) with ESMTP id 3F189375B for ; Wed, 7 Aug 2019 09:02:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZlmKZ5Sa7CYltdUjIOGY/5YXIa70SnZnMnfAzHrnoc+/hsARjGe2H7Y7waPxwpRn4SQp9Frfbc7qG62jneWJ50uAzd7Jd1LHetBA69l/hc4Nh6yM91zNN/cCwejCe9jRIdCDNWi3MoM4Tm7t9A8T0gG5DaktJWxRyqQmeEqG4H3iZH2H2M/dKDc800K3cz+w5kfnFGogmS7giM9G23l2ej5cR45Lk1xAP5iZ+ekpN3g0tgxBdnuzEVBQLhOL5Dfl24VxKcSUa7VgtVv3gd/Y/d0Z/T2lw/n0KbnvahbTX2KnygDjN6mxpX4wB9JS7JhPlobKqETwWeLCl3lq9hj0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGe4b1HiipULENu1xQj2eASYmxqm/llT2qSKV1YfIEk=; b=hapAjay9tE1elVWx34TfWIyj+N89wSfQd4nbbrrZfzzr8Yslqx3lRsS2jG9F7X6VDCsfoeD8+MlYDLRFjd92B+EohuFW536YeXETUbzJkLqHcktuW8thIRd1WZXZS2d7oIs0/gL07NS+wAtaY4F5ANm3cg9lGmnE+4NX30oclmmoTGJ5dY/IOnubL5LS2lIykG1P7WeEj7vyiqGEUzBrJZapEtVvioeT1AnMOE1W5CivWTSqU3om0vMzmb0kG1sWLKfdoIfKMy4Ja+W07TYeYqFQW4dzQ5/zNnT99kCiJ/GiwKvoDdbfhisplGJUWsx+B0qbJZxLgQpQOgCkKNdAGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGe4b1HiipULENu1xQj2eASYmxqm/llT2qSKV1YfIEk=; b=UUWByfHHhWwopioQdHGPvRd3bXe1DLF7oZWE/hOne7UTRbm/QjgSQXkYXsKuKstXAIEppUT7gL0aIPUsWyRf+Qv+VD1ga6pa6k3378ua2uoeT9FE0ZOW2HSLnGuMs4RGx8lWVb/XfZVODfxZdViRO22WN+SbaMvV0Sl0BzSTui4= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3665.eurprd05.prod.outlook.com (52.133.46.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Wed, 7 Aug 2019 07:02:02 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::ccc2:2dd4:ca86:7639%3]) with mapi id 15.20.2136.010; Wed, 7 Aug 2019 07:02:02 +0000 From: Matan Azrad To: Stephen Hemminger CC: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity Thread-Index: AQHVSUphxp1Q426sqUeRhaSMjaIUiKbqqieggAIRMACAAQvgMIAAgJiAgABICsCAADV+gIAAa2JAgAAFeACAABHM4A== Date: Wed, 7 Aug 2019 07:02:02 +0000 Message-ID: References: <20190726165054.24078-1-stephen@networkplumber.org> <20190802025826.1174-1-stephen@networkplumber.org> <20190802025826.1174-2-stephen@networkplumber.org> <20190802085301.02ab5b55@hermes.lan> <20190805090054.1511b033@hermes.lan> <20190806083955.59124799@hermes.lan> <20190806160913.62e0d15d@hermes.lan> <20190806225308.736f15ef@hermes.lan> In-Reply-To: <20190806225308.736f15ef@hermes.lan> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fadc6fda-b5fe-471c-8832-08d71b052600 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR0502MB3665; x-ms-traffictypediagnostic: AM0PR0502MB3665: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 01221E3973 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(136003)(396003)(39860400002)(376002)(199004)(189003)(7696005)(25786009)(76176011)(53936002)(99286004)(5660300002)(66066001)(3846002)(52536014)(305945005)(7736002)(2906002)(26005)(74316002)(6116002)(229853002)(8676002)(186003)(71190400001)(71200400001)(64756008)(81166006)(81156014)(9686003)(8936002)(55016002)(54906003)(256004)(14444005)(316002)(33656002)(6436002)(4326008)(446003)(11346002)(478600001)(476003)(6246003)(102836004)(86362001)(53546011)(6506007)(66476007)(76116006)(6916009)(66946007)(66556008)(66446008)(68736007)(14454004)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3665; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 8lEnYRGDrLXklTBvO8tNjeG1QBgfN5GkI03KSy1+U1E+a/peOHE4BNWOpuLa8tTYDOKegTF1SjM4ywigmDj31lG3PJg0L/R3aMrcThDbQkSX++vKhroXJFkHPnakE0D08xBprHzzGTJSuXzuBj082otSzqSo1sxSEOyTN65AIBiMEEcDC8TQL8ldAjm2ySZolIc2Wd7GmW46SUhHDC8ivr1nkH6NYA8O4jdkyDO6Hxek8bxjB72m3Tq0nmDq0fIT8Szp3LKFxJ5erAFi7k4N6QravS3OXbL4YmhWBUi8tF3iJbP2KIsZKmOPrZofQkM54IvP7DzPPsTLEaUuLq3SEptBAzaLYhaXMi9p/ZeO9+D23VcJbheTjmy/4EuHLMrraNw0QoDYYkbpTA30O98a+CJZaxwV2lf4+/AIMmby2VQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fadc6fda-b5fe-471c-8832-08d71b052600 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Aug 2019 07:02:02.1600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: matan@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3665 Subject: Re: [dpdk-dev] [PATCH v5 1/4] examples/multi_process/client_server_mp: check port validity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Stephen Hemminger > On Wed, 7 Aug 2019 05:38:42 +0000 > Matan Azrad wrote: >=20 > > From: Stephen Hemminger > > > Sent: Wednesday, August 7, 2019 2:09 AM > > > To: Matan Azrad > > > Cc: dev@dpdk.org; Stephen Hemminger > > > Subject: Re: [dpdk-dev] [PATCH v5 1/4] > > > examples/multi_process/client_server_mp: check port validity > > > > > > On Tue, 6 Aug 2019 20:03:22 +0000 > > > Matan Azrad wrote: > > > > > > > > > > > > > The DPDK has lots of hard coded assumptions of all ports fitting = in 64 > bits. > > > > > Examples include testpmd/parameters.c etc. > > > > > > > > Yes, I understand, but the user should know not to change the > > > > default value of RTE_MAX_ETHPORTS, at least it should be > documented. > > > > > > > > > The original concept of a small set of assigned values for > > > > > portid is not going to scale. It really should have been more > > > > > like ifindex; something that is not used by common API's much > > > > > larger range; and > > > assigned purely sequentially. > > > > > > > > > > The API's should all be using names, but the DPDK port naming is > > > > > also a mess... > > > > > > > > Port ID is OK, user can run port info, then to find the wanted > > > > port ID and > > > configure it by port id list\bitmap. > > > > > > > > > > > > > The examples are toy programs. If user changes RTE_MAX_ETHPORTS it > > > will break lots of other places. Why put more checks in the > > > examples. Sorry, it really would not help to pretend that fixing the > example is going to help this. > > > > > > Agree that it is not needed to fix all the places now. > > It is better just to update the example documentation that > RTE_MAX_ETHPORTS must not be changed when running this application. > > > > I will ack your series(v7) , Consider to update the doc if you want to = be > completely perfect here. >=20 > Perhaps the right place to tell the users is somewhere in the documentati= on? >=20 > One place would be here: >=20 > diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst index > f19c1389b6af..a847d9ceda22 100644 > --- a/doc/guides/faq/faq.rst > +++ b/doc/guides/faq/faq.rst > @@ -195,3 +195,8 @@ Why can't my application receive packets on my > system with UEFI Secure Boot enab >=20 > If UEFI secure boot is enabled, the Linux kernel may disallow the use of= UIO > on the system. > Therefore, devices for use by DPDK should be bound to the ``vfio-pci`` > kernel module rather than ``igb_uio`` or ``uio_pci_generic``. > + > +What is the maximum number of ethernet devices? > +----------------------------------------------- > + > +The limit on the number of Ethernet devices is controlled by the > RTE_MAX_ETHPORTS configuration setting. Since many of the applications > use a 64 bit value for port mask; the current upper limit is 64 ports. >=20 I think there are systems with a lot of virtual ports which may use more th= an 64. So update all the docs when the mask is defined, would be option too.