[dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state

[dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state

[Ferruh Yigit]

Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
is mostly a reminder because of a missing target.
It doesn't worth to break the ABI because of this change and removal
can be done when ethdev ABI version increased.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Thomas Monjalon <thomas@monjalon.net>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Matan Azrad <matan@mellanox.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index e2dbee317..9cd12ccd8 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -95,3 +95,7 @@ Deprecation Notices
 
   This is due to a lack of flexibility and reliance on a type unusable with
   C++ programs (struct rte_flow_desc).
+
+* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
+  Since this is an enum filed in the middle, removing this field will break
+  the ABI, so removing postponed to next ethdev ABI version increase.
-- 
2.17.1

Re: [dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state

[Andrew Rybchenko]

On 08/24/2018 05:51 PM, Ferruh Yigit wrote:
> Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
> is mostly a reminder because of a missing target.
> It doesn't worth to break the ABI because of this change and removal
> can be done when ethdev ABI version increased.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
> Cc: Matan Azrad <matan@mellanox.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index e2dbee317..9cd12ccd8 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -95,3 +95,7 @@ Deprecation Notices
>   
>     This is due to a lack of flexibility and reliance on a type unusable with
>     C++ programs (struct rte_flow_desc).
> +
> +* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
> +  Since this is an enum filed in the middle, removing this field will break
> +  the ABI, so removing postponed to next ethdev ABI version increase.

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Re: [dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state

[Ferruh Yigit]

On 8/27/2018 4:00 PM, Andrew Rybchenko wrote:
> On 08/24/2018 05:51 PM, Ferruh Yigit wrote:
>> Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
>> is mostly a reminder because of a missing target.
>> It doesn't worth to break the ABI because of this change and removal
>> can be done when ethdev ABI version increased.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
>> Cc: Matan Azrad <matan@mellanox.com>
>> ---
>>   doc/guides/rel_notes/deprecation.rst | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index e2dbee317..9cd12ccd8 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -95,3 +95,7 @@ Deprecation Notices
>>   
>>     This is due to a lack of flexibility and reliance on a type unusable with
>>     C++ programs (struct rte_flow_desc).
>> +
>> +* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
>> +  Since this is an enum filed in the middle, removing this field will break
>> +  the ABI, so removing postponed to next ethdev ABI version increase.
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 

In this release we already break the ABI for ethdev, instead of putting this
deprecation notice in, I will send a patch to remove RTE_ETH_DEV_DEFERRED, since
it is not used in current code, it should be trivial and safe change.

[dpdk-dev] [PATCH] ethdev: remove unused DEFERRED device state

[Ferruh Yigit]

DEFERRED state replaced by ownership concept and it is no more used as
code comment states.

ethdev ABI broken on this release use this opportunity to remove
DEFERRED state.

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Matan Azrad <matan@mellanox.com>
---
 lib/librte_ethdev/rte_ethdev.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 8a92d91e3..1960f3a2d 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -1306,8 +1306,6 @@ enum rte_eth_dev_state {
 	RTE_ETH_DEV_UNUSED = 0,
 	/** Device is attached when allocated in probing. */
 	RTE_ETH_DEV_ATTACHED,
-	/** The deferred state is useless and replaced by ownership. */
-	RTE_ETH_DEV_DEFERRED,
 	/** Device is in removed state when plug-out is detected. */
 	RTE_ETH_DEV_REMOVED,
 };
-- 
2.17.2

Re: [dpdk-dev] [PATCH] ethdev: remove unused DEFERRED device state

[Matan Azrad]

From: Ferruh Yigit
> DEFERRED state replaced by ownership concept and it is no more used as
> code comment states.
> 
> ethdev ABI broken on this release use this opportunity to remove DEFERRED
> state.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Matan Azrad <matan@mellanox.com>

Re: [dpdk-dev] [PATCH] ethdev: remove unused DEFERRED device state

[Ferruh Yigit]

On 11/20/2018 2:15 PM, Matan Azrad wrote:
> 
> 
> From: Ferruh Yigit
>> DEFERRED state replaced by ownership concept and it is no more used as
>> code comment states.
>>
>> ethdev ABI broken on this release use this opportunity to remove DEFERRED
>> state.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Matan Azrad <matan@mellanox.com>

Applied to dpdk-next-net/master, thanks.