From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7922DA0559; Tue, 17 Mar 2020 09:34:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C40E2BF9; Tue, 17 Mar 2020 09:34:45 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40075.outbound.protection.outlook.com [40.107.4.75]) by dpdk.org (Postfix) with ESMTP id D3371292D for ; Tue, 17 Mar 2020 09:34:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9K1WGXLyPP3Abkn16p7GO1HkJozq17I8r5qCOxZSJj4HUePXyujeoomHWhXQsSP1GfgQVMC4pxIdmw+rR+wgns9QDRJ4/YkqhwSH09NQ3oYBtwL80LsdE0uCrkpW9IOs4r1v1S1Z0QYdV8KraDV1vrSKl9rSS3bq67/pJEuTfPr8pNMN0p7LHwkZBGS601rky5GD2LbSZjpGgsF56lXUwbb9Pv5HsNJRarKTwyahvNgsWmp6xuXPuuxGeliIUZb9oCJgZhVlWfhSGytL48Q7Ymj+lCWNALUecSi9hhaX27vWAGRqHQ8s2MfT28UpcMZw3KFv5wLbC/kIZVGW0vHjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JlMqDLFWJJNHc1a6+p+JtLxIW47Ho2hFd8vbUpnoJGk=; b=EkNpSFZAEtwE1LRAAuGzn2xhfOm6fESGr1l8Vxk4i56xRO8BCFzrkcWtbrYVsUci/fQm8ZnTyfGFZSHZ7LK5LCnqPz1eFJOInZkYkSw8ov7RYZvTIFQc/zwuWTOKxIbMkTl3JeFGVJ8wEruBjeByq2v8cQjh9blJCBUwp6Jn0dSPo+MEpsmfCpk0GVqSYT3RDl3lXTvEq7PmNq9lwBuZ8MuRGnLiQlFMLqr1Nmrl6YFSP3vT55RJ3NevXUCNvqoo9wcmaQJIoA/ozrJBPiUu5EwBBXKf0TgWRsCG2c4MCM2RqdHl/+oMDLdCV5nwsO5I1TEkzu2nnjUGbF79WUipkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JlMqDLFWJJNHc1a6+p+JtLxIW47Ho2hFd8vbUpnoJGk=; b=c8LOWiTtm/fZGvgga1+JG2NFPo9wJ+tT6q9yoYQg6zJstSDwxdx7PtSkNY4s0RcHD0yGB4EJuY+aYfyw7WPt5CVTq0jxKMNK3Y+Xu+oFvpjYUnalbZCYnKfHxiVUHta1ALSt1N1OKRXFfKlBC2TXdRnPOxrCo6OyeeaFiftVv7k= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3763.eurprd05.prod.outlook.com (52.133.50.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.21; Tue, 17 Mar 2020 08:34:42 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee%7]) with mapi id 15.20.2814.019; Tue, 17 Mar 2020 08:34:42 +0000 From: Matan Azrad To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10) Thread-Index: AQHV3/1lBoiJmnQgK0u/piW0Z0bj+qhMraJw Date: Tue, 17 Mar 2020 08:34:42 +0000 Message-ID: References: <20200210103216.1168439-1-thomas@monjalon.net> In-Reply-To: <20200210103216.1168439-1-thomas@monjalon.net> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.125.85.240] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: beac64a0-5387-4e08-9456-08d7ca4e0a87 x-ms-traffictypediagnostic: AM0PR0502MB3763: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(199004)(66946007)(8676002)(52536014)(76116006)(81156014)(81166006)(8936002)(478600001)(55016002)(9686003)(86362001)(33656002)(2906002)(7696005)(316002)(110136005)(186003)(26005)(71200400001)(66556008)(64756008)(66476007)(66446008)(6506007)(5660300002)(4744005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3763; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C0+UbVr9iovpqgvoNHvqh4fkC5Ifmr50xsjfq2CnK9cwuksYNo2DrwKOJ3Ss7yisMZQBE8YIcdO96UAR12CNTrZEAmrIedTRoTGPM+AeX+QjRJXSPUGiUTkWgIQpIkTPrlF0XtAAvayBeoiB1fedCha6FE9Srap2gyLuv6igAzYcDzpw15JmcdNVDlcDPze6JiMm7fKadTqiFhJpFImYts9YlM4dUWuX4Xh/iwPyfLOv1Curq5OJv9kXKQ4DTf6TfQHTdJtkaXYQCMo3RRqXQp4DDqGgpiaRvtYhbl2FasdqlewKg3VEufjmPHfyu1bmwng7bJBnI0v5VcyDrmf01/15MVN2iUSbXi0/Q/jmWUbBZY0uulqzxZbR4ZqioiVvYHu5MpZyFiYHZYZvMU5rOLvgbMnccvO/wecDM20Xthb+nbCF52KA+tnHvKZCiyN+ x-ms-exchange-antispam-messagedata: HmkZkTFJ7Mu1ro90mIHHzz7LLld3wZMxB/8hpSvqJVy+pzbiUE1fsUMXRlcIQHPVX55D5pCKNOcuWipv1YUen66YPvcpAOukc7huOH1uDps2mlo6xSpGsj0yVlfugydXy+qpy13mC+hr9CQZBOCykQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: beac64a0-5387-4e08-9456-08d7ca4e0a87 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2020 08:34:42.8722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Up5Qs723g+igr0D/VIvaQ7H8fx5G0g9E8tirmtebf6XKo24qYponiqk5QMwjsxTeXOtSM/urzsZuisnEt4Go1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3763 Subject: Re: [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Thomas Monjalon > In GCC 10, -fno-common will be the default. > There are 2 ways of solving issues: > - add -fcommon > - stop allocating variables in .h files >=20 > In this patchset, the variables are declared extern, because it is cleane= r > anyway. >=20 >=20 Series-acked-by: Matan Azrad > Thomas Monjalon (3): > common/mlx5: split glue initialization > common/mlx5: fix build with -fno-common > net/mlx4: fix build with -fno-common >=20 > drivers/common/mlx5/mlx5_common.c | 80 +++++++++++++++++++-------- > ---- > drivers/common/mlx5/mlx5_glue.h | 2 +- > drivers/net/mlx4/mlx4.c | 4 ++ > drivers/net/mlx4/mlx4_glue.h | 2 +- > drivers/net/mlx4/mlx4_rxtx.h | 2 +- > 5 files changed, 57 insertions(+), 33 deletions(-) >=20 > -- > 2.25.0