From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10070.outbound.protection.outlook.com [40.107.1.70]) by dpdk.org (Postfix) with ESMTP id 4AB1D2BF1 for ; Tue, 21 Aug 2018 17:48:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AEl92jmLUNTACtwj+E33JM0ijLDO2AwzUpfTv9EvbVs=; b=cnrldlOzAJHE04g98nk5P89Sgx6fxkvxtvUMsMezzHLdXMqoBEPZ40WtV7Bp0vWSPsfS+jMlAi2rAjnWWoHifDjDKblcfrbA/zf/vBIGJHbFtvjPtDBMoM85XdRr0ks7JBoC0zvSHcDelfegRYME+nyVKZ7qOLvzR6gh0CNnb2A= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.41.11) by AM0PR0502MB3905.eurprd05.prod.outlook.com (52.133.48.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.20; Tue, 21 Aug 2018 15:48:19 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::88fa:4498:85a5:9e5a]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::88fa:4498:85a5:9e5a%3]) with mapi id 15.20.1080.010; Tue, 21 Aug 2018 15:48:19 +0000 From: Matan Azrad To: Stephen Hemminger CC: "dev@dpdk.org" , Stephen Hemminger Thread-Topic: [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool Thread-Index: AQHUNbKq3SjE2Sv8E0Sncjc15GRqW6TKAXNwgABUTACAAArOAA== Date: Tue, 21 Aug 2018 15:48:19 +0000 Message-ID: References: <20180814001926.19630-1-stephen@networkplumber.org> <20180816224409.5719-1-stephen@networkplumber.org> <20180816224409.5719-3-stephen@networkplumber.org> <20180821080644.306bba69@xeon-e3> In-Reply-To: <20180821080644.306bba69@xeon-e3> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0502MB3905; 6:buo2jLXK9hyE1V6w20quyxMpUYaSjujg2Px4LFp8+aj5hp23QbVocYVRCOJhdR/QZ1mu9ju7Tb4XEoMm0cJwPFh8T8Plqujssntz+20DpIWuU10i1Org/A2TXoej/wstqnBxLWxb0HacMA7Z5Uq9NclvJ1I4AFdluC5EQS/0Tutb+ksKVgolfj1YjSpXH2OimBRqOyAve9d5FOGDFvzbhLWfXPUX2i8FHjE5SqfaNdNJ6Qs98lFfUmtgJLP6ZCc9eA3Nr3oTNx+D2uAzVdABQcuEMWd++v2/AuSG6jqLs+al/0DzPYoly3rMy99nclG81DZd5YDYi+9a3vUVScrciN4LUjILsmPiwIvKfrP4UyCRW5F3B/WM1hYXq6w1V7X52I1xU9kxHDMlD1DrxFUIQgzGW8/ioR3CEUOFYh+9iJW6Jx3XJ0nx7ar335I1u28sr+Spo8bRQooJT4Bq5PQOGQ==; 5:KFvzj2I/TS5EKrV7P/Q/JRG0oComvd66L1+Eenzcmh27a8WN5BWpQUcKcFFaOpTM+K8aeDH5s4s3cSgSoQ3leHxoNxuNW6SpEWrTTcUnI0XkmonmGtEwz3UvIhpF3dZlddzUf1ZEn00x7ggXManhGRP8COegm592qmyaFPBJFMw=; 7:W+zvnxoYbKB4anFByPLUU/4vCFT2VHMgev0P8QNGyogR+yyVcgzJWJWbv6SxH+tnKgHGg50LPNkJBgR3zTfACyauj+WKX1eqScDc6bOQeS+roJb4tCFXm2bzgxQaORA5o5UXT+Ueg3Ry/RNuX67Sl1Lthu/crMfI/AmvtbVQ+IcXEmW/Jp4vxKYuVp6xC6Is2LNmpvbPfIgXOosuYA3kbVrd78+vEE44siDihfdyOSUFyathXE5qowecVv/3qpjr x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2dcc9881-d11d-4203-cb59-08d6077d8482 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB3905; x-ms-traffictypediagnostic: AM0PR0502MB3905: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(201708071742011)(7699016); SRVR:AM0PR0502MB3905; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB3905; x-forefront-prvs: 0771670921 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(376002)(346002)(366004)(136003)(189003)(199004)(305945005)(3846002)(7736002)(6436002)(33656002)(8676002)(81166006)(7696005)(6246003)(9686003)(53936002)(76176011)(81156014)(6116002)(5250100002)(6916009)(86362001)(8936002)(106356001)(93886005)(256004)(2906002)(68736007)(74316002)(229853002)(105586002)(55016002)(14454004)(5660300001)(11346002)(6506007)(2900100001)(446003)(26005)(186003)(102836004)(476003)(486006)(97736004)(478600001)(99286004)(54906003)(66066001)(316002)(25786009)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3905; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: NNuMNA2fS6rtS7+LDfUy2Bs4P9yD1t75NtbSaD5df62S8HaI32DmYQcPfKtVrxa6SgrLp7wHoBwB2f27xV+KY77+JR+JxqMzREgvVfV5aqAXj9AofBhxrcJ13/y074XqOqMypCaW0uK/AbOFM0Zjc4Lj9iiKAWT8v8/0PjT+TdGFsv98G2Qk12ribCe/rYmFK1SY2HZYAZ2YZSszP49BqNr1WXOZH36un7tAyEXEaZ1cDAcoRlU7HOX5Foux+qVJYA00m1VKC5hrhxaZQJbASBVg6WfVRvH/ngPourkG9/OXScVo7agx/881+meB2+Wany4OYhxgbRokUIs+vz/sL/9UwfxAwElW5JLtZgeVo18= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2dcc9881-d11d-4203-cb59-08d6077d8482 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2018 15:48:19.3724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3905 Subject: Re: [dpdk-dev] [PATCH 2/2] ethdev: make rte_eth_is_valid_owner_id return bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 15:48:21 -0000 Hi From: Stephen Hemminger > On Tue, 21 Aug 2018 10:20:43 +0000 > Matan Azrad wrote: >=20 > > From: Stephen Hemminger > > > Function is boolean so use that. > > > > Ethdev is not using bool type, see also: > > rte_eth_dev_is_valid_port > > rte_eth_dev_is_removed > > rte_eth_dev_pool_ops_supported > > > > I think it should be a full solution to all. > > > > > Signed-off-by: Stephen Hemminger >=20 > I didn't want change type of visible (exported by ABI) functions. >=20 Since ethdev now is not using bool type I think it's better not to change i= t only for this API.