From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 860C0A04EF; Tue, 2 Jun 2020 08:49:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11B201BF78; Tue, 2 Jun 2020 08:49:04 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by dpdk.org (Postfix) with ESMTP id A3D051BF75 for ; Tue, 2 Jun 2020 08:49:02 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0qXxyIkAM4UQkygl07ZHuYcfkzhFWsfoSJ9LYHDJ/tolwcHUIEEDmAouOvsXdOlGxBQmrTDscLECSdHF3kaGY6RIu2Q3lElFqwoSaVt1LaMZ3Zhr+1jrr1HnlOtbU+Z6D/uyflCFCieGYsXFVfI1j+MWDDBIUS90gCHDYCE3CMAjwy/K4aWiaZdQ9Mu1rDuyVJxrWBR/CYpu/gT+0dZHAdoCMawPYMtGJUVAuk9olS12zVSkzLQ6CuoOhB304ecM0LCc6EOStpj7coIku3blJcR2bmK7PMdlSYJXcHDhDY040xYZqLIQ6qToIthldlIA43IWvG3nouuyRBJ6xJ8Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lIGhFF9TN2ZCjlT9zOPszxFTGaqwBxkoXLl+E6PnkbE=; b=b681LUmqsS3zDBxSEd3wyJOpg4hIsIYhFuBnRMzj5VXjjR3eD6RexFLyyXyv9veeHIao4TTRVQDI+uos/26dK5Pw4rXV9cN5opXqUMDN772iNfYhRHiwlGAkMP+JKBk6SM/OCfRtmXjtODfFbvU6pcl+ESTxjshthBsJrWcCzHK5SfavPeqscA3iPbTS2we+Nz3u4uusiROHxRVpUKPiUB+BIcL3n8kvxFDi4r2Ukus8puB80tJZKpI8p65md1/zYewy08S8yDLYb02wb5pFF+bhdOSuqb/0ieQO/0/Q24hxa6uA9ICVXZfjkY+t7+m8oiA6gJ4hRiXDV6FmodqJ7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lIGhFF9TN2ZCjlT9zOPszxFTGaqwBxkoXLl+E6PnkbE=; b=rxJoEPSLYE7B4DWAJhQjF9XQlcsM1GZoncgAo6DE2CnD8sJ6SeyM8bnQsNLqXulaGqolkWSealq82CHUgydETXsZ/lkazOuMbB/38zeKpMw18UW1S7+RAWhsEr5K+I+4V45+UJV8kwSdsnjzOd0jq7VTMhvpSVgOYtiNhzs533o= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB3889.eurprd05.prod.outlook.com (2603:10a6:208:17::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.21; Tue, 2 Jun 2020 06:49:01 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::b189:d782:4c74:7998%7]) with mapi id 15.20.3045.024; Tue, 2 Jun 2020 06:49:01 +0000 From: Matan Azrad To: Thomas Monjalon , Andrew Rybchenko , Olivier Matz , Maxime Coquelin CC: "dev@dpdk.org" , Ferruh Yigit , Konstantin Ananyev Thread-Topic: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO Thread-Index: AQHVTINRkilMoGiC8EGiUIfENlBOHab07O+AgcTD1oCADQnG8A== Date: Tue, 2 Jun 2020 06:49:01 +0000 Message-ID: References: <1565103383-23864-1-git-send-email-matan@mellanox.com> <229e9a7b-2603-698c-d687-f7755f40bf58@solarflare.com> <4359580.12Q4qOoiY3@xps> <3071401.IZAg4H9azB@thomas> In-Reply-To: <3071401.IZAg4H9azB@thomas> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [87.68.154.208] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8eedaf19-515e-4375-c30a-08d806c10876 x-ms-traffictypediagnostic: AM0PR0502MB3889: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0422860ED4 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vt/WZQywHgmgO70CxvWmlOxkdteh1+Jgw1EuTZ/uadprdNWsqMI6DJcf3RpTkI2MpO/gPG040/TLcgOdFlys7QA2wKTlbEdv03BHz+XV8NVc26ehF3gVpac4QtCbupuH8/h0iC3SNEdRxwRUu4xBvdClKuqxPO1zACnmX/pXKzty2RrdCJ/qICXqKzIIQLPY349Ry7kQY/l2NFyH3nZGb1I/H5eTnmQhLZP/K7EmWviy0yiax2ftXS2XdSFbHkgF1pAztZp0H1ImHORCdoozZKvjQtPLjO4aYGIqyt4486dGX5w5KtaJesVOP0V2ZaxPMq3Jq3TwXgZLCkgoNNfgow== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(66446008)(66556008)(66946007)(64756008)(66476007)(7696005)(71200400001)(9686003)(76116006)(110136005)(54906003)(8936002)(83380400001)(86362001)(8676002)(55016002)(5660300002)(316002)(2906002)(33656002)(26005)(186003)(478600001)(4326008)(53546011)(6506007)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 4I7kJG3vkhtRshntMvhPV5JtOJPPL4403g5jZghXXVC+qSoFNOj0iddhI8qL5ODlj0jPeAEXc4RgTWqvFxoQq9jKQFm+Q8OY+UkJIboWOoJsyfa2E3HowvgWz/BFlP8ZDy5wAXPdbEA833n7f887rT+gmeHRDu5huvop7fp+iy25VrbrQTO9cTKEbasfK/iMJmpymYQGVnImQwQPRQKTDE5UXDoLaDLgHShw7svc5WBZUB4NNK3cEAKIgjkdjM88PplSra83k+yhp4JaoS4aEoInU8zR+sUmC/VjG1+ZeI4X8aeDfYNcM15BRJiatDUsLdsM4/F2nTTHlPeVFNpXeuBC7eTeRx0H1QrFnSLfbE5i4EmU29jTN/TeQwxxxLAAkMbZWaVLTsWDQMdZ3dqmDePKVWkqqtGxho7jspHyaLQxn3sveL4SkqluT2KW5Nc6dUiO3xcb7DNmyO5PHnbVDW7Tl+txBETAQSZCwD0RgdGiDdtratAm4i8G0ARjLpf/ x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8eedaf19-515e-4375-c30a-08d806c10876 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2020 06:49:01.1541 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eGGBkckp0HWX9bchFUwO6mo1j4sSjx+mwHVtLIEuxPl0aj6A7j/RTkUP76xhlzVlYaIRrUNtdFbHNVY6wgz13Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3889 Subject: Re: [dpdk-dev] [PATCH 2/2] doc: announce new mbuf field for LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi From: Thomas Monjalon > 10/08/2019 23:31, Thomas Monjalon: > > 06/08/2019 20:17, Andrew Rybchenko: > > > On 8/6/19 5:56 PM, Matan Azrad wrote: > > > > The API breakage is because the ``tso_segsz`` field was documented > > > > for LRO. > > > > > > > > The ``tso_segsz`` field in mbuf indicates the size of each segment > > > > in the LRO packet in Rx path and should be provided by the LRO > > > > packet port. > > > > > > > > While the generic LRO packet may aggregate different segments > > > > sizes in one packet, it is impossible to expose this information > > > > for each segment by one field and it doesn't make sense to expose > > > > all the segments sizes in the mbuf. > > > > > > > > A new field may be added as union with the above field to expose > > > > the number of segments aggregated in the LRO packet. > > > > > > > > Signed-off-by: Matan Azrad > > > > --- > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > +* mbuf: Remove ``tso_segsz`` mbuf field providing for LRO > > > > +support. Use union > > > > + block for the field memory to be shared with a new field > > > > +``lro_segs_n`` > > > > + indicates the number of segments aggregated in the LRO packet. > > > > > > I think that the number of segments is more logical in the case of LR= O. > > > The question (already asked by Konstantin) is why it is needed at > > > all (statistics?). If so, it still makes sense. > > > > > > Segment size is misleading here, since not all segments could be the > > > same size. So, > > > > > > Acked-by: Andrew Rybchenko > > > > > > As far as I can see bnxt and qede do not fill it in. > > > mlx5 and vmxnet3 have the number of segments (vmxnet3 has segment > > > size sometimes and sometimes use a function to guess the value). > > > So both will win from the change. > > > It looks like virtio does not have number of segments. CC Maxime to > > > comment. > > > > I support improving the API for LRO. > > Unfortunately, the consensus is not strong enough at the moment. >=20 > We had no progress about LRO field in mbuf. > Is it a change we would like to have in 20.11? >=20 +1 to make the change.