From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by dpdk.org (Postfix) with ESMTP id BD5FA1B465 for ; Thu, 2 Aug 2018 12:21:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kq8J1li5U4G4z++2UyCa3katl3acV1eeVlFGgBMyTPo=; b=gtwr2UuNZhcFfbwt4Wo0B23OWZdYtqZT7FqlsecytUGxxznO05vJmnpXGcWcHNFFYsyX7DX7tv3gA5Vg4fyKT3VWa/9UWASUCJ22YCNvntpES7IrbQQoBN5nNqyKbfSLhJ8kzW8x/w7ijEr17sYCHklDQ8GnpLWS08FxovOsq50= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.41.11) by AM0PR0502MB4017.eurprd05.prod.outlook.com (52.133.40.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.21; Thu, 2 Aug 2018 10:21:13 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::9d98:d47f:5b50:1f49]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::9d98:d47f:5b50:1f49%2]) with mapi id 15.20.0995.020; Thu, 2 Aug 2018 10:21:13 +0000 From: Matan Azrad To: Radu Nicolau , "dev@dpdk.org" CC: "declan.doherty@intel.com" , "chas3@att.com" Thread-Topic: [PATCH v2 1/2] net/bonding: in 8023ad mode enable all multicast rather than promiscuous Thread-Index: AQHUKkggGsMR2eJTckWYXWdrKKNLM6SsPqtA Date: Thu, 2 Aug 2018 10:21:13 +0000 Message-ID: References: <1533128278-4685-1-git-send-email-radu.nicolau@intel.com> <1533203824-14430-1-git-send-email-radu.nicolau@intel.com> In-Reply-To: <1533203824-14430-1-git-send-email-radu.nicolau@intel.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0502MB4017; 6:gL3DvywLGHI7UMgthu0Dq3N45XRNQBGKsjrrzzq1ZrdpVRhB0DJoDSUF7qIL+NsoZX178DuIrePxx4LXN4lRo0EEznWrajE65j5URg8p0TKz+iVF6N0/oDwZTjG1cfsOmcZLrDejx40SlPuko6dniHdgxz2Q9GmKsWjymz4zYCQhCiT5kyGgVCOf2KuSRSodoQQbBo/7H6TyQ+XKE96kCUm3DP4Yl0p3W35Bj4HPK846MqqOiDMLj5G1P3kIf4QbKMvAuctrNUAcLJNoBiXYqP4nLDDznf64rcyi7Tn6sj6FcoIGJRgM6YgleX1u4KyM7ICPN3/k+Aa1eIcW36Vv2Ya0mHi7FwrVh4rMhSvVuxaYGcjaVBLUF/NGXhuEJclbAA5LLdBGrIR1w7f1m3Vx5nsProYtCy89ZyzwEiBtoA2TmN2Yt+4wPWnFU/ukme+FMxquMC3GrMUg2hpW5ki3ig==; 5:vMWozR/x9XIo4n/3iijuvZEcEsqxEreUzbNzwp4sPGlzpq8UILAqnkeqikBEy8OmREk3WXFC/JffvNgOr5GJNAb9Nlx12ZSgiNCJBeInsL4RDn9k6Nafh5laEiqcOywsl+/tHlVsNjBIGZ1ukoiSwYMn3z/AXcVfnhwIljcV0r0=; 7:oQUXMV8NGbdQ64zpLNmim0bjopPcnssrT+GeC/CuqTRZ0FFv9iLhgl93f2LKN/mbi9yVpXU1D8zUqp9Bs1DC47bRznAJFgupB/A9fVlAjEsV5Vhqe4zIkA9mY/T7EronGaJ1xrxQPkn0hLO0Uy99LowI+ndzNY4zWfi87tsZw79Bd6JGHanXrsceeo+5/GgEDpzfu3jEFge9o7zBhkoVTvZh9YecrQjIUIpBeC6Rb6NvqJC5tKVjWtwM+FxxXX+X x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d6c0028a-1fb6-4078-d4b5-08d5f861acc8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR0502MB4017; x-ms-traffictypediagnostic: AM0PR0502MB4017: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM0PR0502MB4017; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0502MB4017; x-forefront-prvs: 07521929C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(376002)(136003)(39860400002)(199004)(189003)(476003)(186003)(14444005)(5660300001)(316002)(81166006)(33656002)(68736007)(54906003)(110136005)(8676002)(81156014)(99286004)(486006)(26005)(256004)(76176011)(2906002)(7736002)(8936002)(25786009)(2900100001)(74316002)(4326008)(6506007)(5250100002)(6436002)(229853002)(105586002)(106356001)(305945005)(53936002)(478600001)(446003)(14454004)(66066001)(97736004)(55016002)(102836004)(86362001)(6116002)(7696005)(6246003)(11346002)(3846002)(9686003)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB4017; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ObEOiNkH5T8K0bWLHmlBCuwnhhBQ6ihukMsaZAdJOQgaXhiHiv1UW/GK6IRxZXmNXFdmNaWcwGXEqEMhb+RpuIBV52H84fNi5ulbFnhP+wp874Enp98FVXMTpN+c2/iPEfqB5jWXPpHWoneH+EOwNgU8PpEFhHdzCexRU3sCp7zHHqh40Y5s4YOmWhA8fIphq5srEYgUkDiZJg1fGuNbrxbP7KLx7eGqwsoX4h6coUmOR3T0v+RBPGSRc/HagvvPVYQKuZGOdAWdM1S5g0uNiAauMYDMVsssoyHNctNMJdo395ZMPf+FQGQQn2eMXqnHSyd3IQIT+1aGkCHmlYfuYY40b84Q1SzM7BI31RmbIfo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6c0028a-1fb6-4078-d4b5-08d5f861acc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2018 10:21:13.6214 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB4017 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/bonding: in 8023ad mode enable all multicast rather than promiscuous X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 10:21:15 -0000 Hi Radu From: Radu Nicolau > Signed-off-by: Radu Nicolau > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > index f8cea4b..730087f 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -917,7 +917,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev > *bond_dev, > }; >=20 > char mem_name[RTE_ETH_NAME_MAX_LEN]; > - int socket_id; > + int socket_id, ret; > unsigned element_size; > uint32_t total_tx_desc; > struct bond_tx_queue *bd_tx_q; > @@ -942,7 +942,12 @@ bond_mode_8023ad_activate_slave(struct > rte_eth_dev *bond_dev, >=20 > /* use this port as agregator */ > port->aggregator_port_id =3D slave_id; > - rte_eth_promiscuous_enable(slave_id); > + > + /* try to enable multicast, if fail set promiscuous */ > + rte_eth_allmulticast_enable(slave_id); > + ret =3D rte_eth_allmulticast_get(slave_id); > + if (ret !=3D 1) > + rte_eth_promiscuous_enable(slave_id); It is still greedy to configure allmulticast for LACP, The user may not expect to get multicast traffic. Moreover, here each slave can be with different unexpected configuration, m= ay be even worst from the application perspective. >=20 > timer_cancel(&port->warning_timer); >=20 > -- > 2.7.5