From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4EB9A059F; Fri, 10 Apr 2020 15:54:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 051CD1D15B; Fri, 10 Apr 2020 15:54:23 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80081.outbound.protection.outlook.com [40.107.8.81]) by dpdk.org (Postfix) with ESMTP id 140921D158 for ; Fri, 10 Apr 2020 15:54:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nX5hmczd+H5EcAD7FzfS5Kt8yLgy9jlDOcD+pUG7RtonlmFT4lIe1syUdA+ZVjtdJD7j9ZN59HjhgO7126/U26qwIk8ioMxH0+EBrQRQqlqD/3g6dFM75UAnvuX4xwnjd8SS+hcXxLHtiNys6k2afoMhGEGhyUX2czrXEuUrHe0uRwL58Y97LDuxuQjZHXwsWQhyemIy7ABQ6GQHPn710SIA1g/lQF7zuDaLwLQC3wcb/uDfqTLfyiOY/xm1KYpr39F4yao55Hx5h9Y9g5sBk/5aMeaqusra3Zb7gdAcMvhYxtC5H1cVDNGLj5lfVZ+AJtl48TGbs9+7xBz18N7AtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnsMv/kM4XzK6HOiZQUpXY/Fbi8y119hgCompDwxyhc=; b=Vj3OPPy+vWq5cXHJIF3gZl4Hh2nnk+1HjnN2S7cdd3kUUeNxk/56r9pxQ+/reWWft+jxUyRVEUZbfDXnUNB1HHxhh23b3Q2v4UxAbFPUslJ3/+eYvT2SGkBMCt9xrjA+rN6fGXiEXNqJY4VsIHTfTN4ksvkB/UAhEnZ8MRLEOYgOJm36QfYwJ+wlOqUwNwb8/vjb4mM8l2eWyC+kkfQnGvnz/XGp7Fa90ClQdEBvGTSVozA7jsjxO/QhMyJX5h6Z1hhUjsinAXFTUEQs2KbEkMYXipIVQC8b5SJ9C78wldsGeVaH3sNaXv+EuqajEjEwQCGD9AgzlWanGvaQO9JuZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NnsMv/kM4XzK6HOiZQUpXY/Fbi8y119hgCompDwxyhc=; b=QohcD+EqjXbGUOjF7cxs4hcE++/zgZrA9r5Py08GivfG0mj4/XImyUrwNhCwtWj4YfjLZkRoEQospJC/o2Tip/QRvD5mKTltyVvbUFIcZRaDW1rAVzHL+KfBWpQISoqI5vBmuM10XWT6gjcxAMsU+3YXm7ga3fEtYUUapUbyqZY= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB3986.eurprd05.prod.outlook.com (2603:10a6:208:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.23; Fri, 10 Apr 2020 13:54:20 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee%7]) with mapi id 15.20.2878.022; Fri, 10 Apr 2020 13:54:20 +0000 From: Matan Azrad To: Maxime Coquelin , "dev@dpdk.org" CC: Slava Ovsiienko , Shahaf Shuler , Xiao Wang , Tiwei Bie Thread-Topic: [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats Thread-Index: AQHWDnv9y39aiT+frEu5KbXOgnIV0KhyXfDg Date: Fri, 10 Apr 2020 13:54:20 +0000 Message-ID: References: <1584371573-4243-1-git-send-email-matan@mellanox.com> In-Reply-To: Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.126.88.104] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b8fa61be-256e-48a8-7cbd-08d7dd56ab6a x-ms-traffictypediagnostic: AM0PR0502MB3986:|AM0PR0502MB3986: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(8936002)(186003)(478600001)(8676002)(81156014)(316002)(6506007)(54906003)(110136005)(26005)(71200400001)(53546011)(4744005)(7696005)(5660300002)(2906002)(52536014)(76116006)(66476007)(64756008)(66446008)(66556008)(9686003)(55016002)(33656002)(86362001)(66946007)(4326008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TmnHn044corJfpGH7DOZd73IYxM9F0vR9SiS9eHdq+mb8XR/ULfb2YgciHKJoIeYp0k3dQCYxFlXpKtgc0jDK5Wm7Y6Gob+egcKFTlKib5FsASKtO1WxPwvq9FiprI0gHXcTpjlZuGxth5xvourF2myL3Ldsmc9KfzyWJfpgO6kvgDkGEoMk3dtm/vOWMCR+/jRFhkUHddAzl0rqqqRjqE+lNgWFWswJpJJZGIBxeivvHy7N+qtL4ZFz3hrirvQoNfsbMpe7c10Wr720Rl5UbBIqfEmUF2tqX2oHS2k6yQc/R5ZlafWCGoCRByQY/mdH9tP+r58sLaQzbrZKqlE7egsr+QoDd6xSev94zlbDXsVbyNiA32cK3etDOa141Zx2KdLV5ip9rW98oWGaoB9A0O/R7cO2JdO8j5z2Ov+IrlAO17STdGw0PMjDSqlUiwzX x-ms-exchange-antispam-messagedata: omdTpGUxHJzt1a8z4prEgAUtekizyt63UlXAX7Q9cYytDtAVeoz6mk0TrChZA7by2Iqjwnu6Td/vnujUh/Tks/WsfXY78kMtZQzdDuG4vWker02q0k19mLtlT5udZOaWVctY41e1ZtYPgs4o1iDaCQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fa61be-256e-48a8-7cbd-08d7dd56ab6a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 13:54:20.8043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dTUpE1MbfesEXVZjbkkt3FQVEkkJjN3lZ1UWWwXETSxSyP4Po23SApCVWJyCeF9mwWz3nsmV106eNR5L87Gyvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3986 Subject: Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Maxime From: Maxime Coquelin > Hi Matan, >=20 > On 3/16/20 4:12 PM, Matan Azrad wrote: > > The vDPA device offloads all the datapath of the vhost device to the > > HW device. > > > > In order to expose to the user traffic information this patch > > introduce new API to get traffic statistics per virtio queue. > > > > The statistics are taken directly from the vDPA driver managing the HW > > device. >=20 > Shouldn't the stats be collected from the PF like for "legacy" SR-IOV via= the > sysfs? > Something like: > /sys/class/net//device/sriov//stats/ Yes, probably, statistics can be taken from sysfs. But we are introducing a DPDK API to get the virtio statistics. So, driver which can take statistics from there can take them from sysfs in= the driver operation. =20 In addition, the API includes per virtio queue statistics and in virtio dat= a-path terms, it is very helpful for debuggability.=20 > Regards, > Maxime