From: Matan Azrad <matan@mellanox.com>
To: Suanming Mou <suanmingm@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
Raslan Darawsheh <rasland@mellanox.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix meter header modify before decap issue
Date: Wed, 12 Feb 2020 14:13:46 +0000 [thread overview]
Message-ID: <AM0PR0502MB401959BC285A0BC5263C0E07D21B0@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1580962467-159286-1-git-send-email-suanmingm@mellanox.com>
From: Suanming Mou
> The meter flows are split into three subflows each, the prefix subflow with
> meter action color the packet, the meter subflow filters out the colored
> packets, the suffix subflow applies all the remaining actions to the passed
> packets. The tag header modify action is added to the prefix subflow to make
> the suffix subflow to match the packets from the prefix subflow.
>
> Currently, the tag header modify action is added at the beginning in the
> prefix subflow even before decap action. The header modify action does not
> make sense to the later decap action, so the flow create will be validated as
> incorrect flow rule and failed.
>
> Move the tag header modify action just before meter action in the prefix
> subflow to make the flow with decap action to do the decap first, then do
> the tag and meter to fix that issue.
>
> Fixes: 9ea9b049a960 ("net/mlx5: split meter flow")
> Cc: stable@dpdk.org
>
> Reported-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
next prev parent reply other threads:[~2020-02-12 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 4:14 Suanming Mou
2020-02-12 14:13 ` Matan Azrad [this message]
2020-02-12 15:03 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB401959BC285A0BC5263C0E07D21B0@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=suanmingm@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).