From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 649FFA0534; Wed, 12 Feb 2020 15:13:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40A3B2BF4; Wed, 12 Feb 2020 15:13:50 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45]) by dpdk.org (Postfix) with ESMTP id 25A631B53; Wed, 12 Feb 2020 15:13:48 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IR+NfwkEUDv2fe+cBWFG+zmi1r3aQJzSp41v4eTjMLNR08Ds+SLz6tJG2ug4gYs7seLqtFzvtva2mFCL28/n+wf4zFyaQUSkp3RKbKPloXa5689qGzfbC0mN/Nj9lz5EyHhiUxZWzZ0/83qR0xow94zI7NYEWMfYN7Etqarc7Y/+Uyibte2m9YUgGsuqg/+U3y4fBotQnDmAN+/7067SdTZcz6OiV+50xpXH/klXR0MGW7g0eme3I8AtL5PH7Ri7ve+4fVsiDH65TpuO5DGujA6fftZMoEnO5f0mMl2RO+bTJ+xEqWODUicREFQj/08/eQcJ4Qq1O3ZzimXPxcLuCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cmFXcHh49zjQrvTHDIVtOKiM2bP/JVhwrWjqJo56XWY=; b=WnUjRIZvNg0WRSF7JRBuo6Wpq61tDDFa5gqTa5N7pEAZqy4LzV2hL6MmkpTcGngSS2q9u/PTejiBYlbsEusuLUWV32yIjeQLdH9UajbDhG8VrtvxkaLg6jEGPX1kgmNBfnRSAiYUiNbirZA4dJ5A0t9eVbTTV5TOnG32h8as7EiF8mESIjLQqQrgxFfSTUpS54S5ceyh8rzfrQdgX7gazeIlKMfaJuga1iaIujeyZrAWBaPKh/TyDxoIVf/Kp+CdUh9Yrx/lqPn5LvRtyZ1er3UybvJV5n0bM7hJBkzCM52Clygpti9ri1HDPHKWb5vzFlZX4X7Nu4p1YBNnYOivRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cmFXcHh49zjQrvTHDIVtOKiM2bP/JVhwrWjqJo56XWY=; b=A1Ea9foSTdp7j2QR6P5pIW/BPr1caLHhuWtwPq7AZEBQvp1bdz0Rk+tu5JJH1p0cddrTE4x4rdovftR9fk35+2oQd4Eh/7/eKQfdr1f2kIPElcMYcI23LH1dhCgWP6K4CTPLkc0azTcsXKQj8YeDVVIJl6L9YCQE5kqLJ0ko3fs= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3828.eurprd05.prod.outlook.com (52.133.47.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Wed, 12 Feb 2020 14:13:46 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8%7]) with mapi id 15.20.2707.030; Wed, 12 Feb 2020 14:13:46 +0000 From: Matan Azrad To: Suanming Mou , Shahaf Shuler , Slava Ovsiienko CC: "dev@dpdk.org" , "xiangxia.m.yue@gmail.com" , Raslan Darawsheh , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix meter header modify before decap issue Thread-Index: AQHV3KPwIcYFL1Hd70uh2oF9OH/UHKgXo93g Date: Wed, 12 Feb 2020 14:13:46 +0000 Message-ID: References: <1580962467-159286-1-git-send-email-suanmingm@mellanox.com> In-Reply-To: <1580962467-159286-1-git-send-email-suanmingm@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2c266c80-32ae-4faf-fa2a-08d7afc5c621 x-ms-traffictypediagnostic: AM0PR0502MB3828:|AM0PR0502MB3828: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0311124FA9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(189003)(199004)(5660300002)(52536014)(71200400001)(110136005)(26005)(86362001)(6636002)(54906003)(478600001)(6506007)(55016002)(9686003)(8676002)(8936002)(33656002)(316002)(186003)(66946007)(64756008)(66446008)(81156014)(66476007)(7696005)(66556008)(4326008)(2906002)(81166006)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3828; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oHGdNTT7awvwunl7gg/OlDApSaDxYXPLfsNecAsXk4f6JdPu24lonyQOvJ17gkZCEym9gtbOFzL7rEHfeHyJWkPLcMxN4eiTObxV/9iVajQhpFmYvQqpge/28VViSM9zFw0hxWEXd1mWSvy++T+AoXmRlZBhFNVa1h2MCIK9B4kpBG09HPYX1pKVuDlBOadhLgdlz0DGSikRDOtWWt4Anaajw3T1OR3dKki1SFxhoLdWuOYk32f8Ia9wdwH/K6eAYiovktcZ8ykL/mfk9KhDjVaqNgH8PLn27PlcFA5NyV5UwZSLWeXvGflY9SzjKZ+SXbYy4ZAmJrjJ6Du9XVV9bExdzdiXCgqBk104U23oCU9wQPPV+Jhba4jjNs6p3Pi/YjjjQDWfZTWoRvT+5sZbQCdgKPgFegZcdcH8rSfHd/HrRVxbBLKE7mqZ3GdDJaiC x-ms-exchange-antispam-messagedata: DOSjbV1ReKhubKS8WxAlnTfc/u8w65fsq3mVMR1pU7g5WWq4CJ8KwAHz7qPNrNDu1zzb1OIAIG64glEY2tXvhsyZwUvthhl857PkF/YZhycexo32BWRuE18HyObqQ2bf90MLImj4+gN2tOsSfOYRRw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c266c80-32ae-4faf-fa2a-08d7afc5c621 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2020 14:13:46.2838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xrEivMu7YH6M4JBhx3JpGkDOXxYCawmhvbtjUGEaIoazYfgsz4SRSYF3tdLK3xKq7YEAZrbQRkJLocdP0UJ1Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3828 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix meter header modify before decap issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Suanming Mou > The meter flows are split into three subflows each, the prefix subflow wi= th > meter action color the packet, the meter subflow filters out the colored > packets, the suffix subflow applies all the remaining actions to the pass= ed > packets. The tag header modify action is added to the prefix subflow to m= ake > the suffix subflow to match the packets from the prefix subflow. >=20 > Currently, the tag header modify action is added at the beginning in the > prefix subflow even before decap action. The header modify action does no= t > make sense to the later decap action, so the flow create will be validate= d as > incorrect flow rule and failed. >=20 > Move the tag header modify action just before meter action in the prefix > subflow to make the flow with decap action to do the decap first, then do > the tag and meter to fix that issue. >=20 > Fixes: 9ea9b049a960 ("net/mlx5: split meter flow") > Cc: stable@dpdk.org >=20 > Reported-by: Tonghao Zhang > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko Acked-by: Matan Azrad