From: Matan Azrad <matan@mellanox.com>
To: "xiangxia.m.yue@gmail.com" <xiangxia.m.yue@gmail.com>,
Raslan Darawsheh <rasland@mellanox.com>,
Ali Alnubani <alialnu@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error
Date: Tue, 3 Mar 2020 07:15:42 +0000 [thread overview]
Message-ID: <AM0PR0502MB40196BE9909DBEC6F4F4483DD2E40@AM0PR0502MB4019.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1583146517-7079-1-git-send-email-xiangxia.m.yue@gmail.com>
Hi
From: xiangxia.m.yue@gmail.com
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5
> pmd, there is a building error.
> To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes.
>
> > mlx5_common.o: In function `mlx5_glue_init':
> > drivers/common/mlx5/mlx5_common.c:324: undefined reference to
> `dlclose'
>
> Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Tested-by: Ali Alnubani <alialnu@mellanox.com>
The title should point to the root cause - not to the results.
Something like:
common/mlx5: fix dynamic loading reference
> drivers/common/mlx5/mlx5_common.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/mlx5/mlx5_common.c
> b/drivers/common/mlx5/mlx5_common.c
> index 610fb48..570a3f4 100644
> --- a/drivers/common/mlx5/mlx5_common.c
> +++ b/drivers/common/mlx5/mlx5_common.c
> @@ -209,8 +209,6 @@ enum mlx5_class
> */
> RTE_INIT_PRIO(mlx5_glue_init, CLASS)
> {
> - void *handle = NULL;
> -
> /* Initialize common log type. */
> mlx5_common_logtype = rte_log_register("pmd.common.mlx5");
> if (mlx5_common_logtype >= 0)
> @@ -249,6 +247,7 @@ enum mlx5_class
> mlx5_glue_path(glue_path, sizeof(glue_path)) : ""),
> };
> unsigned int i = 0;
> + void *handle = NULL;
> void **sym;
> const char *dlmsg;
>
> @@ -320,8 +319,10 @@ enum mlx5_class
> mlx5_glue->fork_init();
> return;
> glue_error:
> +#ifdef RTE_IBVERBS_LINK_DLOPEN
> if (handle)
> dlclose(handle);
> +#endif
What's about " #include <dlfcn.h> " Is it compiled for you?
If so, why dlclose is not known on your setup?
> DRV_LOG(WARNING, "Cannot initialize MLX5 common due to
> missing"
> " run-time dependency on rdma-core libraries (libibverbs,"
> " libmlx5)");
> --
> 1.8.3.1
next prev parent reply other threads:[~2020-03-03 7:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:55 xiangxia.m.yue
2020-03-03 7:15 ` Matan Azrad [this message]
2020-03-04 13:55 ` Tonghao Zhang
2020-03-04 14:25 ` Matan Azrad
2020-03-04 15:13 ` Tonghao Zhang
2020-03-04 16:03 ` Matan Azrad
2020-03-05 6:59 ` Tonghao Zhang
2020-03-06 14:27 ` [dpdk-dev] [PATCH dpdk-dev v3] common/mlx5: fix dynamic loading reference xiangxia.m.yue
2020-03-08 6:39 ` Matan Azrad
2020-03-09 9:10 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB40196BE9909DBEC6F4F4483DD2E40@AM0PR0502MB4019.eurprd05.prod.outlook.com \
--to=matan@mellanox.com \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).