From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D5A3A056D; Tue, 3 Mar 2020 08:15:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D6DA01BFF9; Tue, 3 Mar 2020 08:15:44 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60062.outbound.protection.outlook.com [40.107.6.62]) by dpdk.org (Postfix) with ESMTP id 79C402C02; Tue, 3 Mar 2020 08:15:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ct0pKpHQhTRHXoK9BadSKHZSHUeFSX3/9OxS2DLDmOPTDRtQes8n2vxRL7FQEDxwimaZp1nzJ0t0CoDsn02xrkHKz7jhMYgxyj1VTU7s4JVxN7ny2FR6YrSPdoBAujxY+wU2z1s+ObjAzYkpiAG+gXfxjeGlZ2kGeeIs5x9K7gkEYDEN2eB4RrNYOFNkKAhNwDO67+eRicewxGdp6FWFWH0ZbD7MEtyFwya6h8Nm0dIg4z8BOj7Tn3CgfS4hUkRhKDTnFfTxlslR/NT/qLlImRXkuOeW1zZdw0zVlGXUJId4FnkR+PuLTmKs+SuvtfWQAVIm9r6BwASx17dMygYXCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p/o2c+UgoerLkbwwXVx7/1q8Mfy3O4K+2+C9+js4i7c=; b=HfRWU/D6drxeJVJhsRok0VeOO43mZZgAHjllBgAX7gyMwiwYj7XLovcEHYxDOuC7cy5ujf9nGxJdsGWl1nKqJf+LKhoDvTS/GgfiLYFuZk3Z+qx5vMPeNmTPb+mF4zfc7U8zxOkBM8IqwCho7V1AXLXwzmgtlhks9uXans6AMHCOFg0eqnIUGhd5byoLdDcVtjpu/4pQTKL5jZ3VcK/2A/8JxdSsWhiC2WzACho4eqy921dKGbIMcqO8MnoL+fDQDsSX/r33sw3ETJx6RFkPzbJapGEqIucMaP3fRpmNplCAjVrALdeFkJIDLPWlvBGHttz+5RY/G7lxUhCxqctsTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p/o2c+UgoerLkbwwXVx7/1q8Mfy3O4K+2+C9+js4i7c=; b=qHClCM8ygg8qASVIcgxmuzwRJm1uv4o+8ElwMPatDS/4WHlH4dFr3UpHa6RvWYMKfdjFc4g6COIh4sTksycHdA5QIrst7yCSnyZjM3SsBSifhjoj0cZPYiLj8/lc4DLNSyNYtzgU6fBmeGmSZNGoRGg75eXb+ehrufO4L1422U0= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3923.eurprd05.prod.outlook.com (52.133.48.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.16; Tue, 3 Mar 2020 07:15:42 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::e495:9258:db09:1de8%7]) with mapi id 15.20.2772.019; Tue, 3 Mar 2020 07:15:42 +0000 From: Matan Azrad To: "xiangxia.m.yue@gmail.com" , Raslan Darawsheh , Ali Alnubani CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH dpdk-dev v2] common/mlx5: fix possible building error Thread-Index: AQHV8IEVJ+yXsaz/fEKdfWo4uixCyqg2dJ2g Date: Tue, 3 Mar 2020 07:15:42 +0000 Message-ID: References: <1583146517-7079-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1583146517-7079-1-git-send-email-xiangxia.m.yue@gmail.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 0a25cd49-d235-47a1-c354-08d7bf42af11 x-ms-traffictypediagnostic: AM0PR0502MB3923:|AM0PR0502MB3923: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 03319F6FEF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(346002)(136003)(39860400002)(396003)(199004)(189003)(4326008)(33656002)(478600001)(7696005)(6506007)(52536014)(86362001)(110136005)(2906002)(8936002)(81166006)(81156014)(71200400001)(8676002)(55016002)(26005)(9686003)(6636002)(5660300002)(66556008)(66946007)(316002)(64756008)(66446008)(76116006)(66476007)(186003)(54906003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3923; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y8u2Srgdfahj2b2M0WwIWxH+zT3wZ12NrxyBBN67tR4mo9IC6aDGqcsdxLDa4+IOuUTXa6iPXvHJuch/jfSSbbTD8q8nU8ftiYGoYrdgdHVf6vXhMlYztTl0449fkiBhnSR8xHFgQeZMJBWW1HKJvGl+1XKx824WVtDUPwgXZLU5hV/I8GvuIckT6aMsxMJyt4lxKuw5xKx3D0XHm79SxYML2fsQfxS2QSlHsqiHxot/tSPTO3H1u4nKtkQT6FXyq9yvdnAK3+YtLPodaS6doGe+4jv6btfyPEmm/qqRa66zcAQSt+gzkZdjSbEucqcE+KymkgCznVvHykN6h0k+EcMLlvlPVTbnJG2hyvbhDOddV1Q5H3GDnr6KK1ZemGzB+bqZKo9YW4ujzhekCOu1pxHXx8Ot/1LutK/IZ9LCkadJOVoiwu9zM2PEE3vik1BR x-ms-exchange-antispam-messagedata: sU81LJCxC3AWXoOmhFOEORbBmIGctqzD8QAdhmSG7Cb5cdISnDmsbJEcLOUblzDe8c6L/cKc9xTTDEmuQCJ6LkpjoZoKuI9WfFP7mWYbazxfrv8FSyy9D8KY2aQdO2adNrbYVcxHu8GHZ8ZPLi1/IA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a25cd49-d235-47a1-c354-08d7bf42af11 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2020 07:15:42.1488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GMTqAUemj/og3js+fvF/iwwHuEwNnuIzR+BwF8b8rU3NN60H+pe2etNA6VrSTPjLtlnKT1ZsNGtlCQWtz+3kMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3923 Subject: Re: [dpdk-dev] [PATCH dpdk-dev v2] common/mlx5: fix possible building error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi From: xiangxia.m.yue@gmail.com > From: Tonghao Zhang >=20 > When setting the CONFIG_RTE_BUILD_SHARED_LIB to y, and build the mlx5 > pmd, there is a building error. > To fix it, add RTE_IBVERBS_LINK_DLOPEN to include relative codes. >=20 > > mlx5_common.o: In function `mlx5_glue_init': > > drivers/common/mlx5/mlx5_common.c:324: undefined reference to > `dlclose' >=20 > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > Cc: stable@dpdk.org >=20 > Signed-off-by: Tonghao Zhang > Tested-by: Ali Alnubani The title should point to the root cause - not to the results. Something like: common/mlx5: fix dynamic loading reference > drivers/common/mlx5/mlx5_common.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common.c > b/drivers/common/mlx5/mlx5_common.c > index 610fb48..570a3f4 100644 > --- a/drivers/common/mlx5/mlx5_common.c > +++ b/drivers/common/mlx5/mlx5_common.c > @@ -209,8 +209,6 @@ enum mlx5_class > */ > RTE_INIT_PRIO(mlx5_glue_init, CLASS) > { > - void *handle =3D NULL; > - > /* Initialize common log type. */ > mlx5_common_logtype =3D rte_log_register("pmd.common.mlx5"); > if (mlx5_common_logtype >=3D 0) > @@ -249,6 +247,7 @@ enum mlx5_class > mlx5_glue_path(glue_path, sizeof(glue_path)) : ""), > }; > unsigned int i =3D 0; > + void *handle =3D NULL; > void **sym; > const char *dlmsg; >=20 > @@ -320,8 +319,10 @@ enum mlx5_class > mlx5_glue->fork_init(); > return; > glue_error: > +#ifdef RTE_IBVERBS_LINK_DLOPEN > if (handle) > dlclose(handle); > +#endif What's about " #include " Is it compiled for you? If so, why dlclose is not known on your setup? > DRV_LOG(WARNING, "Cannot initialize MLX5 common due to > missing" > " run-time dependency on rdma-core libraries (libibverbs," > " libmlx5)"); > -- > 1.8.3.1