From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31F6DA059F; Fri, 10 Apr 2020 16:15:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78EC81D51E; Fri, 10 Apr 2020 16:15:26 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by dpdk.org (Postfix) with ESMTP id CBC581D167 for ; Fri, 10 Apr 2020 16:15:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhcZlzNh+KjGdBi09YEt8chE5VfwkCwqScuRYTlkXSfaJzzN+sxskUUm3Kceb6zwUxPX2EwEpOtVX6OaJFM45r3vjO3HuoHltBcoKaXO9PHVD4ZqSsAxfl27uECbHdVtO5kxEWA0Q5iqQ68buXNVIDlRODfzC/RUut7q6zpKD9BLizYtBXXDtO5DsJr05JKiP78yby/D3FJ/HE7RKOI8YWaTjjVHiyJ2fmbmTdG7R1UEDBXttpBo9PrBDJSTvZTPY6GHWEsoMjohk1GMQrikZJsJDy9V5DZ4Gh0OtAXc1ZYY1k3ZV2BaorqVe5qmJsOWhSnoAoUCps2xIZxKmbe48w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZoBThOuMM21ES19QbpDqEGx1rPCGUsZmBA4qyW3De6k=; b=db3I6gcYOb2pwPaF9ItCQ4G/iaStrx7zDGdaBdNxz4qx0e09HtfPuo3sO+UlogTnfrigF4ip37P5CT3/jkw8HSpNFgztYcAf5F48RQGq7IzZvy06+GEiQPi6PrgnQlx2KMvx+zLjaIivOizGGJoJnb+JqF3nKNP1Tz4C5+WbS635iLgKCgLmj3Hofg41vcVK33Ho2H8RMZUxmWEJY8v+eZ+RxC872RMoB7Y3n3pT5NucVSG8uaNgBH/BOTKbKxupDcR6Prnu/wZRkZFoycaf9SreQogNOT94pJs83JiCdcUatFV4HRU1uTUOqwCw+jg0GsKzfaAnyRvpnNxzX1s+2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZoBThOuMM21ES19QbpDqEGx1rPCGUsZmBA4qyW3De6k=; b=IYFz3efjrIoFfLybUhZXgxuqa9MuEnS9+AQ1MGjaFRTbgcQQJos1Py6/MYO7PMgbBBOxo+qBjTHW98Ejt3tP3dW87Nv58vXEaxufHomLb3NVZulY3/oxzF7geAEga2S2GfnyK7iMdS6/TeiC2IIj6h9IhoIQ9lBY/h/USsvZqpU= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (2603:10a6:208:f::11) by AM0PR0502MB3729.eurprd05.prod.outlook.com (2603:10a6:208:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Fri, 10 Apr 2020 14:15:23 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::a564:a117:9022:1fee%7]) with mapi id 15.20.2878.022; Fri, 10 Apr 2020 14:15:23 +0000 From: Matan Azrad To: Maxime Coquelin , "dev@dpdk.org" CC: Slava Ovsiienko , Shahaf Shuler , Xiao Wang , Tiwei Bie Thread-Topic: [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats Thread-Index: AQHWDnv9y39aiT+frEu5KbXOgnIV0KhyXfDggAAG6gCAAAILkA== Date: Fri, 10 Apr 2020 14:15:23 +0000 Message-ID: References: <1584371573-4243-1-git-send-email-matan@mellanox.com> <5e9ad602-e60c-1098-9171-19948be86c2a@redhat.com> In-Reply-To: <5e9ad602-e60c-1098-9171-19948be86c2a@redhat.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.126.88.104] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 11f2704d-0ead-4e33-aac9-08d7dd599be9 x-ms-traffictypediagnostic: AM0PR0502MB3729:|AM0PR0502MB3729: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0369E8196C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(66476007)(6506007)(53546011)(66446008)(81156014)(66946007)(8936002)(7696005)(71200400001)(316002)(110136005)(86362001)(4326008)(54906003)(64756008)(9686003)(66556008)(33656002)(26005)(76116006)(478600001)(186003)(8676002)(55016002)(52536014)(2906002)(5660300002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Lfgk85QTr5u+a5HOHgJFok25dcHnyXTAxJPYxOnG43uwq+sVTvXezNMmtFfkXr6RYgt8hkuVFhqM3PtIq9AuXl+VqsTX1ecleTNcnA4JpTGIW80NwkPGuMNSmnMzsheNFx13hCONU/5KVwzVIUgEvb5+nzzNnWk33/Jlxl3nq/IRebwZMvPobTT+t3y09fB3tUjS2Z4QGqTMrRJ49TDO0F1+sVAcVAsgr26QbPpYBBmy+j7P+vaeJvlVJZ2pWo7oyBMc9RhVeDuaC9xkEwGaXzaKNSlbGysgSkNzpTK6OL/OqhsRUdSe/9bdC7NMkqPnvgmQXvRIjI+9cC+c1bnnn9hAioHv8/zR1vhhj705whIkfdPUK03iMa6nY1Alx1Y7HxKoz3nSSHvvR7e2A6LrUyDbp8rLYTVHBdgnwiNCp1WkEaFWydaM7pwgVZ9yjMXy x-ms-exchange-antispam-messagedata: FsbsUW9yBYpDdDZ/EJMIedlWDUoWZi6n7BNhgSmNNIwaCmoff63O/axXYahJFfZh2iiSo/+j4yBokG2fyapDmtaITNlUlshkI7RWepbAT2hW5ELGCweYpt2kT9WbApicx64i1guP+8U29dSexdRXTg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11f2704d-0ead-4e33-aac9-08d7dd599be9 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2020 14:15:23.2785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IhFNzhLCxzZKCXtgMmr9UeS0DaN7Mq6c1Ew/J5CKbCXnuIwmXy+finTrtjEcN2zDhUn09Sh2qj4prw8j9Bi0YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3729 Subject: Re: [dpdk-dev] [PATCH] [RFC] vhost: inroduce operation to get vDPA queue stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Maxime Coquelin > Sent: Friday, April 10, 2020 5:04 PM > To: Matan Azrad ; dev@dpdk.org > Cc: Slava Ovsiienko ; Shahaf Shuler > ; Xiao Wang ; Tiwei Bie > > Subject: Re: [PATCH] [RFC] vhost: inroduce operation to get vDPA queue > stats >=20 >=20 >=20 > On 4/10/20 3:54 PM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin > >> Hi Matan, > >> > >> On 3/16/20 4:12 PM, Matan Azrad wrote: > >>> The vDPA device offloads all the datapath of the vhost device to the > >>> HW device. > >>> > >>> In order to expose to the user traffic information this patch > >>> introduce new API to get traffic statistics per virtio queue. > >>> > >>> The statistics are taken directly from the vDPA driver managing the > >>> HW device. > >> > >> Shouldn't the stats be collected from the PF like for "legacy" SR-IOV > >> via the sysfs? > >> Something like: > >> /sys/class/net//device/sriov//stats/ > > > > Yes, probably, statistics can be taken from sysfs. > > > > But we are introducing a DPDK API to get the virtio statistics. > > So, driver which can take statistics from there can take them from sysf= s in > the driver operation. > > > > In addition, the API includes per virtio queue statistics and in virtio= data- > path terms, it is very helpful for debuggability. >=20 > Ok, the per queue stats is a valid point for queue debug. >=20 > Even if we add this API, I still think we should ensure the stats will be > available through the sysfs, so that it makes Kubernetes integration seem= less > wrt to legacy SR-IOV[0]. For Mellanox legacy SRIOV the sysfs stats you mentioned are available. > Also, it would provide a single way to get statistics for both DPDK and K= ernel > vDPA. Sure. > Thanks, > Maxime >=20 > > > > > >> Regards, > >> Maxime > >