From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D73DA04AB; Fri, 8 Nov 2019 07:18:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 839941BE80; Fri, 8 Nov 2019 07:18:48 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140047.outbound.protection.outlook.com [40.107.14.47]) by dpdk.org (Postfix) with ESMTP id BFEBF1BE0C for ; Fri, 8 Nov 2019 07:18:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kjs2Re79sVTXj4TQrrRf7t0Myl787MNY+ePzLqDNfOiMSIqQA95BBVBoRKAXnpvTIagKz524AXdvjcbgb5LkYU9+lZdoo4LNzuU4Mm5Ly0pu/R2Fe0FmzsfGA9k9UG0pILDWC/8Um/JQKGmzVqNOFnMEcnYhI0xPFkB71msVPH9n4+BTKSHn3OhGKPsYF5mAn73bmdiroIde3r9LnmljyD/5udOV+goO6fL/zputclsTMA3cCol8ar9/7uZxANgYVE2Nl02CMqOhhx9k4UY2sONutWnJmDn5XHF88cpqz+ZO1K4GBmsJaJzhposkSCclzut61tFcdRDYL8ph8leTAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGD4fEKJT3B0ctYe3CoH+s6xRmEKyPrW5LbU106Z5I4=; b=f9LXgJiocz4o53A8YW9eqc+F/URxOtKAb5JwEjo54FTYTBKLrvFuoR47AvOc50ClUQFnRaNPNepMcm+OHTUxXAaEngDYqmbXWnQouJbTu/veP2TJnEMUrnUANEJw9PIWNCR0qRQgEKlzjkh/EHC39um311Uz9j5+wHDUMJgKG+Im66h7eNrngMIf8GZfBn2l9HT1ZcPGkCNZEK60WksF0nM+PMGijpDOwvxKqXrtV8VSaNC/zz9Hi8GNPudkLnsJUFSwzuDrKlGgEVB/XwGdTZ6PWQoj9njvau4Wrx+wAipK+Txlq/1NSZYnowNRKKQHWRV2fpfs+vzLFRVzn1W56w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGD4fEKJT3B0ctYe3CoH+s6xRmEKyPrW5LbU106Z5I4=; b=PiG/ucfcSXUMRMeBbCM1pfqHA32ebtauinxovT8Efrp5jT67aUZQyvSE+qUMZAV1eSSuLa3QcgWbSiu/jpV3hw/U50TPvH+w8ZOokk28WUA2rIvc1+5TnQS9eQeFvf0VmfAPxos7maIj5GLcXcwxCtxQyPg0PbnrfKKn1hTqenI= Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com (52.133.39.139) by AM0PR0502MB3715.eurprd05.prod.outlook.com (52.133.50.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.24; Fri, 8 Nov 2019 06:18:45 +0000 Received: from AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0]) by AM0PR0502MB4019.eurprd05.prod.outlook.com ([fe80::fd7a:e5a8:deec:c1b0%7]) with mapi id 15.20.2430.023; Fri, 8 Nov 2019 06:18:45 +0000 From: Matan Azrad To: Slava Ovsiienko , "dev@dpdk.org" CC: Raslan Darawsheh , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig Thread-Index: AQHVlW3Ysu7wvSC8AEGFmGp5bLqEtKeAzcyA Date: Fri, 8 Nov 2019 06:18:45 +0000 Message-ID: References: <1573132704-6637-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1573132704-6637-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [77.127.71.76] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cf79c8b1-1a54-4645-c057-08d7641382af x-ms-traffictypediagnostic: AM0PR0502MB3715:|AM0PR0502MB3715: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 0215D7173F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(199004)(189003)(478600001)(8936002)(229853002)(486006)(102836004)(256004)(55016002)(3846002)(9686003)(14454004)(476003)(86362001)(186003)(66446008)(66556008)(2906002)(76176011)(6506007)(66476007)(74316002)(26005)(4326008)(6246003)(76116006)(5660300002)(52536014)(107886003)(11346002)(66946007)(81156014)(2501003)(7696005)(33656002)(446003)(7736002)(66066001)(316002)(99286004)(6116002)(64756008)(110136005)(54906003)(71190400001)(6436002)(71200400001)(4744005)(8676002)(305945005)(81166006)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR0502MB3715; H:AM0PR0502MB4019.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nmxTAvmEtcVvPjE15QqFSjmqtABJFwLy8i3kJRgcwmLvcnZBbe0o4XiGBG759dea/PzYQcgrqffDwmLu3Ytlf+DGciTXiT63phW2Y+29cotld421XS+ddZfLxal/3AAVWFgilDkSNETHhSU1oMUlHXdBNysLwu1WkthIegfgk3iaMSS3Fdecb3uJz2B5P0ckFK5bkcFjzg3hg1mj/Tn6rWIblcWZ4oSkE53sFGtKPZ86940mrnWh97dARZttJhpSGWZjjGHq+jZkJ4d3amh9OCbf7HYeUrL8b9bhiyIPf6hCYWGPDdoVPc0P9B6Fc0leWW24/Q2djE2SujjAfZmStvw2C1oOT4Yp9jp19DXcGtIzU6lZSAyeK4QtKWMxpXW+ou5KOtZKcwr/Jrcntp/wnXtQXH8SYbDicX1u21YXW8Lb9+xMkqFgHB8elGYP2aci Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf79c8b1-1a54-4645-c057-08d7641382af X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 06:18:45.5117 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 07OYVroX6OYkF6yje24RsNMUziiNlT5xbo+/kpvsRuY4h5sam+Vdii5EZvWTaPwymbU40XChL3bX0S5JTQQGmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0502MB3715 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Viacheslav Ovsiienko > To support multi-segment packet sending the Tx datapath > DEV_TX_OFFLOAD_MULTI_SEGS offload must be configured. > In debug configuration the asserts arise if the multi-segment packet is b= eing > sent and no DEV_TX_OFFLOAD_MULTI_SEGS is set. > It was found that in some execution paths asserts were missed, this patch > adds ones. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") >=20 > Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad